From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"dmitrym@microsoft.com" <dmitrym@microsoft.com>,
"khot@microsoft.com" <khot@microsoft.com>,
"navasile@microsoft.com" <navasile@microsoft.com>,
"ocardona@microsoft.com" <ocardona@microsoft.com>,
"Kadam, Pallavi" <pallavi.kadam@intel.com>,
"roretzla@microsoft.com" <roretzla@microsoft.com>,
"talshn@nvidia.com" <talshn@nvidia.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [PATCH v18 8/8] eal: implement functions for mutex management
Date: Tue, 8 Feb 2022 19:08:54 -0800 [thread overview]
Message-ID: <20220209030854.GB9377@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <DM6PR11MB4491556033D68A51F0A98ACC9A2C9@DM6PR11MB4491.namprd11.prod.outlook.com>
On Mon, Feb 07, 2022 at 04:02:54PM +0000, Ananyev, Konstantin wrote:
> > Add functions for mutex init, destroy, lock, unlock, trylock.
> >
> > Windows does not have a static initializer. Initialization
> > is only done through InitializeCriticalSection(). To overcome this,
> > RTE_INIT_MUTEX macro is added to replace static initialization
> > of mutexes. The macro calls rte_thread_mutex_init().
> >
> > Add unit tests to verify that the mutex correctly locks/unlocks
> > and protects the data. Check both static and dynamic mutexes.
> > Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
>
> Few comments from me below.
> I am not sure was such approach already discussed,
> if so - apologies for repetition.
>
No worries, I appreciate your review!
> > ---
> > app/test/test_threads.c | 106 +++++++++++++++++++++++++++++++++++
> > lib/eal/common/rte_thread.c | 69 +++++++++++++++++++++++
> > lib/eal/include/rte_thread.h | 85 ++++++++++++++++++++++++++++
> > lib/eal/version.map | 5 ++
> > lib/eal/windows/rte_thread.c | 64 +++++++++++++++++++++
> > 5 files changed, 329 insertions(+)
> >
> > };
> > diff --git a/lib/eal/common/rte_thread.c b/lib/eal/common/rte_thread.c
> > index d30a8a7ca3..4a9a1b6e07 100644
> > --- a/lib/eal/common/rte_thread.c
> > +++ b/lib/eal/common/rte_thread.c
> > @@ -309,6 +309,75 @@ rte_thread_detach(rte_thread_t thread_id)
> > return pthread_detach((pthread_t)thread_id.opaque_id);
> > }
> >
> > +int
> > +rte_thread_mutex_init(rte_thread_mutex *mutex)
>
> Don't we need some sort of mutex_attr here too?
> To be able to create PROCESS_SHARED mutexes?
Attributes are tricky to implement on Windows.
In order to not overcomplicate this patchset and since the drivers
that need them don't compile on Windows anyway, I decided to omit
them from this patchset. In the future, after enabling the new thread API,
we can consider implementing them as well.
>
> > +{
> > + int ret = 0;
> > + pthread_mutex_t *m = NULL;
> > +
> > + RTE_VERIFY(mutex != NULL);
> > +
> > + m = calloc(1, sizeof(*m));
>
> But is that what we really want for the mutexes?
> It means actual mutex will always be allocated on process heap,
> away from the data it is supposed to guard.
> Even if we'll put performance considerations away,
> that wouldn't work for MP case.
> Is that considered as ok?
Are you refering to the fact that all mutexes will be dynamically allocated,
due to the static intializer calling _mutex_init() in the background?
Why wouldn't it work in the MP case?
>
> > + if (m == NULL) {
> > + RTE_LOG(DEBUG, EAL, "Unable to initialize mutex. Insufficient memory!\n");
> > + ret = ENOMEM;
> > + goto cleanup;
> > + }
> > +
> > +
> > + return ret;
> > +}
> > + return pthread_mutex_trylock((pthread_mutex_t *)mutex->mutex_id);
next prev parent reply other threads:[~2022-02-09 3:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 16:02 Ananyev, Konstantin
2022-02-08 2:21 ` Ananyev, Konstantin
2022-02-09 2:47 ` Narcisa Ana Maria Vasile
2022-02-09 13:57 ` Ananyev, Konstantin
2022-02-20 21:56 ` Dmitry Kozlyuk
2022-02-23 17:08 ` Dmitry Kozlyuk
2022-02-24 17:29 ` Ananyev, Konstantin
2022-02-24 17:44 ` Stephen Hemminger
2022-03-08 21:36 ` Dmitry Kozlyuk
2022-03-08 21:33 ` Dmitry Kozlyuk
2022-02-09 3:08 ` Narcisa Ana Maria Vasile [this message]
2022-02-09 12:12 ` Ananyev, Konstantin
-- strict thread matches above, loose matches on Subject: below --
2021-11-10 3:01 [dpdk-dev] [PATCH v17 00/13] eal: Add EAL API for threading Narcisa Ana Maria Vasile
2021-11-11 1:33 ` [PATCH v18 0/8] " Narcisa Ana Maria Vasile
2021-11-11 1:33 ` [PATCH v18 8/8] eal: implement functions for mutex management Narcisa Ana Maria Vasile
2021-12-13 20:27 ` Narcisa Ana Maria Vasile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209030854.GB9377@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=navasile@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=khot@microsoft.com \
--cc=konstantin.ananyev@intel.com \
--cc=navasile@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@microsoft.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).