* [dpdk-ci] Wrong Checkpatch failure in Intel CI
@ 2020-03-31 19:51 Jerin Jacob Kollanukkaran
2020-03-31 20:03 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2020-03-31 19:51 UTC (permalink / raw)
To: zhaoyan.chen, ci, sys_stv
Cc: Nithin Kumar Dabilpuram, Thomas Monjalon, david.marchand
Hello,
It looks like "devtools/check-symbol-change.sh" cached in Intel Patchwork CI.
The commit[2] is fixed the issue reported by [1]. The commit[2] already part of
Master but some reason some this cached in CI system and it pick OLD checkpatch infra.
Could someone look into this issue from Intel side?
[1]
http://mails.dpdk.org/archives/test-report/2020-March/123095.html
[2]
commit f08885494f241b115ad66763b585fbfb486d5160
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date: Mon Mar 23 17:26:13 2020 +0530
devtools: fix symbol map change check
Fix check symbol change script to detect new diff file when
it is in between "--- /dev/null" to "b/lib/...".
Current awk line expects line to start with "a/..."
which is not always true for all diffs.
As a result if in_map was '1' earlier, it will not be changed
to '0' and we get check patch errors which are not true.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Tested-by: Jerin Jacob <jerinj@marvell.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-ci] Wrong Checkpatch failure in Intel CI
2020-03-31 19:51 [dpdk-ci] Wrong Checkpatch failure in Intel CI Jerin Jacob Kollanukkaran
@ 2020-03-31 20:03 ` Thomas Monjalon
2020-03-31 20:12 ` [dpdk-ci] [EXT] " Jerin Jacob Kollanukkaran
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2020-03-31 20:03 UTC (permalink / raw)
To: zhaoyan.chen, ci, Jerin Jacob Kollanukkaran
Cc: sys_stv, Nithin Kumar Dabilpuram, david.marchand
31/03/2020 21:51, Jerin Jacob Kollanukkaran:
> Hello,
>
> It looks like "devtools/check-symbol-change.sh" cached in Intel Patchwork CI.
> The commit[2] is fixed the issue reported by [1]. The commit[2] already part of
> Master but some reason some this cached in CI system and it pick OLD checkpatch infra.
>
> Could someone look into this issue from Intel side?
>
>
> [1]
> http://mails.dpdk.org/archives/test-report/2020-March/123095.html
This email comes from checkpatch@dpdk.org
This is not Intel infrastructure.
I will update checkpatch on dpdk.org.
Side note: Marvell is allowed to run some tests and send reports
as part of the distributed CI.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-ci] [EXT] Re: Wrong Checkpatch failure in Intel CI
2020-03-31 20:03 ` Thomas Monjalon
@ 2020-03-31 20:12 ` Jerin Jacob Kollanukkaran
2020-03-31 20:39 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2020-03-31 20:12 UTC (permalink / raw)
To: Thomas Monjalon, zhaoyan.chen, ci
Cc: sys_stv, Nithin Kumar Dabilpuram, david.marchand
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, April 1, 2020 1:33 AM
> To: zhaoyan.chen@intel.com; ci@dpdk.org; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Cc: sys_stv@intel.com; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; david.marchand@redhat.com
> Subject: [EXT] Re: Wrong Checkpatch failure in Intel CI
>
> External Email
>
> ----------------------------------------------------------------------
> 31/03/2020 21:51, Jerin Jacob Kollanukkaran:
> > Hello,
> >
> > It looks like "devtools/check-symbol-change.sh" cached in Intel Patchwork CI.
> > The commit[2] is fixed the issue reported by [1]. The commit[2]
> > already part of Master but some reason some this cached in CI system and it
> pick OLD checkpatch infra.
> >
> > Could someone look into this issue from Intel side?
> >
> >
> > [1]
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__mails.dpdk.org_arc
> > hives_test-2Dreport_2020-
> 2DMarch_123095.html&d=DwICAg&c=nKjWec2b6R0mOy
> >
> Paz7xtfQ&r=1DGob4H4rxz6H8uITozGOCa0s5f4wCNtTa4UUKvcsvI&m=RErROLH
> hI94iK
> > fA-Ee95iCZBQDqP8JFGsyTT9Nq5e8w&s=iL1-
> HL1ttarMJ5bCAL0aIxUjp49eoa3xUMldw
> > ma-CTw&e=
>
> This email comes from checkpatch@dpdk.org This is not Intel infrastructure.
OK. I was not aware of it. Sorry guys.
> I will update checkpatch on dpdk.org.
The actual change is in devtools/check-symbol-change.sh. I am not sure why it is not picking up.
Hope updating the checkpatch will fix it. Just for the record, I am testing with checkpatch.pl from 5.6.0-rc5 kernel + todays dpdk.org master.
>
> Side note: Marvell is allowed to run some tests and send reports as part of the
> distributed CI.
Good info.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-ci] [EXT] Re: Wrong Checkpatch failure in Intel CI
2020-03-31 20:12 ` [dpdk-ci] [EXT] " Jerin Jacob Kollanukkaran
@ 2020-03-31 20:39 ` Thomas Monjalon
2020-04-01 11:22 ` Jerin Jacob Kollanukkaran
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2020-03-31 20:39 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran; +Cc: ci, Nithin Kumar Dabilpuram, david.marchand
31/03/2020 22:12, Jerin Jacob Kollanukkaran:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > I will update checkpatch on dpdk.org.
>
> The actual change is in devtools/check-symbol-change.sh. I am not sure why it is not picking up.
This is because the scripts used by checkpatch@dpdk.org
are not updated automatically.
Why not? Because I never took time for it.
> Hope updating the checkpatch will fix it.
> Just for the record, I am testing with checkpatch.pl from 5.6.0-rc5 kernel + todays dpdk.org master.
Tell me if you still see an issue.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-ci] [EXT] Re: Wrong Checkpatch failure in Intel CI
2020-03-31 20:39 ` Thomas Monjalon
@ 2020-04-01 11:22 ` Jerin Jacob Kollanukkaran
2020-04-01 12:18 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2020-04-01 11:22 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: ci, Nithin Kumar Dabilpuram, david.marchand
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, April 1, 2020 2:09 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: ci@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>;
> david.marchand@redhat.com
> Subject: Re: [EXT] Re: Wrong Checkpatch failure in Intel CI
>
> 31/03/2020 22:12, Jerin Jacob Kollanukkaran:
> > > From: Thomas Monjalon <thomas@monjalon.net> I will update checkpatch
> > > on dpdk.org.
> >
> > The actual change is in devtools/check-symbol-change.sh. I am not sure why it
> is not picking up.
>
> This is because the scripts used by checkpatch@dpdk.org are not updated
> automatically.
> Why not? Because I never took time for it.
>
> > Hope updating the checkpatch will fix it.
> > Just for the record, I am testing with checkpatch.pl from 5.6.0-rc5 kernel +
> todays dpdk.org master.
>
> Tell me if you still see an issue.
I assume, I can NOT verify now by re-trigger or something.
I will report this issue if it is comes up in future in any of my patch.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-ci] [EXT] Re: Wrong Checkpatch failure in Intel CI
2020-04-01 11:22 ` Jerin Jacob Kollanukkaran
@ 2020-04-01 12:18 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-04-01 12:18 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran; +Cc: ci, Nithin Kumar Dabilpuram, david.marchand
01/04/2020 13:22, Jerin Jacob Kollanukkaran:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 31/03/2020 22:12, Jerin Jacob Kollanukkaran:
> > > > From: Thomas Monjalon <thomas@monjalon.net> I will update checkpatch
> > > > on dpdk.org.
> > >
> > > The actual change is in devtools/check-symbol-change.sh. I am not sure why it
> > is not picking up.
> >
> > This is because the scripts used by checkpatch@dpdk.org are not updated
> > automatically.
> > Why not? Because I never took time for it.
> >
> > > Hope updating the checkpatch will fix it.
> > > Just for the record, I am testing with checkpatch.pl from 5.6.0-rc5 kernel +
> > todays dpdk.org master.
> >
> > Tell me if you still see an issue.
>
> I assume, I can NOT verify now by re-trigger or something.
> I will report this issue if it is comes up in future in any of my patch.
Yes this is what I meant.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-01 12:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 19:51 [dpdk-ci] Wrong Checkpatch failure in Intel CI Jerin Jacob Kollanukkaran
2020-03-31 20:03 ` Thomas Monjalon
2020-03-31 20:12 ` [dpdk-ci] [EXT] " Jerin Jacob Kollanukkaran
2020-03-31 20:39 ` Thomas Monjalon
2020-04-01 11:22 ` Jerin Jacob Kollanukkaran
2020-04-01 12:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).