Re: [dpdk-ci] |SUCCESS| [PATCH 2/3] maintainers: update virtio section name

Re: [dpdk-ci] |SUCCESS| [PATCH 2/3] maintainers: update virtio section name

[Thomas Monjalon]

2016-12-01 08:44, Xu, Qian Q:
> > On Thu, Dec 01, 2016 at 08:06:41AM +0100, checkpatch@dpdk.org wrote:
> > > Test-Label: checkpatch
> > > Test-Status: SUCCESS
> > > http://dpdk.org/patch/17348
> > >
> > > _coding style OK_
> > 
> > Great!  This kind of emails is something I'd like to see for a while.
> > But I don't like to receive SUCCESS notice. Normally, I'm positive my patches are
> > well qualified. The SUCCESS notice only makes my inbox fat-er but nothing else.

It is a bug.
If the email has the list-id dev.dpdk.org, success should not be reported to the author.

> > Of course, I'd like to receive failure notices if any.

> Thomas is the owner for the check patch, I wonder if Thomas can add one button or provide options for the patch submitters to receive the mails or not. 
> Generally developer may not want to receive the SUCCESS mail, but some may want to receive the mail to make sure the test is done and all pass. We may 
> not simply disable all SUCCESS mails, instead we'd better provide choice for people. 

If the patch is directly sent to checkpatch@dpdk.org, the author receive
the report (success or failure).
If the patch is sent to the mailing list, he receives only the failure
and can check success on patchwork.
I don't see the point of receiving success reports if it is public.

Re: [dpdk-ci] |SUCCESS| [PATCH 2/3] maintainers: update virtio section name

[Wei, FangfangX]

[-- Attachment #1: Type: text/plain, Size: 2153 bytes --]

Hi Thomas,

I can receive the checkpatch email no matter the result is success or warning.
Through the attached email, we can see the receiver is test-report@dpdk.org and cc to the author, no matter what the result is.
And above two patches are send to the mailing list dev@dpdk.org.

I think currently the checkpatch email has not been done according to the status of the message sent to different recipients.

Best Regards
Fangfang Wei

-----Original Message-----
From: ci [mailto:ci-bounces@dpdk.org] On Behalf Of Thomas Monjalon
Sent: Thursday, December 1, 2016 5:06 PM
To: Xu, Qian Q <qian.q.xu@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Cao, Waterman <waterman.cao@intel.com>; ci@dpdk.org
Subject: Re: [dpdk-ci] |SUCCESS| [PATCH 2/3] maintainers: update virtio section name

2016-12-01 08:44, Xu, Qian Q:
> > On Thu, Dec 01, 2016 at 08:06:41AM +0100, checkpatch@dpdk.org wrote:
> > > Test-Label: checkpatch
> > > Test-Status: SUCCESS
> > > http://dpdk.org/patch/17348
> > >
> > > _coding style OK_
> > 
> > Great!  This kind of emails is something I'd like to see for a while.
> > But I don't like to receive SUCCESS notice. Normally, I'm positive 
> > my patches are well qualified. The SUCCESS notice only makes my inbox fat-er but nothing else.

It is a bug.
If the email has the list-id dev.dpdk.org, success should not be reported to the author.

> > Of course, I'd like to receive failure notices if any.

> Thomas is the owner for the check patch, I wonder if Thomas can add one button or provide options for the patch submitters to receive the mails or not. 
> Generally developer may not want to receive the SUCCESS mail, but some 
> may want to receive the mail to make sure the test is done and all pass. We may not simply disable all SUCCESS mails, instead we'd better provide choice for people.

If the patch is directly sent to checkpatch@dpdk.org, the author receive the report (success or failure).
If the patch is sent to the mailing list, he receives only the failure and can check success on patchwork.
I don't see the point of receiving success reports if it is public.

[-- Attachment #2: Type: message/rfc822, Size: 2491 bytes --]

From: "checkpatch@dpdk.org" <checkpatch@dpdk.org>
To: "test-report@dpdk.org" <test-report@dpdk.org>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: [dpdk-test-report] |SUCCESS| [PATCH 3/3] maintainers: add stable mailing list
Date: Thu, 1 Dec 2016 07:06:44 +0000
Message-ID: <20161201070644.8FA8168A5@dpdk.org>

Test-Label: checkpatch
Test-Status: SUCCESS
http://dpdk.org/patch/17349

_coding style OK_



[-- Attachment #3: Type: message/rfc822, Size: 2736 bytes --]

From: "checkpatch@dpdk.org" <checkpatch@dpdk.org>
To: "test-report@dpdk.org" <test-report@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| [PATCH v2] net/i40evf: fix casting between structs
Date: Wed, 30 Nov 2016 02:03:06 +0000
Message-ID: <20161130020306.9453E379B@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17336

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#91: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1364:
+                * i40e_aq_send_msg_to_vf in PF driver.*/

total: 0 errors, 1 warnings, 0 checks, 66 lines checked

Re: [dpdk-ci] |SUCCESS| [PATCH 2/3] maintainers: update virtio section name

[Thomas Monjalon]

2016-12-01 09:47, Wei, FangfangX:
> Hi Thomas,
> 
> I can receive the checkpatch email no matter the result is success or warning.
> Through the attached email, we can see the receiver is test-report@dpdk.org and cc to the author, no matter what the result is.
> And above two patches are send to the mailing list dev@dpdk.org.
> 
> I think currently the checkpatch email has not been done according to the status of the message sent to different recipients.

Yes it's broken since a rework I did just before submitting the scripts.
It should be fixed in v2 just sent.


> -----Original Message-----
> From: ci [mailto:ci-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, December 1, 2016 5:06 PM
> To: Xu, Qian Q <qian.q.xu@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Cc: Cao, Waterman <waterman.cao@intel.com>; ci@dpdk.org
> Subject: Re: [dpdk-ci] |SUCCESS| [PATCH 2/3] maintainers: update virtio section name
> 
> 2016-12-01 08:44, Xu, Qian Q:
> > > On Thu, Dec 01, 2016 at 08:06:41AM +0100, checkpatch@dpdk.org wrote:
> > > > Test-Label: checkpatch
> > > > Test-Status: SUCCESS
> > > > http://dpdk.org/patch/17348
> > > >
> > > > _coding style OK_
> > > 
> > > Great!  This kind of emails is something I'd like to see for a while.
> > > But I don't like to receive SUCCESS notice. Normally, I'm positive 
> > > my patches are well qualified. The SUCCESS notice only makes my inbox fat-er but nothing else.
> 
> It is a bug.
> If the email has the list-id dev.dpdk.org, success should not be reported to the author.
> 
> > > Of course, I'd like to receive failure notices if any.
> 
> > Thomas is the owner for the check patch, I wonder if Thomas can add one button or provide options for the patch submitters to receive the mails or not. 
> > Generally developer may not want to receive the SUCCESS mail, but some 
> > may want to receive the mail to make sure the test is done and all pass. We may not simply disable all SUCCESS mails, instead we'd better provide choice for people.
> 
> If the patch is directly sent to checkpatch@dpdk.org, the author receive the report (success or failure).
> If the patch is sent to the mailing list, he receives only the failure and can check success on patchwork.
> I don't see the point of receiving success reports if it is public.