Re: [dpdk-ci] script to determine target repo (was DPDK Lab)

[Thomas Monjalon <thomas@monjalon.net>]

I agree with Bruce.

Sorry for not having written the scripts yet.
Someone else in Mellanox should do it in July.
In the meantime, do not hesitate to share your code if it speed up things.

Thanks a lot


21/06/2017 10:20, Richardson, Bruce:
> Hi Fangfang,
> 
> My comments on the questions you asked:
> 
> 1. For determining the repo tree to target, I don't believe that we can ever come up with a 100% accurate rule, as the tree to which a set is to be applied can be difficult to determine, so it may be done on the basis of on-list discussion. A 90% accurate rule it what we may have to accept. However, since applying a patchset to a tree should not be a time-consuming operation, I suggest any script produce a list of possible trees in priority order to try. If not net, then try main, etc. etc.
> 
> 2. Using the order from patch titles is correct.
> 
> /Bruce
> 
> > -----Original Message-----
> > From: Wei, FangfangX
> > Sent: Wednesday, June 21, 2017 8:46 AM
> > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Qian Q
> > <qian.q.xu@intel.com>
> > Cc: ci@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> > O'Driscoll, Tim <tim.odriscoll@intel.com>
> > Subject: RE: [dpdk-ci] script to determine target repo (was DPDK Lab)
> > 
> > Hi Thomas,
> > 
> > What's the status about the script which determine target repo for each
> > patch set?
> > Currently I used the rule which you told me before: "the subject prefix on
> > the patches should provide the hint. If the majority of the patches start
> > with "net/" then it's for next-net, and similarly for crypto. Patches with
> > virtio or vhost go to that tree, etc".
> > But I'm not sure about the 100% correct repo.
> > Looking forward to your script.
> > 
> > Another thing, Qian told me that you want to know the apply sequence about
> > many patches in one patch set.
> > I don't apply patches with the order of patchwork id, but the names' order
> > about them.
> > Such as, patchset 25081-25085, the order of patchwork id is not the
> > correct patches' order.
> > http://dpdk.org/patch/25081, subject: [dpdk-dev,v2,1/5] net/qede:
> > refactoring vport handling code http://dpdk.org/patch/25083, subject:
> > [dpdk-dev,v2,2/5] net/qede: refactoring multi-queue implementation
> > http://dpdk.org/patch/25084, subject: [dpdk-dev,v2,3/5] net/qede/base:
> > upgrade the FW to 8.20.0.0 http://dpdk.org/patch/25082, subject: [dpdk-
> > dev,v2,4/5] net/qede: fix VXLAN tunnel Tx offload flag setting
> > http://dpdk.org/patch/25085, subject: [dpdk-dev,v2,5/5] net/qede: refactor
> > Tx routine After download them, the patches' names are as below:
> > http://dpdk.org/patch/25081: dpdk-dev-v2-1-5-net-qede-refactoring-vport-
> > handling-code.patch
> > http://dpdk.org/patch/25083: dpdk-dev-v2-2-5-net-qede-refactoring-multi-
> > queue-implementation.patch
> > http://dpdk.org/patch/25084: dpdk-dev-v2-3-5-net-qede-base-upgrade-the-FW-
> > to-8.20.0.0.patch
> > http://dpdk.org/patch/25082: dpdk-dev-v2-4-5-net-qede-fix-VXLAN-tunnel-Tx-
> > offload-flag-setting.patch
> > http://dpdk.org/patch/25085: dpdk-dev-v2-5-5-net-qede-refactor-Tx-
> > routine.patch
> > 
> > So applying these patches based on the order of their names, it will be
> > correct.
> > 
> > 
> > Best Regards
> > Fangfang Wei
> > 
> > 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, April 25, 2017 2:51 PM
> > To: Xu, Qian Q <qian.q.xu@intel.com>
> > Cc: ci@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Wei,
> > FangfangX <fangfangx.wei@intel.com>; O'Driscoll, Tim
> > <tim.odriscoll@intel.com>; Liu, Yuanhan <yuanhan.liu@intel.com>
> > Subject: Re: [dpdk-ci] script to determine target repo (was DPDK Lab)
> > 
> > 25/04/2017 08:23, Xu, Qian Q:
> > > Thanks Thomas and Bruce for your comments. Currently we are trying to
> > > start the per patch set performance test investigation and need to know
> > the Target repo for each patch set.
> > > The goal is to get 100% correct repo to go for each patch set. It's
> > important for the credit of the performance result.
> > > @Thomas, could you provide any script to support the auto-filter after
> > the 17.05 release? Currently, we don't have the ability to make it.
> > 
> > OK, it is on my todo list.
> > 
> > Other task: I want to check the series support in the patchwork git.