From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78166A04DE for ; Wed, 21 Oct 2020 11:00:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 275D2AD01; Wed, 21 Oct 2020 11:00:18 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 50861AC64; Wed, 21 Oct 2020 11:00:13 +0200 (CEST) IronPort-SDR: 0nZYK1rNhGcZhhy7KzESyyvlvP0WIKGC7vw8nv3d8vr+RhBllYfPr5O6/PnPHQwX82Jmj6A3lq Pr6qnwIXAamw== X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="231528908" X-IronPort-AV: E=Sophos;i="5.77,400,1596524400"; d="scan'208";a="231528908" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 02:00:07 -0700 IronPort-SDR: JMIPo84z+mUtIjpl8khk7r4B+dO9MaaPyCaG6YpxaSWRRgBU9mkjke2/LGFiYac134kFqXbANO kzMMFo6OxQbw== X-IronPort-AV: E=Sophos;i="5.77,400,1596524400"; d="scan'208";a="533451403" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.249.97]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 21 Oct 2020 02:00:05 -0700 Date: Wed, 21 Oct 2020 10:00:00 +0100 From: Bruce Richardson To: Dmitry Kozlyuk Cc: dev@dpdk.org, ci@dpdk.org, Stephen Hemminger , David Marchand , Thomas Monjalon , Maxime Coquelin , Aaron Conole , Michael Santana Message-ID: <20201021090000.GA592@bricha3-MOBL.ger.corp.intel.com> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <20201020174404.28653-1-dmitry.kozliuk@gmail.com> <20201020174404.28653-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201020174404.28653-3-dmitry.kozliuk@gmail.com> Subject: Re: [dpdk-ci] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" On Tue, Oct 20, 2020 at 08:44:02PM +0300, Dmitry Kozlyuk wrote: > Use the same interpreter to run pmdinfogen as for other build scripts. > Adjust wrapper script accordingly and also don't suppress stderr from ar > and pmdinfogen. > > Add configure-time check for elftools Python module for Unix hosts. > > Add python3-pyelftools to CI configuration. The package is available on > all major distributions. FreeBSD has no system requirements section in > its GSG. Currently neither Windows uses pmdinfogen, nor is COFF (PE) > supported. > > Signed-off-by: Dmitry Kozlyuk > --- >From a meson viewpoint, this all looks ok. I'd hope in future that we could merge the shell script wrapper into the python script directly, rather than having two levels of scripting, but it's not something with any urgency. Acked-by: Bruce Richardson > .travis.yml | 2 +- > buildtools/gen-pmdinfo-cfile.sh | 6 +++--- > buildtools/meson.build | 15 +++++++++++++++ > doc/guides/linux_gsg/sys_reqs.rst | 6 ++++++ > drivers/meson.build | 2 +- > meson.build | 1 - > 6 files changed, 26 insertions(+), 6 deletions(-) >