Re: [PATCH v19 00/27] remove use of VLAs for Windows

DPDK CI discussions
 help / color / mirror / Atom feed

* Re: [PATCH v19 00/27] remove use of VLAs for Windows
       [not found] ` <1738555590-12753-1-git-send-email-andremue@linux.microsoft.com>
@ 2025-02-03 15:30   ` David Marchand
  2025-02-04 15:38     ` Patrick Robb
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2025-02-03 15:30 UTC (permalink / raw)
  To: Andre Muezerie
  Cc: dev, konstantin.ananyev, thomas, Patrick Robb, ci, Aaron Conole

On Mon, Feb 3, 2025 at 5:06 AM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> As per guidance technical board meeting 2024/04/17. This series
> removes the use of VLAs from code built for Windows for all 3
> toolchains. If there are additional opportunities to convert VLAs
> to regular C arrays please provide the details for incorporation
> into the series.
>
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.

Recheck-request: iol-testing


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v19 00/27] remove use of VLAs for Windows
  2025-02-03 15:30   ` [PATCH v19 00/27] remove use of VLAs for Windows David Marchand
@ 2025-02-04 15:38     ` Patrick Robb
  2025-02-04 16:27       ` Andre Muezerie
  0 siblings, 1 reply; 3+ messages in thread
From: Patrick Robb @ 2025-02-04 15:38 UTC (permalink / raw)
  To: David Marchand
  Cc: Andre Muezerie, dev, konstantin.ananyev, thomas, ci,
	Aaron Conole, Cody Cheng

[-- Attachment #1: Type: text/plain, Size: 16641 bytes --]

It looks like this failed the check-meson script which we incorporated into
our apply/build pipeline recently, which is why this series got a "build
failure." It is indicating there are issues with lib/vhost/meson.build
and app/test/meson.build.

Obviously we need to provide an email body which makes clear that
check-meson was the source of the failure, and I have a UNH Lab ticket for
this.

Running Check Meson
 Processing meson.build
 Processing usertools/meson.build
 Processing kernel/meson.build
 Processing kernel/freebsd/meson.build
 Processing kernel/freebsd/contigmem/meson.build
 Processing kernel/freebsd/nic_uio/meson.build
 Processing app/meson.build
 Processing app/dumpcap/meson.build
 Processing app/test-security-perf/meson.build
 Processing app/test-acl/meson.build
 Processing app/test-regex/meson.build
 Processing app/test-fib/meson.build
 Processing app/test-compress-perf/meson.build
 Processing app/test-pmd/meson.build
 Processing app/test-gpudev/meson.build
 Processing app/test-mldev/meson.build
 Processing app/test-crypto-perf/meson.build
 Processing app/test-bbdev/meson.build
 Processing app/test/meson.build
 Error: Incorrect indent at app/test/meson.build:257
 Error: Incorrect indent at app/test/meson.build:258
 Processing app/test/suites/meson.build
 Processing app/test/test_cfgfiles/meson.build
 Processing app/test-dma-perf/meson.build
 Processing app/proc-info/meson.build
 Processing app/test-pipeline/meson.build
 Processing app/graph/meson.build
 Processing app/test-eventdev/meson.build
 Processing app/test-cmdline/meson.build
 Processing app/test-sad/meson.build
 Processing app/test-flow-perf/meson.build
 Processing app/pdump/meson.build
 Processing config/meson.build
 Processing config/arm/meson.build
 Processing config/riscv/meson.build
 Processing config/ppc/meson.build
 Processing config/x86/meson.build
 Processing config/loongarch/meson.build
 Processing buildtools/meson.build
 Processing buildtools/pkg-config/meson.build
 Processing buildtools/subproject/meson.build
 Processing buildtools/chkincs/meson.build
 Processing examples/meson.build
 Processing examples/distributor/meson.build
 Processing examples/fips_validation/meson.build
 Processing examples/l3fwd-power/meson.build
 Processing examples/vhost_crypto/meson.build
 Processing examples/l2fwd-cat/meson.build
 Processing examples/ipsec-secgw/meson.build
 Processing examples/bbdev_app/meson.build
 Processing examples/l2fwd-event/meson.build
 Processing examples/vdpa/meson.build
 Processing examples/dma/meson.build
 Processing examples/vhost/meson.build
 Processing examples/l2fwd/meson.build
 Processing examples/ethtool/meson.build
 Processing examples/vhost_blk/meson.build
 Processing examples/packet_ordering/meson.build
 Processing examples/bond/meson.build
 Processing examples/l2fwd-macsec/meson.build
 Processing examples/eventdev_pipeline/meson.build
 Processing examples/ipv4_multicast/meson.build
 Processing examples/l3fwd/meson.build
 Processing examples/pipeline/meson.build
 Processing examples/vmdq/meson.build
 Processing examples/cmdline/meson.build
 Processing examples/ip_fragmentation/meson.build
 Processing examples/helloworld/meson.build
 Processing examples/flow_filtering/meson.build
 Processing examples/link_status_interrupt/meson.build
 Processing examples/l2fwd-keepalive/meson.build
 Processing examples/service_cores/meson.build
 Processing examples/l2fwd-jobstats/meson.build
 Processing examples/qos_meter/meson.build
 Processing examples/ptpclient/meson.build
 Processing examples/qos_sched/meson.build
 Processing examples/multi_process/symmetric_mp/meson.build
 Processing examples/multi_process/hotplug_mp/meson.build
 Processing examples/multi_process/client_server_mp/mp_server/meson.build
 Processing examples/multi_process/client_server_mp/mp_client/meson.build
 Processing examples/multi_process/simple_mp/meson.build
 Processing examples/timer/meson.build
 Processing examples/vmdq_dcb/meson.build
 Processing examples/rxtx_callbacks/meson.build
 Processing examples/ntb/meson.build
 Processing examples/l2fwd-crypto/meson.build
 Processing examples/skeleton/meson.build
 Processing examples/server_node_efd/efd_node/meson.build
 Processing examples/server_node_efd/efd_server/meson.build
 Processing examples/ip_reassembly/meson.build
 Processing examples/l3fwd-graph/meson.build
 Processing examples/vm_power_manager/meson.build
 Processing examples/vm_power_manager/guest_cli/meson.build
 Processing examples/ip_pipeline/meson.build
 Processing doc/meson.build
 Processing doc/api/meson.build
 Processing doc/api/dts/meson.build
 Processing doc/guides/meson.build
 Processing drivers/meson.build
 Processing drivers/crypto/meson.build
 Processing drivers/crypto/uadk/meson.build
 Processing drivers/crypto/scheduler/meson.build
 Processing drivers/crypto/nitrox/meson.build
 Processing drivers/crypto/ipsec_mb/meson.build
 Processing drivers/crypto/openssl/meson.build
 Processing drivers/crypto/bcmfs/meson.build
 Processing drivers/crypto/cnxk/meson.build
 Processing drivers/crypto/mvsam/meson.build
 Processing drivers/crypto/ionic/meson.build
 Processing drivers/crypto/ccp/meson.build
 Processing drivers/crypto/dpaa_sec/meson.build
 Processing drivers/crypto/dpaa2_sec/meson.build
 Processing drivers/crypto/octeontx/meson.build
 Processing drivers/crypto/mlx5/meson.build
 Processing drivers/crypto/armv8/meson.build
 Processing drivers/crypto/null/meson.build
 Processing drivers/crypto/caam_jr/meson.build
 Processing drivers/crypto/virtio/meson.build
 Processing drivers/vdpa/meson.build
 Processing drivers/vdpa/sfc/meson.build
 Processing drivers/vdpa/nfp/meson.build
 Processing drivers/vdpa/ifc/meson.build
 Processing drivers/vdpa/mlx5/meson.build
 Processing drivers/dma/meson.build
 Processing drivers/dma/idxd/meson.build
 Processing drivers/dma/odm/meson.build
 Processing drivers/dma/dpaa2/meson.build
 Processing drivers/dma/cnxk/meson.build
 Processing drivers/dma/dpaa/meson.build
 Processing drivers/dma/hisilicon/meson.build
 Processing drivers/dma/ioat/meson.build
 Processing drivers/dma/skeleton/meson.build
 Processing drivers/common/meson.build
 Processing drivers/common/iavf/meson.build
 Processing drivers/common/nitrox/meson.build
 Processing drivers/common/nfp/meson.build
 Processing drivers/common/dpaax/meson.build
 Processing drivers/common/cnxk/meson.build
 Processing drivers/common/sfc_efx/meson.build
 Processing drivers/common/sfc_efx/base/meson.build
 Processing drivers/common/ionic/meson.build
 Processing drivers/common/octeontx/meson.build
 Processing drivers/common/mlx5/meson.build
 Processing drivers/common/mlx5/linux/meson.build
 Processing drivers/common/mlx5/windows/meson.build
 Processing drivers/common/idpf/meson.build
 Processing drivers/common/idpf/base/meson.build
 Processing drivers/common/mvep/meson.build
 Processing drivers/common/cpt/meson.build
 Processing drivers/common/qat/meson.build
 Processing drivers/mempool/meson.build
 Processing drivers/mempool/bucket/meson.build
 Processing drivers/mempool/dpaa2/meson.build
 Processing drivers/mempool/cnxk/meson.build
 Processing drivers/mempool/octeontx/meson.build
 Processing drivers/mempool/dpaa/meson.build
 Processing drivers/mempool/ring/meson.build
 Processing drivers/mempool/stack/meson.build
 Processing drivers/ml/meson.build
 Processing drivers/ml/cnxk/meson.build
 Processing drivers/event/meson.build
 Processing drivers/event/opdl/meson.build
 Processing drivers/event/dpaa2/meson.build
 Processing drivers/event/cnxk/meson.build
 Processing drivers/event/sw/meson.build
 Processing drivers/event/octeontx/meson.build
 Processing drivers/event/dpaa/meson.build
 Processing drivers/event/dsw/meson.build
 Processing drivers/event/dlb2/meson.build
 Processing drivers/event/skeleton/meson.build
 Processing drivers/compress/meson.build
 Processing drivers/compress/uadk/meson.build
 Processing drivers/compress/nitrox/meson.build
 Processing drivers/compress/octeontx/meson.build
 Processing drivers/compress/mlx5/meson.build
 Processing drivers/compress/isal/meson.build
 Processing drivers/compress/zlib/meson.build
 Processing drivers/bus/meson.build
 Processing drivers/bus/fslmc/meson.build
 Processing drivers/bus/ifpga/meson.build
 Processing drivers/bus/platform/meson.build
 Processing drivers/bus/auxiliary/meson.build
 Processing drivers/bus/dpaa/meson.build
 Processing drivers/bus/uacce/meson.build
 Processing drivers/bus/pci/meson.build
 Processing drivers/bus/cdx/meson.build
 Processing drivers/bus/vdev/meson.build
 Processing drivers/bus/vmbus/meson.build
 Processing drivers/regex/meson.build
 Processing drivers/regex/mlx5/meson.build
 Processing drivers/regex/cn9k/meson.build
 Processing drivers/gpu/meson.build
 Processing drivers/gpu/cuda/meson.build
 Processing drivers/net/meson.build
 Processing drivers/net/zxdh/meson.build
 Processing drivers/net/sfc/meson.build
 Processing drivers/net/bnx2x/meson.build
 Processing drivers/net/ngbe/meson.build
 Processing drivers/net/ngbe/base/meson.build
 Processing drivers/net/netvsc/meson.build
 Processing drivers/net/failsafe/meson.build
 Processing drivers/net/qede/meson.build
 Processing drivers/net/qede/base/meson.build
 Processing drivers/net/gve/meson.build
 Processing drivers/net/intel/i40e/meson.build
 Processing drivers/net/intel/i40e/base/meson.build
 Processing drivers/net/intel/ice/meson.build
 Processing drivers/net/intel/ice/base/meson.build
 Processing drivers/net/intel/iavf/meson.build
 Processing drivers/net/intel/fm10k/meson.build
 Processing drivers/net/intel/fm10k/base/meson.build
 Processing drivers/net/intel/igc/meson.build
 Processing drivers/net/intel/igc/base/meson.build
 Processing drivers/net/intel/cpfl/meson.build
 Processing drivers/net/intel/e1000/meson.build
 Processing drivers/net/intel/e1000/base/meson.build
 Processing drivers/net/intel/ipn3ke/meson.build
 Processing drivers/net/intel/ixgbe/meson.build
 Processing drivers/net/intel/ixgbe/base/meson.build
 Processing drivers/net/intel/idpf/meson.build
 Processing drivers/net/txgbe/meson.build
 Processing drivers/net/txgbe/base/meson.build
 Processing drivers/net/r8169/meson.build
 Processing drivers/net/vhost/meson.build
 Processing drivers/net/hinic/meson.build
 Processing drivers/net/hinic/base/meson.build
 Processing drivers/net/nfp/meson.build
 Processing drivers/net/mana/meson.build
 Processing drivers/net/af_packet/meson.build
 Processing drivers/net/axgbe/meson.build
 Processing drivers/net/thunderx/meson.build
 Processing drivers/net/thunderx/base/meson.build
 Processing drivers/net/dpaa2/meson.build
 Processing drivers/net/cnxk/meson.build
 Processing drivers/net/enetc/meson.build
 Processing drivers/net/ionic/meson.build
 Processing drivers/net/mlx4/meson.build
 Processing drivers/net/avp/meson.build
 Processing drivers/net/af_xdp/meson.build
 Processing drivers/net/mvpp2/meson.build
 Processing drivers/net/octeontx/meson.build
 Processing drivers/net/octeontx/base/meson.build
 Processing drivers/net/tap/meson.build
 Processing drivers/net/tap/bpf/meson.build
 Processing drivers/net/memif/meson.build
 Processing drivers/net/mlx5/meson.build
 Processing drivers/net/mlx5/hws/meson.build
 Processing drivers/net/mlx5/linux/meson.build
 Processing drivers/net/mlx5/windows/meson.build
 Processing drivers/net/ena/meson.build
 Processing drivers/net/cxgbe/meson.build
 Processing drivers/net/enic/meson.build
 Processing drivers/net/ntnic/meson.build
 Processing drivers/net/dpaa/meson.build
 Processing drivers/net/nfb/meson.build
 Processing drivers/net/softnic/meson.build
 Processing drivers/net/bnxt/meson.build
 Processing drivers/net/bnxt/tf_ulp/meson.build
 Processing drivers/net/bnxt/tf_ulp/generic_templates/meson.build
 Processing drivers/net/bnxt/hcapi/cfa_v3/meson.build
 Processing drivers/net/bnxt/hcapi/cfa/meson.build
 Processing drivers/net/bnxt/tf_core/meson.build
 Processing drivers/net/bnxt/tf_core/v3/meson.build
 Processing drivers/net/ring/meson.build
 Processing drivers/net/enetfec/meson.build
 Processing drivers/net/null/meson.build
 Processing drivers/net/octeon_ep/meson.build
 Processing drivers/net/vdev_netvsc/meson.build
 Processing drivers/net/pfe/meson.build
 Processing drivers/net/pcap/meson.build
 Processing drivers/net/hns3/meson.build
 Processing drivers/net/mvneta/meson.build
 Processing drivers/net/atlantic/meson.build
 Processing drivers/net/virtio/meson.build
 Processing drivers/net/bonding/meson.build
 Processing drivers/net/ark/meson.build
 Processing drivers/net/vmxnet3/meson.build
 Processing drivers/power/meson.build
 Processing drivers/power/acpi/meson.build
 Processing drivers/power/intel_pstate/meson.build
 Processing drivers/power/amd_uncore/meson.build
 Processing drivers/power/amd_pstate/meson.build
 Processing drivers/power/kvm_vm/meson.build
 Processing drivers/power/cppc/meson.build
 Processing drivers/power/intel_uncore/meson.build
 Processing drivers/raw/meson.build
 Processing drivers/raw/cnxk_bphy/meson.build
 Processing drivers/raw/gdtc/meson.build
 Processing drivers/raw/ifpga/meson.build
 Processing drivers/raw/ifpga/base/meson.build
 Processing drivers/raw/dpaa2_cmdif/meson.build
 Processing drivers/raw/cnxk_gpio/meson.build
 Processing drivers/raw/cnxk_rvu_lf/meson.build
 Processing drivers/raw/ntb/meson.build
 Processing drivers/raw/skeleton/meson.build
 Processing drivers/baseband/meson.build
 Processing drivers/baseband/fpga_5gnr_fec/meson.build
 Processing drivers/baseband/fpga_lte_fec/meson.build
 Processing drivers/baseband/la12xx/meson.build
 Processing drivers/baseband/acc/meson.build
 Processing drivers/baseband/null/meson.build
 Processing drivers/baseband/turbo_sw/meson.build
 Processing lib/meson.build
 Processing lib/bpf/meson.build
 Processing lib/latencystats/meson.build
 Processing lib/bbdev/meson.build
 Processing lib/distributor/meson.build
 Processing lib/eal/meson.build
 Processing lib/eal/arm/meson.build
 Processing lib/eal/arm/include/meson.build
 Processing lib/eal/freebsd/meson.build
 Processing lib/eal/freebsd/include/meson.build
 Processing lib/eal/common/meson.build
 Processing lib/eal/include/meson.build
 Processing lib/eal/linux/meson.build
 Processing lib/eal/linux/include/meson.build
 Processing lib/eal/riscv/meson.build
 Processing lib/eal/riscv/include/meson.build
 Processing lib/eal/unix/meson.build
 Processing lib/eal/windows/meson.build
 Processing lib/eal/windows/include/meson.build
 Processing lib/eal/ppc/meson.build
 Processing lib/eal/ppc/include/meson.build
 Processing lib/eal/x86/meson.build
 Processing lib/eal/x86/include/meson.build
 Processing lib/eal/loongarch/meson.build
 Processing lib/eal/loongarch/include/meson.build
 Processing lib/member/meson.build
 Processing lib/rawdev/meson.build
 Processing lib/gro/meson.build
 Processing lib/fib/meson.build
 Processing lib/vhost/meson.build
 Error: Incorrect indent at lib/vhost/meson.build:23
 Error: Incorrect indent at lib/vhost/meson.build:24
 Processing lib/argparse/meson.build
 Processing lib/node/meson.build
 Processing lib/kvargs/meson.build
 Processing lib/mempool/meson.build
 Processing lib/pdcp/meson.build
 Processing lib/ptr_compress/meson.build
 Processing lib/mldev/meson.build
 Processing lib/rib/meson.build
 Processing lib/regexdev/meson.build
 Processing lib/ip_frag/meson.build
 Processing lib/bitratestats/meson.build
 Processing lib/hash/meson.build
 Processing lib/sched/meson.build
 Processing lib/eventdev/meson.build
 Processing lib/efd/meson.build
 Processing lib/meter/meson.build
 Processing lib/rcu/meson.build
 Processing lib/pipeline/meson.build
 Processing lib/cmdline/meson.build
 Processing lib/acl/meson.build
 Processing lib/jobstats/meson.build
 Processing lib/log/meson.build
 Processing lib/table/meson.build
 Processing lib/pcapng/meson.build
 Processing lib/port/meson.build
 Processing lib/ethdev/meson.build
 Processing lib/dmadev/meson.build
 Processing lib/ipsec/meson.build
 Processing lib/ring/meson.build
 Processing lib/gpudev/meson.build
 Processing lib/cryptodev/meson.build
 Processing lib/pci/meson.build
 Processing lib/cfgfile/meson.build
 Processing lib/net/meson.build
 Processing lib/dispatcher/meson.build
 Processing lib/reorder/meson.build
 Processing lib/power/meson.build
 Processing lib/graph/meson.build
 Processing lib/timer/meson.build
 Processing lib/stack/meson.build
 Processing lib/compressdev/meson.build
 Processing lib/metrics/meson.build
 Processing lib/telemetry/meson.build
 Processing lib/gso/meson.build
 Processing lib/lpm/meson.build
 Processing lib/security/meson.build
 Processing lib/pdump/meson.build
 Processing lib/mbuf/meson.build

[-- Attachment #2: Type: text/html, Size: 18262 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v19 00/27] remove use of VLAs for Windows
  2025-02-04 15:38     ` Patrick Robb
@ 2025-02-04 16:27       ` Andre Muezerie
  0 siblings, 0 replies; 3+ messages in thread
From: Andre Muezerie @ 2025-02-04 16:27 UTC (permalink / raw)
  To: Patrick Robb
  Cc: David Marchand, dev, konstantin.ananyev, thomas, ci,
	Aaron Conole, Cody Cheng

On Tue, Feb 04, 2025 at 10:38:55AM -0500, Patrick Robb wrote:
> It looks like this failed the check-meson script which we incorporated into
> our apply/build pipeline recently, which is why this series got a "build
> failure." It is indicating there are issues with lib/vhost/meson.build
> and app/test/meson.build.
> 
> Obviously we need to provide an email body which makes clear that
> check-meson was the source of the failure, and I have a UNH Lab ticket for
> this.
> 
> Running Check Meson
>  Error: Incorrect indent at app/test/meson.build:257
>  Error: Incorrect indent at app/test/meson.build:258
>  Error: Incorrect indent at lib/vhost/meson.build:23
>  Error: Incorrect indent at lib/vhost/meson.build:24

Thanks for clarifying that Patrick.
I submitted v20 for this series fixing the errors above.
--
Andre Muezerie

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-04 16:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
     [not found] ` <1738555590-12753-1-git-send-email-andremue@linux.microsoft.com>
2025-02-03 15:30   ` [PATCH v19 00/27] remove use of VLAs for Windows David Marchand
2025-02-04 15:38     ` Patrick Robb
2025-02-04 16:27       ` Andre Muezerie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).