* Re: [PATCH v7 2/3] log: separate logging functions out of EAL
[not found] ` <20230731153902.2350026-3-bruce.richardson@intel.com>
@ 2023-07-31 16:22 ` David Marchand
2023-07-31 16:29 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2023-07-31 16:22 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Morten Brørup, Tyler Retzlaff, ci
On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
> index 1a4210b948..40f7dd2877 100644
> --- a/doc/api/doxy-api.conf.in
> +++ b/doc/api/doxy-api.conf.in
> @@ -52,6 +52,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \
> @TOPDIR@/lib/kni \
> @TOPDIR@/lib/kvargs \
> @TOPDIR@/lib/latencystats \
> + @TOPDIR@/lib/log \
> @TOPDIR@/lib/lpm \
> @TOPDIR@/lib/mbuf \
> @TOPDIR@/lib/member \
In case you are wondering about the reason.. the Intel CI reports an
error on building the documentation:
*Build Failed #1:
OS: UB2204-64
Target: x86_64-native-linuxapp-doc
FAILED: doc/api/html
/usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html
/usr/bin/doxygen doc/api/doxy-api.conf
/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc/api/doxy-api-index.md:230:
error: unable to resolve reference to 'rte_log.h' for \ref command
(warning treated as error, aborting now)
Traceback (most recent call last):
File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py",
line 13, in <module>
subprocess.run(doxygen_command, check=True, stdout=out)
File "/usr/lib/python3.10/subprocess.py", line 524, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/doxygen',
'doc/api/doxy-api.conf']' returned non-zero exit status 1.
[2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o
[2773/2774] Generating doc/guides/html_guides with a custom command
ninja: build stopped
IIRC Intel CI excludes changes on the doc/ directory when applying patches.
http://inbox.dpdk.org/dev/CY5PR11MB618735108D3E9D90C67EEF96F5DA9@CY5PR11MB6187.namprd11.prod.outlook.com/
.. which seems to match the failure reported here, as doxygen would
fail to find rte_log.h.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v7 2/3] log: separate logging functions out of EAL
2023-07-31 16:22 ` [PATCH v7 2/3] log: separate logging functions out of EAL David Marchand
@ 2023-07-31 16:29 ` Bruce Richardson
2023-08-01 9:21 ` Thomas Monjalon
2023-08-09 10:00 ` Bruce Richardson
0 siblings, 2 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-07-31 16:29 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Morten Brørup, Tyler Retzlaff, ci
On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote:
> On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
> > index 1a4210b948..40f7dd2877 100644
> > --- a/doc/api/doxy-api.conf.in
> > +++ b/doc/api/doxy-api.conf.in
> > @@ -52,6 +52,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \
> > @TOPDIR@/lib/kni \
> > @TOPDIR@/lib/kvargs \
> > @TOPDIR@/lib/latencystats \
> > + @TOPDIR@/lib/log \
> > @TOPDIR@/lib/lpm \
> > @TOPDIR@/lib/mbuf \
> > @TOPDIR@/lib/member \
>
> In case you are wondering about the reason.. the Intel CI reports an
> error on building the documentation:
>
> *Build Failed #1:
> OS: UB2204-64
> Target: x86_64-native-linuxapp-doc
> FAILED: doc/api/html
> /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html
> /usr/bin/doxygen doc/api/doxy-api.conf
> /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc/api/doxy-api-index.md:230:
> error: unable to resolve reference to 'rte_log.h' for \ref command
> (warning treated as error, aborting now)
> Traceback (most recent call last):
> File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py",
> line 13, in <module>
> subprocess.run(doxygen_command, check=True, stdout=out)
> File "/usr/lib/python3.10/subprocess.py", line 524, in run
> raise CalledProcessError(retcode, process.args,
> subprocess.CalledProcessError: Command '['/usr/bin/doxygen',
> 'doc/api/doxy-api.conf']' returned non-zero exit status 1.
> [2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o
> [2773/2774] Generating doc/guides/html_guides with a custom command
> ninja: build stopped
>
> IIRC Intel CI excludes changes on the doc/ directory when applying patches.
> http://inbox.dpdk.org/dev/CY5PR11MB618735108D3E9D90C67EEF96F5DA9@CY5PR11MB6187.namprd11.prod.outlook.com/
>
> .. which seems to match the failure reported here, as doxygen would
> fail to find rte_log.h.
>
Yes, I was very much wondering about the reason for failure, since I could
find no issues with building the docs on my own system!
Thanks for the info.
/Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v7 2/3] log: separate logging functions out of EAL
2023-07-31 16:29 ` Bruce Richardson
@ 2023-08-01 9:21 ` Thomas Monjalon
2023-08-09 10:00 ` Bruce Richardson
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2023-08-01 9:21 UTC (permalink / raw)
To: Bruce Richardson; +Cc: David Marchand, Morten Brørup, Tyler Retzlaff, ci
31/07/2023 18:29, Bruce Richardson:
> On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote:
> > On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
> > > index 1a4210b948..40f7dd2877 100644
> > > --- a/doc/api/doxy-api.conf.in
> > > +++ b/doc/api/doxy-api.conf.in
> > > @@ -52,6 +52,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \
> > > @TOPDIR@/lib/kni \
> > > @TOPDIR@/lib/kvargs \
> > > @TOPDIR@/lib/latencystats \
> > > + @TOPDIR@/lib/log \
> > > @TOPDIR@/lib/lpm \
> > > @TOPDIR@/lib/mbuf \
> > > @TOPDIR@/lib/member \
> >
> > In case you are wondering about the reason.. the Intel CI reports an
> > error on building the documentation:
> >
> > *Build Failed #1:
> > OS: UB2204-64
> > Target: x86_64-native-linuxapp-doc
> > FAILED: doc/api/html
> > /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html
> > /usr/bin/doxygen doc/api/doxy-api.conf
> > /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc/api/doxy-api-index.md:230:
> > error: unable to resolve reference to 'rte_log.h' for \ref command
> > (warning treated as error, aborting now)
> > Traceback (most recent call last):
> > File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py",
> > line 13, in <module>
> > subprocess.run(doxygen_command, check=True, stdout=out)
> > File "/usr/lib/python3.10/subprocess.py", line 524, in run
> > raise CalledProcessError(retcode, process.args,
> > subprocess.CalledProcessError: Command '['/usr/bin/doxygen',
> > 'doc/api/doxy-api.conf']' returned non-zero exit status 1.
> > [2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o
> > [2773/2774] Generating doc/guides/html_guides with a custom command
> > ninja: build stopped
> >
> > IIRC Intel CI excludes changes on the doc/ directory when applying patches.
> > http://inbox.dpdk.org/dev/CY5PR11MB618735108D3E9D90C67EEF96F5DA9@CY5PR11MB6187.namprd11.prod.outlook.com/
> >
> > .. which seems to match the failure reported here, as doxygen would
> > fail to find rte_log.h.
> >
> Yes, I was very much wondering about the reason for failure, since I could
> find no issues with building the docs on my own system!
Please can you help to avoid such issue in future with the Intel lab?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v7 2/3] log: separate logging functions out of EAL
2023-07-31 16:29 ` Bruce Richardson
2023-08-01 9:21 ` Thomas Monjalon
@ 2023-08-09 10:00 ` Bruce Richardson
1 sibling, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-08-09 10:00 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Morten Brørup, Tyler Retzlaff, ci
On Mon, Jul 31, 2023 at 05:29:04PM +0100, Bruce Richardson wrote:
> On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote:
> > On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
> > > index 1a4210b948..40f7dd2877 100644
> > > --- a/doc/api/doxy-api.conf.in
> > > +++ b/doc/api/doxy-api.conf.in
> > > @@ -52,6 +52,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \
> > > @TOPDIR@/lib/kni \
> > > @TOPDIR@/lib/kvargs \
> > > @TOPDIR@/lib/latencystats \
> > > + @TOPDIR@/lib/log \
> > > @TOPDIR@/lib/lpm \
> > > @TOPDIR@/lib/mbuf \
> > > @TOPDIR@/lib/member \
> >
> > In case you are wondering about the reason.. the Intel CI reports an
> > error on building the documentation:
> >
> > *Build Failed #1:
> > OS: UB2204-64
> > Target: x86_64-native-linuxapp-doc
> > FAILED: doc/api/html
> > /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html
> > /usr/bin/doxygen doc/api/doxy-api.conf
> > /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc/api/doxy-api-index.md:230:
> > error: unable to resolve reference to 'rte_log.h' for \ref command
> > (warning treated as error, aborting now)
> > Traceback (most recent call last):
> > File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py",
> > line 13, in <module>
> > subprocess.run(doxygen_command, check=True, stdout=out)
> > File "/usr/lib/python3.10/subprocess.py", line 524, in run
> > raise CalledProcessError(retcode, process.args,
> > subprocess.CalledProcessError: Command '['/usr/bin/doxygen',
> > 'doc/api/doxy-api.conf']' returned non-zero exit status 1.
> > [2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o
> > [2773/2774] Generating doc/guides/html_guides with a custom command
> > ninja: build stopped
> >
> > IIRC Intel CI excludes changes on the doc/ directory when applying patches.
> > http://inbox.dpdk.org/dev/CY5PR11MB618735108D3E9D90C67EEF96F5DA9@CY5PR11MB6187.namprd11.prod.outlook.com/
> >
> > .. which seems to match the failure reported here, as doxygen would
> > fail to find rte_log.h.
> >
> Yes, I was very much wondering about the reason for failure, since I could
> find no issues with building the docs on my own system!
>
Is this patchset ok for merge then, or is there something else outstanding
holding it back?
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-09 10:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220829151901.376754-1-bruce.richardson@intel.com>
[not found] ` <20230731153902.2350026-1-bruce.richardson@intel.com>
[not found] ` <20230731153902.2350026-3-bruce.richardson@intel.com>
2023-07-31 16:22 ` [PATCH v7 2/3] log: separate logging functions out of EAL David Marchand
2023-07-31 16:29 ` Bruce Richardson
2023-08-01 9:21 ` Thomas Monjalon
2023-08-09 10:00 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).