From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66E18A0C43 for ; Tue, 19 Oct 2021 09:01:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52F1C40142; Tue, 19 Oct 2021 09:01:30 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id BA1654003E; Tue, 19 Oct 2021 09:01:28 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="208540135" X-IronPort-AV: E=Sophos;i="5.85,383,1624345200"; d="scan'208";a="208540135" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 00:01:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,383,1624345200"; d="scan'208";a="594125939" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 19 Oct 2021 00:01:25 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 00:01:24 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 15:01:22 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Tue, 19 Oct 2021 15:01:21 +0800 From: "Tu, Lijuan" To: Honnappa Nagarahalli , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "Ananyev, Konstantin" , "ci@dpdk.org" , Lincoln Lavoie , "dpdklab@iol.unh.edu" CC: nd , "zoltan.kiss@schaman.hu" , nd Thread-Topic: [PATCH] ring: fix size of name array in ring structure Thread-Index: AQHXxDAMysQOcmHTsUymmsSP/uqoOqvZkKXQ Date: Tue, 19 Oct 2021 07:01:21 +0000 Message-ID: <273dc081fab040e3969541a234f9ad44@intel.com> References: <20211014205550.10140-1-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-ci] [PATCH] ring: fix size of name array in ring structure X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" I saw a lot of patches failed on test_scatter_mbuf_2048, the case could be = passed in intel lab. This is maintained by UNL guys.=20 + unl. > -----Original Message----- > From: Honnappa Nagarahalli > Sent: 2021=1B$BG/=1B(B10=1B$B7n=1B(B18=1B$BF|=1B(B 22:54 > To: Honnappa Nagarahalli ; dev@dpdk.org; > andrew.rybchenko@oktetlabs.ru; Ananyev, Konstantin > > Cc: nd ; zoltan.kiss@schaman.hu; Tu, Lijuan > ; nd > Subject: RE: [PATCH] ring: fix size of name array in ring structure >=20 > This patch has a CI failure in DTS in test_scatter_mbuf_2048 for Fortvill= e_Spirit > NIC. I am not sure how this change is related to the failure. The log is = as follows: >=20 > TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: 'packet rece= ive > error' >=20 > Has anyone seen this error? Is this a known issue? >=20 > Thanks, > Honnappa >=20 > > -----Original Message----- > > From: Honnappa Nagarahalli > > Sent: Thursday, October 14, 2021 3:56 PM > > To: dev@dpdk.org; Honnappa Nagarahalli ; > > andrew.rybchenko@oktetlabs.ru; konstantin.ananyev@intel.com > > Cc: nd ; zoltan.kiss@schaman.hu > > Subject: [PATCH] ring: fix size of name array in ring structure > > > > Use correct define for the name array size. The change breaks ABI and > > hence cannot be backported to stable branches. > > > > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data > > types") > > Cc: zoltan.kiss@schaman.hu > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > lib/ring/rte_ring_core.h | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index > > 31f7200fa9..46ad584f9c 100644 > > --- a/lib/ring/rte_ring_core.h > > +++ b/lib/ring/rte_ring_core.h > > @@ -118,12 +118,7 @@ struct rte_ring_hts_headtail { > > * a problem. > > */ > > struct rte_ring { > > - /* > > - * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI > > - * compatibility requirements, it could be changed to > > RTE_RING_NAMESIZE > > - * next time the ABI changes > > - */ > > - char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned; > > + char name[RTE_RING_NAMESIZE] __rte_cache_aligned; > > /**< Name of the ring. */ > > int flags; /**< Flags supplied at creation. */ > > const struct rte_memzone *memzone; > > -- > > 2.25.1