DPDK CI discussions
 help / color / mirror / Atom feed
* [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory
@ 2021-09-08 15:19 Ali Alnubani
  2021-09-09  8:31 ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Ali Alnubani @ 2021-09-08 15:19 UTC (permalink / raw)
  To: ci; +Cc: thomas, david.marchand

The unit test check_release_notes was failing because it didn't
find some of the DPDK sources, which has been causing the CI
script checkpatch.sh to sometimes report false positives.

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
 tests/checkpatch.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/checkpatch.sh b/tests/checkpatch.sh
index 0ce5414..2034e32 100755
--- a/tests/checkpatch.sh
+++ b/tests/checkpatch.sh
@@ -43,7 +43,7 @@ if echo $subject | grep -qi 'v[2-9].*\]' && [ -z "$reply" ] ; then
 	replyto_msg='Must be a reply to the first patch (--in-reply-to).\n\n'
 fi
 
-report=$($dpdkdir/devtools/checkpatches.sh -q $email) || failed=true
+report=$(cd $dpdkdir && devtools/checkpatches.sh -q $email) || failed=true
 report=$(echo "$report" | sed '1,/^###/d')
 
 label='checkpatch'
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory
  2021-09-08 15:19 [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory Ali Alnubani
@ 2021-09-09  8:31 ` David Marchand
  2021-09-09 14:47   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-09-09  8:31 UTC (permalink / raw)
  To: Ali Alnubani; +Cc: ci, Thomas Monjalon

On Wed, Sep 8, 2021 at 5:19 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> The unit test check_release_notes was failing because it didn't
> find some of the DPDK sources, which has been causing the CI
> script checkpatch.sh to sometimes report false positives.
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
>  tests/checkpatch.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/checkpatch.sh b/tests/checkpatch.sh
> index 0ce5414..2034e32 100755
> --- a/tests/checkpatch.sh
> +++ b/tests/checkpatch.sh
> @@ -43,7 +43,7 @@ if echo $subject | grep -qi 'v[2-9].*\]' && [ -z "$reply" ] ; then
>         replyto_msg='Must be a reply to the first patch (--in-reply-to).\n\n'
>  fi
>
> -report=$($dpdkdir/devtools/checkpatches.sh -q $email) || failed=true
> +report=$(cd $dpdkdir && devtools/checkpatches.sh -q $email) || failed=true
>  report=$(echo "$report" | sed '1,/^###/d')
>
>  label='checkpatch'

I did not find the time to investigate those false positives, thanks
for the fix.

Just summarizing the chat I add with Thomas.
We could fix the checkpatches.sh script in dpdk so that it looks for
the VERSION file relatively to the script location.
But it would remove the possibility to call devtools/checkpatches.sh
from a different working directory.
Whether this is a valid usecase is unclear, but we don't know what
other users of this script might be doing.

Your fix is simple enough and I don't see side effect.

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory
  2021-09-09  8:31 ` David Marchand
@ 2021-09-09 14:47   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-09-09 14:47 UTC (permalink / raw)
  To: Ali Alnubani; +Cc: David Marchand, ci

09/09/2021 10:31, David Marchand:
> On Wed, Sep 8, 2021 at 5:19 PM Ali Alnubani <alialnu@nvidia.com> wrote:
> >
> > The unit test check_release_notes was failing because it didn't
> > find some of the DPDK sources, which has been causing the CI
> > script checkpatch.sh to sometimes report false positives.
> >
> > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > ---
> >  tests/checkpatch.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > -report=$($dpdkdir/devtools/checkpatches.sh -q $email) || failed=true
> > +report=$(cd $dpdkdir && devtools/checkpatches.sh -q $email) || failed=true
> 
> I did not find the time to investigate those false positives, thanks
> for the fix.
> 
> Just summarizing the chat I add with Thomas.
> We could fix the checkpatches.sh script in dpdk so that it looks for
> the VERSION file relatively to the script location.
> But it would remove the possibility to call devtools/checkpatches.sh
> from a different working directory.
> Whether this is a valid usecase is unclear, but we don't know what
> other users of this script might be doing.
> 
> Your fix is simple enough and I don't see side effect.
> 
> Acked-by: David Marchand <david.marchand@redhat.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-09 14:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 15:19 [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory Ali Alnubani
2021-09-09  8:31 ` David Marchand
2021-09-09 14:47   ` Thomas Monjalon

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git