From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33587A0547 for ; Thu, 9 Sep 2021 16:47:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2762E40041; Thu, 9 Sep 2021 16:47:41 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 6C96E4003E for ; Thu, 9 Sep 2021 16:47:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E8FED5C00DB; Thu, 9 Sep 2021 10:47:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 09 Sep 2021 10:47:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= rWuLmZlVkna13+6aty1U06uSnMUU4805/jdup9OvpnI=; b=pf/jwcPL/gYq/tIX J4nqBvcZvNoLJv8YJLS8O8rZHvAuJwUU9zkNXEkkyYb/u9+LtP9wRSGFDlm1HruS Cx9AfFjNaJYU0u0XPaZW4p+cmxSTcnFahYd1MBcZSI1epID/UhlDLlVCwa4uIl3F kiN02abt7MchsoAOw/1IC6FofzC7X3QsipOtOZaCv1BPbIGzWMkL7esyOF4ebJFH yL7FBppryZGerw5pwIsvNBUCu6VAysvEsiTvL1GluJ9MIvaJQh2kkZix9ri/E4td J+zoz3VAii++oVYStVN7fxp+nD3o2zicBEMBQasHx0FisUMGeV5QPsEG8xuRxXps xwG9Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=rWuLmZlVkna13+6aty1U06uSnMUU4805/jdup9Ovp nI=; b=cv2YxXT5t1gKWYh2LVoLvYP3SGeUE6uhSXOsuT7mu+dHB7M10rFLYBer/ WdoSfE1VA7Wg883xtIIyq1M2PNVpWk4lSyRQtjnRckwvrqYl0qtC/6zExQSppvWt ng4lLBFNu2Ud9NZQ4aRag6TwFxK7xcFjW59x+AYg1dhaPQx5oqmX7LhXxek9A0TT NOfMH0cRt/f+wDRPl3/B0Y4f0f+1OT+jkdOFxC25AELby8r8KnfQ+rh2A0ExHvYK Ty5soyeWIoMNsBMkCqUm5ctDe1/vcuZvhC5ahNg24pQby4ptn5pEKlft1YRTq3+4 aWwMHOykAidd/3IVjBjr7mmR9Wt1w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefledgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 10:47:38 -0400 (EDT) From: Thomas Monjalon To: Ali Alnubani Cc: David Marchand , ci@dpdk.org Date: Thu, 09 Sep 2021 16:47:35 +0200 Message-ID: <2781044.7MX9mIAz5S@thomas> In-Reply-To: References: <20210908151936.5556-1-alialnu@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" 09/09/2021 10:31, David Marchand: > On Wed, Sep 8, 2021 at 5:19 PM Ali Alnubani wrote: > > > > The unit test check_release_notes was failing because it didn't > > find some of the DPDK sources, which has been causing the CI > > script checkpatch.sh to sometimes report false positives. > > > > Signed-off-by: Ali Alnubani > > --- > > tests/checkpatch.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > -report=$($dpdkdir/devtools/checkpatches.sh -q $email) || failed=true > > +report=$(cd $dpdkdir && devtools/checkpatches.sh -q $email) || failed=true > > I did not find the time to investigate those false positives, thanks > for the fix. > > Just summarizing the chat I add with Thomas. > We could fix the checkpatches.sh script in dpdk so that it looks for > the VERSION file relatively to the script location. > But it would remove the possibility to call devtools/checkpatches.sh > from a different working directory. > Whether this is a valid usecase is unclear, but we don't know what > other users of this script might be doing. > > Your fix is simple enough and I don't see side effect. > > Acked-by: David Marchand Acked-by: Thomas Monjalon Applied, thanks.