[dpdk-ci] [PATCH] Revert "tools: fix tree detection for orphan files"

[dpdk-ci] [PATCH] Revert "tools: fix tree detection for orphan files"

[David Marchand]

The problem with this patch is that some files were with no git tree in
MAINTAINERS on purpose: some files are maintained in the main repository,
but we leave subtrees touch them like release notes or makefile/meson
files.

So reverting it, and adding a comment to document the reason.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 tools/guess_git_tree.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tools/guess_git_tree.py b/tools/guess_git_tree.py
index bc63674..c9eef39 100755
--- a/tools/guess_git_tree.py
+++ b/tools/guess_git_tree.py
@@ -146,11 +146,10 @@ class Maintainers(object):
         tree_list = []
         for _file in files:
             _tree = self._get_tree(_file)
-            # No identified tree for a file means that it should go through
-            # the main repository.
-            if not _tree:
-                _tree = 'dpdk'
-            tree_list.append(_tree)
+            # Having no tree means that we accept those changes going through a
+            # subtree (e.g. release notes).
+            if _tree:
+                tree_list.append(_tree)
         tree = self.get_common_denominator(tree_list)
         if tree == '':
             tree = 'dpdk'
-- 
2.23.0

Re: [dpdk-ci] [PATCH] Revert "tools: fix tree detection for orphan files"

[Thomas Monjalon]

20/01/2020 16:31, David Marchand:
> The problem with this patch is that some files were with no git tree in
> MAINTAINERS on purpose: some files are maintained in the main repository,
> but we leave subtrees touch them like release notes or makefile/meson
> files.
> 
> So reverting it, and adding a comment to document the reason.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks

The solution is better specifying trees in MAINTAINERS
for components which must not be changed in a sub-tree.
Will merge your patches adding such info.