DPDK CI discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: ci@dpdk.org, alialnu@mellanox.com
Subject: Re: [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files
Date: Mon, 06 Jan 2020 23:28:53 +0100	[thread overview]
Message-ID: <34761032.2A8e1yFmEb@xps> (raw)
In-Reply-To: <20200106111531.26431-1-david.marchand@redhat.com>

06/01/2020 12:15, David Marchand:
> Implicitly, if a file has no official maintainer / tree, it is in the
> end maintained in the master branch.
> 
> This problem has been seen while looking at test failures reported on the
> series https://patchwork.dpdk.org/project/dpdk/list/?series=7981.
> 
> This series mixes changes in ethdev, net/tap and EAL, and thus should go
> through the main repository.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> -            if _tree:
> -                tree_list.append(_tree)
> +            # No identified tree for a file means that it should go through
> +            # the main repository.
> +            if not _tree:
> +                _tree = 'dpdk'
> +            tree_list.append(_tree)

It looks good to me.
This is the expected behaviour but it seems the case was
forgotten when writing this function.

Waiting for the review/ack from Ali before merging.
Thanks



  reply	other threads:[~2020-01-06 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 11:15 David Marchand
2020-01-06 22:28 ` Thomas Monjalon [this message]
2020-01-07 10:08   ` Ali Alnubani
2020-01-07 18:11     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34761032.2A8e1yFmEb@xps \
    --to=thomas@monjalon.net \
    --cc=alialnu@mellanox.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).