From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 550E542672; Fri, 29 Sep 2023 13:09:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F6B8402AA; Fri, 29 Sep 2023 13:09:37 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 23A9040287 for ; Fri, 29 Sep 2023 13:09:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C17E85C0175; Fri, 29 Sep 2023 07:09:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 29 Sep 2023 07:09:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1695985775; x=1696072175; bh=EHoq1hxT8+GXy2LcYv2nlexHbEHdLhNFnCO nR62aD9I=; b=t6kPWJx9mlR2JbGQ6KRWzaccvicCItfFYrMzc9sgeXSwNS+46H4 s25qbKCTx7MknPLX1Goc439EDeCBxLQjLymH8XbZ5VhFkWxq+q3cFzH4GJ4LiEX1 b3XquIHInUQZxkXJhzyVQwdCaAYgQ7N3l6keWazX1sNr5YVCKIGIf0ZYPjBt9Gck QeG+sMgO/NjLBo89TQe4VneMiR5DOtAI7E6XmehBt4TUn8PQFk3VCYL7bxvQFOqM ysLy6JDY5auEFes4zDcIorZeKzqgZ2rabfXaUmhxcjQQDxuQJC48YTpQ/3DqAWGc O+eRZ0F0bV/A41Ef7RhTT9mpr+1743a8pFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1695985775; x= 1696072175; bh=EHoq1hxT8+GXy2LcYv2nlexHbEHdLhNFnCOnR62aD9I=; b=a cdhm5bIUpuYeDw13I8pWEM865pq43snvWLrByGPX5tjGPGc7EWVUoRZP0Ky9naPW 8yO1Fx+VD87KJj0dOfJ7zRyPMhkmYrBoV3Co1naFY+jz05tTFKtlLrejYMayZyF9 bJ7maWfO7e9pt8VO7VNEqHByycJpPtIOj3pa6Xj0b8AQ/xEbR7modmPo04v6p1I8 jCdISQN7g7Oee4pAIMV3p5ovedNz5/MMOa1gj6BLEI10pIXjMCrdFRs4RTZCLN7F UByfeLaw0d0HPl0MamcwrMVv9ZL2FoLh9mBIP+bZSQX4oEKG+xWJyZTOlekrs4iW P51BZ7usvudOBF1oBuVIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrtddvgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejgeeffeefueevjefhvdfhkeevleefjefhvdeuteeguedtvdejteet keduveehudenucffohhmrghinhepphhrohhofhhpohhinhhtrdgtohhmpdguphgukhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Sep 2023 07:09:34 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Kollanukkaran , "alialnu@nvidia.com" , "aconole@redhat.com" , "ci@dpdk.org" , Pavan Nikhilesh Bhagavatula Subject: Re: [EXT] Re: [PATCH] pw_maintainers_cli: enhance tree selection Date: Fri, 29 Sep 2023 13:09:33 +0200 Message-ID: <4092421.X513TT2pbd@thomas> In-Reply-To: References: <20230929083443.9925-1-pbhagavatula@marvell.com> <4320151.8hb0ThOEGa@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org 29/09/2023 12:54, Pavan Nikhilesh Bhagavatula: > > > From: pbhagavatula@marvell.com > > > > From: Pavan Nikhilesh > > > > > > > > When longest prefix match doesnt find a suitable tree, pick the > > > > tree which has the highest modified file count instead of defauting > > > > to main tree. > > > > > > > > > > This change is need to find the correct branch when a patch has a > > specification > > > Change followed by a implementation of driver layer example: > > > > > > https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__patches.dpdk.org_project_dpdk_list_-3Fseries- > > 3D29675&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB- > > fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=WKN1erKSjH9MuEyyRs- > > R3jYC5geZeUeNipx2GQlQpQSuQQCet70Torr1oSdZNvZp&s=6XFs2Ggg5G0VFd > > YEaRexumEXM5JKc2vs5dmrRNcIUZw&e= > > > > That's expected: when a series touches more than a tree scope, > > it goes to main. > > But that's not the issue here. > > Both eventdev lib, test and drivers belong to the eventdev tree. > > So why it is not already delegated to eventdev? > > Please dig more. > > > > > > The main issue is the driver implementation touches common/cnxk which ties it to > next-net-mrvl tree which causes the conflict. > > We have few options here, > 1. Based on max number of files touched per tree (Current patch) > 2. Ignore driver/common from tree selection when there is a conflict with other tree. > 3. When there is a conflict between trees choose the common tree instead of company specific tree > Example, dpdk-next-eventdev + dpdk-next-net-mrvl = dpdk-next-eventdev I have a preference for option 2.