* Re: [dpdk-ci] [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements [not found] ` <BYAPR18MB242435E29184618ED4E2E6F0C8C40@BYAPR18MB2424.namprd18.prod.outlook.com> @ 2020-04-15 16:37 ` David Marchand 2020-04-15 17:39 ` Mattias Rönnblom 0 siblings, 1 reply; 4+ messages in thread From: David Marchand @ 2020-04-15 16:37 UTC (permalink / raw) To: Jerin Jacob Kollanukkaran, Mattias Rönnblom Cc: dev, stefan.sundkvist, Ola.Liljedahl, ci On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote: > > > -----Original Message----- > > From: Mattias Rönnblom <mattias.ronnblom@ericsson.com> > > Sent: Monday, March 9, 2020 12:21 PM > > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com> > > Cc: dev@dpdk.org; stefan.sundkvist@ericsson.com; Ola.Liljedahl@arm.com; > > Mattias Rönnblom <mattias.ronnblom@ericsson.com> > > Subject: [EXT] [PATCH 0/8] DSW performance and statistics improvements > > > > External Email > > > > ---------------------------------------------------------------------- > > Performance and statistics improvements for the distributed software > > (DSW) event device. > > > > Mattias Rönnblom (8): > > event/dsw: reduce latency in low-load situations > > event/dsw: reduce max flows to speed up load balancing > > event/dsw: extend statistics > > event/dsw: improve migration mechanism > > event/dsw: avoid migration waves in large systems > > event/dsw: remove redundant control ring poll > > event/dsw: remove unnecessary read barrier > > event/dsw: add port busy cycles xstats > > Series applied to dpdk-next-eventdev/master. Thanks. I get a compilation issue on rhel7. Too bad the CI did not help. http://patchwork.dpdk.org/project/dpdk/list/?series=8828&state=* [1583/1808] Compiling C object 'drivers/drivers@@tmp_rte_pmd_dsw_event@sta/event_dsw_dsw_event.c.o'. ../drivers/event/dsw/dsw_event.c: In function ‘dsw_port_consider_emigration’: ../drivers/event/dsw/dsw_event.c:502:27: warning: ‘candidate_qf’ may be used uninitialized in this function [-Wmaybe-uninitialized] target_qfs[*targets_len] = *candidate_qf; ^ ../drivers/event/dsw/dsw_event.c:445:25: note: ‘candidate_qf’ was declared here struct dsw_queue_flow *candidate_qf; ^ In file included from ../lib/librte_eal/x86/include/rte_atomic.h:16:0, from ../lib/librte_eal/include/generic/rte_rwlock.h:25, from ../lib/librte_eal/x86/include/rte_rwlock.h:12, from ../lib/librte_eal/include/rte_fbarray.h:40, from ../lib/librte_eal/include/rte_memory.h:25, from ../lib/librte_eventdev/rte_event_ring.h:20, from ../drivers/event/dsw/dsw_evdev.h:8, from ../drivers/event/dsw/dsw_event.c:5: ../lib/librte_eal/include/generic/rte_atomic.h:566:22: warning: ‘candidate_flow_load’ may be used uninitialized in this function [-Wmaybe-uninitialized] __sync_fetch_and_add(&v->cnt, inc); ^ ../drivers/event/dsw/dsw_event.c:448:10: note: ‘candidate_flow_load’ was declared here int16_t candidate_flow_load; ^ ../drivers/event/dsw/dsw_event.c:505:49: warning: ‘candidate_port_id’ may be used uninitialized in this function [-Wmaybe-uninitialized] rte_atomic32_add(&dsw->ports[candidate_port_id].immigration_load, ^ ../drivers/event/dsw/dsw_event.c:446:10: note: ‘candidate_port_id’ was declared here uint8_t candidate_port_id; ^ -- David Marchand ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-ci] [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements 2020-04-15 16:37 ` [dpdk-ci] [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements David Marchand @ 2020-04-15 17:39 ` Mattias Rönnblom 2020-04-15 17:45 ` Thomas Monjalon 0 siblings, 1 reply; 4+ messages in thread From: Mattias Rönnblom @ 2020-04-15 17:39 UTC (permalink / raw) To: David Marchand, Jerin Jacob Kollanukkaran Cc: dev, Stefan Sundkvist, Ola.Liljedahl, ci On 2020-04-15 18:37, David Marchand wrote: > On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran > <jerinj@marvell.com> wrote: >>> -----Original Message----- >>> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com> >>> Sent: Monday, March 9, 2020 12:21 PM >>> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com> >>> Cc: dev@dpdk.org; stefan.sundkvist@ericsson.com; Ola.Liljedahl@arm.com; >>> Mattias Rönnblom <mattias.ronnblom@ericsson.com> >>> Subject: [EXT] [PATCH 0/8] DSW performance and statistics improvements >>> >>> External Email >>> >>> ---------------------------------------------------------------------- >>> Performance and statistics improvements for the distributed software >>> (DSW) event device. >>> >>> Mattias Rönnblom (8): >>> event/dsw: reduce latency in low-load situations >>> event/dsw: reduce max flows to speed up load balancing >>> event/dsw: extend statistics >>> event/dsw: improve migration mechanism >>> event/dsw: avoid migration waves in large systems >>> event/dsw: remove redundant control ring poll >>> event/dsw: remove unnecessary read barrier >>> event/dsw: add port busy cycles xstats >> Series applied to dpdk-next-eventdev/master. Thanks. > I get a compilation issue on rhel7. > Too bad the CI did not help. > https://protect2.fireeye.com/v1/url?k=6777ccba-3ba3c0e4-67778c21-8691959ed9b7-56149d0a5dee8fea&q=1&e=d034618d-5861-42ba-adf3-fc0aafd4892a&u=http%3A%2F%2Fpatchwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D8828%26state%3D%2A > > > [1583/1808] Compiling C object > 'drivers/drivers@@tmp_rte_pmd_dsw_event@sta/event_dsw_dsw_event.c.o'. > ../drivers/event/dsw/dsw_event.c: In function ‘dsw_port_consider_emigration’: > ../drivers/event/dsw/dsw_event.c:502:27: warning: ‘candidate_qf’ may > be used uninitialized in this function [-Wmaybe-uninitialized] > target_qfs[*targets_len] = *candidate_qf; > ^ > ../drivers/event/dsw/dsw_event.c:445:25: note: ‘candidate_qf’ was declared here > struct dsw_queue_flow *candidate_qf; > ^ > In file included from ../lib/librte_eal/x86/include/rte_atomic.h:16:0, > from ../lib/librte_eal/include/generic/rte_rwlock.h:25, > from ../lib/librte_eal/x86/include/rte_rwlock.h:12, > from ../lib/librte_eal/include/rte_fbarray.h:40, > from ../lib/librte_eal/include/rte_memory.h:25, > from ../lib/librte_eventdev/rte_event_ring.h:20, > from ../drivers/event/dsw/dsw_evdev.h:8, > from ../drivers/event/dsw/dsw_event.c:5: > ../lib/librte_eal/include/generic/rte_atomic.h:566:22: warning: > ‘candidate_flow_load’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > __sync_fetch_and_add(&v->cnt, inc); > ^ > ../drivers/event/dsw/dsw_event.c:448:10: note: ‘candidate_flow_load’ > was declared here > int16_t candidate_flow_load; > ^ > ../drivers/event/dsw/dsw_event.c:505:49: warning: ‘candidate_port_id’ > may be used uninitialized in this function [-Wmaybe-uninitialized] > rte_atomic32_add(&dsw->ports[candidate_port_id].immigration_load, > ^ > ../drivers/event/dsw/dsw_event.c:446:10: note: ‘candidate_port_id’ was > declared here > uint8_t candidate_port_id; > ^ > Looks like a false positive. What GCC version is this? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-ci] [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements 2020-04-15 17:39 ` Mattias Rönnblom @ 2020-04-15 17:45 ` Thomas Monjalon 2020-04-15 18:09 ` Mattias Rönnblom 0 siblings, 1 reply; 4+ messages in thread From: Thomas Monjalon @ 2020-04-15 17:45 UTC (permalink / raw) To: Mattias Rönnblom Cc: David Marchand, Jerin Jacob Kollanukkaran, ci, dev, Stefan Sundkvist, Ola.Liljedahl 15/04/2020 19:39, Mattias Rönnblom: > On 2020-04-15 18:37, David Marchand wrote: > > On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran > > <jerinj@marvell.com> wrote: > >> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com> > >>> Performance and statistics improvements for the distributed software > >>> (DSW) event device. > >>> > >>> Mattias Rönnblom (8): > >>> event/dsw: reduce latency in low-load situations > >>> event/dsw: reduce max flows to speed up load balancing > >>> event/dsw: extend statistics > >>> event/dsw: improve migration mechanism > >>> event/dsw: avoid migration waves in large systems > >>> event/dsw: remove redundant control ring poll > >>> event/dsw: remove unnecessary read barrier > >>> event/dsw: add port busy cycles xstats > >> Series applied to dpdk-next-eventdev/master. Thanks. > > > > I get a compilation issue on rhel7. > > Too bad the CI did not help. > > https://protect2.fireeye.com/v1/url?k=6777ccba-3ba3c0e4-67778c21-8691959ed9b7-56149d0a5dee8fea&q=1&e=d034618d-5861-42ba-adf3-fc0aafd4892a&u=http%3A%2F%2Fpatchwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D8828%26state%3D%2A > > > > > > [1583/1808] Compiling C object > > 'drivers/drivers@@tmp_rte_pmd_dsw_event@sta/event_dsw_dsw_event.c.o'. > > ../drivers/event/dsw/dsw_event.c: In function ‘dsw_port_consider_emigration’: > > ../drivers/event/dsw/dsw_event.c:502:27: warning: ‘candidate_qf’ may > > be used uninitialized in this function [-Wmaybe-uninitialized] > > target_qfs[*targets_len] = *candidate_qf; > > ^ > > ../drivers/event/dsw/dsw_event.c:445:25: note: ‘candidate_qf’ was declared here > > struct dsw_queue_flow *candidate_qf; > > ^ > > In file included from ../lib/librte_eal/x86/include/rte_atomic.h:16:0, > > from ../lib/librte_eal/include/generic/rte_rwlock.h:25, > > from ../lib/librte_eal/x86/include/rte_rwlock.h:12, > > from ../lib/librte_eal/include/rte_fbarray.h:40, > > from ../lib/librte_eal/include/rte_memory.h:25, > > from ../lib/librte_eventdev/rte_event_ring.h:20, > > from ../drivers/event/dsw/dsw_evdev.h:8, > > from ../drivers/event/dsw/dsw_event.c:5: > > ../lib/librte_eal/include/generic/rte_atomic.h:566:22: warning: > > ‘candidate_flow_load’ may be used uninitialized in this function > > [-Wmaybe-uninitialized] > > __sync_fetch_and_add(&v->cnt, inc); > > ^ > > ../drivers/event/dsw/dsw_event.c:448:10: note: ‘candidate_flow_load’ > > was declared here > > int16_t candidate_flow_load; > > ^ > > ../drivers/event/dsw/dsw_event.c:505:49: warning: ‘candidate_port_id’ > > may be used uninitialized in this function [-Wmaybe-uninitialized] > > rte_atomic32_add(&dsw->ports[candidate_port_id].immigration_load, > > ^ > > ../drivers/event/dsw/dsw_event.c:446:10: note: ‘candidate_port_id’ was > > declared here > > uint8_t candidate_port_id; > > ^ > > > > Looks like a false positive. What GCC version is this? This is with RHEL 7. Please do you have such distro to test and fix the false positive? A quick fix would be very welcome. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-ci] [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements 2020-04-15 17:45 ` Thomas Monjalon @ 2020-04-15 18:09 ` Mattias Rönnblom 0 siblings, 0 replies; 4+ messages in thread From: Mattias Rönnblom @ 2020-04-15 18:09 UTC (permalink / raw) To: Thomas Monjalon Cc: David Marchand, Jerin Jacob Kollanukkaran, ci, dev, Stefan Sundkvist, Ola.Liljedahl On 2020-04-15 19:45, Thomas Monjalon wrote: > 15/04/2020 19:39, Mattias Rönnblom: >> On 2020-04-15 18:37, David Marchand wrote: >>> On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran >>> <jerinj@marvell.com> wrote: >>>> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com> >>>>> Performance and statistics improvements for the distributed software >>>>> (DSW) event device. >>>>> >>>>> Mattias Rönnblom (8): >>>>> event/dsw: reduce latency in low-load situations >>>>> event/dsw: reduce max flows to speed up load balancing >>>>> event/dsw: extend statistics >>>>> event/dsw: improve migration mechanism >>>>> event/dsw: avoid migration waves in large systems >>>>> event/dsw: remove redundant control ring poll >>>>> event/dsw: remove unnecessary read barrier >>>>> event/dsw: add port busy cycles xstats >>>> Series applied to dpdk-next-eventdev/master. Thanks. >>> I get a compilation issue on rhel7. >>> Too bad the CI did not help. >>> https://protect2.fireeye.com/v1/url?k=6777ccba-3ba3c0e4-67778c21-8691959ed9b7-56149d0a5dee8fea&q=1&e=d034618d-5861-42ba-adf3-fc0aafd4892a&u=http%3A%2F%2Fpatchwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D8828%26state%3D%2A >>> >>> >>> [1583/1808] Compiling C object >>> 'drivers/drivers@@tmp_rte_pmd_dsw_event@sta/event_dsw_dsw_event.c.o'. >>> ../drivers/event/dsw/dsw_event.c: In function ‘dsw_port_consider_emigration’: >>> ../drivers/event/dsw/dsw_event.c:502:27: warning: ‘candidate_qf’ may >>> be used uninitialized in this function [-Wmaybe-uninitialized] >>> target_qfs[*targets_len] = *candidate_qf; >>> ^ >>> ../drivers/event/dsw/dsw_event.c:445:25: note: ‘candidate_qf’ was declared here >>> struct dsw_queue_flow *candidate_qf; >>> ^ >>> In file included from ../lib/librte_eal/x86/include/rte_atomic.h:16:0, >>> from ../lib/librte_eal/include/generic/rte_rwlock.h:25, >>> from ../lib/librte_eal/x86/include/rte_rwlock.h:12, >>> from ../lib/librte_eal/include/rte_fbarray.h:40, >>> from ../lib/librte_eal/include/rte_memory.h:25, >>> from ../lib/librte_eventdev/rte_event_ring.h:20, >>> from ../drivers/event/dsw/dsw_evdev.h:8, >>> from ../drivers/event/dsw/dsw_event.c:5: >>> ../lib/librte_eal/include/generic/rte_atomic.h:566:22: warning: >>> ‘candidate_flow_load’ may be used uninitialized in this function >>> [-Wmaybe-uninitialized] >>> __sync_fetch_and_add(&v->cnt, inc); >>> ^ >>> ../drivers/event/dsw/dsw_event.c:448:10: note: ‘candidate_flow_load’ >>> was declared here >>> int16_t candidate_flow_load; >>> ^ >>> ../drivers/event/dsw/dsw_event.c:505:49: warning: ‘candidate_port_id’ >>> may be used uninitialized in this function [-Wmaybe-uninitialized] >>> rte_atomic32_add(&dsw->ports[candidate_port_id].immigration_load, >>> ^ >>> ../drivers/event/dsw/dsw_event.c:446:10: note: ‘candidate_port_id’ was >>> declared here >>> uint8_t candidate_port_id; >>> ^ >>> >> Looks like a false positive. What GCC version is this? > This is with RHEL 7. > Please do you have such distro to test and fix the false positive? > A quick fix would be very welcome. > > Most distributions support several compilers. I'm assuming it's the default 4.8 compiler, and I unfortunately don't have a system with that compiler. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-15 18:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200309065106.23800-1-mattias.ronnblom@ericsson.com>
[not found] ` <BYAPR18MB242435E29184618ED4E2E6F0C8C40@BYAPR18MB2424.namprd18.prod.outlook.com>
2020-04-15 16:37 ` [dpdk-ci] [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements David Marchand
2020-04-15 17:39 ` Mattias Rönnblom
2020-04-15 17:45 ` Thomas Monjalon
2020-04-15 18:09 ` Mattias Rönnblom
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).