From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F170D43CFF; Wed, 20 Mar 2024 11:08:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5D27410FB; Wed, 20 Mar 2024 11:08:56 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2081.outbound.protection.outlook.com [40.107.94.81]) by mails.dpdk.org (Postfix) with ESMTP id 5BFCD40298; Wed, 20 Mar 2024 11:08:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNg/72Ch0jhKC5el80wyZ4jR8blpFYCInSfwR/QcZPJ9xik79sC0LUPrUkDP/xOjXvwyQzQdl3VyDTMdHl0R0d6Mpzf0X+hoeUU7AaibrxsiQ941/PbcNB1NVUDtxScsTozv5YGFzOM1q2ropmdhe+nXqHwx771jNi2w2UMzBDLB2Npsj7C+Taa9TFZTkbu1G+7rFJU84j6LDQkSwJOgvOuLoj+9wuAdHU5phf7BWNtFIDaJuAJ0NXrtkihnRwkl/qyXfZ18yJmdFKXIBduK15Q/QfJ1/vVv3VI8ghj8GE86xgFOqiOM8gHrlmQv1fY7N1WHSNuoETrEsIejaI7Zzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XnFAGao52W2BXJLu3QHSjSq4hKjUKgJoFQG152KzMsE=; b=EAyJAGNdylZwTmDROsOu5nAnearCuCx3Um2GFU6jhQG3ocJ26P5ipXANLRxKfBPvftzoNpr6/xxdbcDyAiKGU/4Cip0HDXaPucRVzeTyfppnjaw2pqw9Mpb45TqsveTOd8d9uUyyN6fXUBEE9qkNhKqgi+6NA1IGwtG2T0fO8X39A96/qzZyMqJXn6x1YmJVCeYrgXmclgQqMOUmrNk6zwVEeFSANEmNvaO8BbPnoCMJmoUhMhn2om9pT/XuGxW7CpJpWn2LZeA68/O1T/3aqUGVRvNSPiP8a/I5U8DwmN8fu4eym9JRteuIvNojurRQVv724TBvQN9x9c9J16ri0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XnFAGao52W2BXJLu3QHSjSq4hKjUKgJoFQG152KzMsE=; b=ImawxTjQ6xg9y1V8Iebr/KXBrjfhMsnPPUmEw9ELBQ3FSHaAwt+TvIUv7MIAp3nczdv+lQFY3dmdewEJs8LXKATxFBINH19iu2urpUJF4ZC4Ihcizj8jL6KP42axuxlznjmY5aiqKQhtBdo4k+wM3yjair1kSGo1WbMQc4ja6/Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6763.namprd12.prod.outlook.com (2603:10b6:510:1ad::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Wed, 20 Mar 2024 10:08:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7386.031; Wed, 20 Mar 2024 10:08:51 +0000 Message-ID: <46653254-c995-4de0-82fa-2531ed4cfaa0@amd.com> Date: Wed, 20 Mar 2024 10:08:46 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: fix auto completion for indirect list action Content-Language: en-US To: Gregory Etelson , Shani Peretz , "dev@dpdk.org" Cc: Maayan Kashani , Ori Kam , Aman Singh , Yuying Zhang , "ci@dpdk.org" , Honnappa Nagarahalli , Patrick Robb References: <20240318092109.87656-1-shperetz@nvidia.com> <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0029.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::17) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6763:EE_ X-MS-Office365-Filtering-Correlation-Id: 32e19a8a-ae8c-433d-f3fa-08dc48c5bdeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ixvkO5RMkzcpPlZgh6SXcqHMWBCvHMwehkDwJUSS4hcJNZHYOX6D8PitprbeWOBxew3pMcesm87llmQ7U4BSGFL9B4bSN8G12Q2OUBQgrJnzmgVvVsfNOck2/Y5PY4Kz4kawF4mHsEd/WSS2VtITKXTATuqmGSrSnH1JH3mPjoOZQb0p1UehyDfOPVyvI8bJuIPAFtnxY1Zw/0v4VzCpFcdyd4HR2EPYG40ut6uXMfFcO190vCFpbH8U75JMxaKZUrRaEDtOAbyWCIehCO7759v36hs20lwjEOm2cYrlI0lkWsL/zhhiqK0cJ8yKFwfBZrMmF+aq0oycVHI/K/H5ffql1kcLSiap0ac81qB4nGfUstAYxbjhXKvBxiuHzja+510qqVFZ0OpSrGXazluRt9JW+T12gU5GbAy/IJEMl3sanFoV2BpOjlQfGRg4vb3Siz6SZugLojxz80CYX2AiY+ZmNOFzDaC8k+UCHDB1QxyVR7vMreelStGvS+LdCNI9LmdwGg6M/rrnem4oD1FQMp7OsyQIAk4zBvYk2mUB+pys5QE2xEtnIWN6FZSrkjt7XsYMGJ0urzCKXj9Lxg+6S1mpwUqi/y3qQUpOs7Dcow= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(7416005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0I5bERZeDhYRXBtYThwNk04eE1wNHBMK1ZFMmU0Y3lqcmhYUGpla1NuNWM3?= =?utf-8?B?S2ovL1E3bldaME9XKzY2bHhBdUxxemZ4d0p5UHBqSXRWaUV6K2t5ekl1THpR?= =?utf-8?B?OG1zTlF1eXRxUFVyZHNCMWJLN01DMjZuTlBpWTZCTndvdndRcWxUWDM3QWpm?= =?utf-8?B?eVhuVEdhUFdodTcwb3pEajhpRWdEaDN1Tjc1amtDRHlqYkI1QXZwblRNZE54?= =?utf-8?B?WWV5dXNCVk9TMDl2bkZ5UFk0M3BEekZmS2pmZCtsUjNGaEtFNndiTFdZK3Fv?= =?utf-8?B?aFFaVTBZQStDZ2dmVjZVSlZsckFGZFZ1eklVeDhyR1hHTldpakQzTUo2bTJa?= =?utf-8?B?SVUzS01haXVIQVk0c2psMzFkUjZZeE1yL0tZTUNYM0o3Q2RYc2FtOWc5V25z?= =?utf-8?B?U1NjVkxrdnZVMm4rdjhVQlFlUkNTNEVCK3BtRTNReXVodnFnQUJPWnUzdTFB?= =?utf-8?B?VFFrRDdhNUlSSzN4Wkp1anpveCs1enVyMFRkWk53VlF1V2w5UmhNVDV6TjI5?= =?utf-8?B?S0Q2V2dBbk1IN3NKQkc1ZnpTQVlHaERtdnpQUGx4NE1HOTVVMlJ4cjZ2ZmdR?= =?utf-8?B?MUx3MUg5QUdOMlFEa0Fua2Y5dzZKSDRsQmNxSExNRXFNNGs0YUdNaDZtU2tM?= =?utf-8?B?bVNnU3VreGFPbE5sNm4rUWI3d2V4RWRjeDJTMUhVUFJpNGZ0YmFIelZvYmdI?= =?utf-8?B?c0ZRZ3FQT080UGV4ME1jdjFWTys3eVJPc2hOTUZ2VnlEQUhqYXVZOFpSQWdW?= =?utf-8?B?bjl5bzM3WUp3RXowTTdYNHhCcURVNnlDK2FrcElheHJZckY4WldKNGZ2bXZP?= =?utf-8?B?SHFiUXFlWFZDSHArMHY4WFMveFlsMWVmdkxScFlLcVhkQmJPamRLdEFFVDBo?= =?utf-8?B?b3JwRk1kYW5HWTc3UlA3WVVSNGxYVlZOdFkvTXY4SHgwcVVvRWk3dEQwZkVw?= =?utf-8?B?UERlSENJTHVjT1NhYTVGbXVob3d1S21FcGV0UlQ0ZDM2ZnREOTM2L09sdGo5?= =?utf-8?B?VVY2YUNSQ29kRkU0eTdyMzlQcGhsaW9kLzhBSzFHSjlGQmR4Sis3bmx4V0xP?= =?utf-8?B?dG9yWDFjVUhYTG1aaFlLZkJxeEJiSkFmT2FnOTRXTElIZWtUYUorSkx6bWtP?= =?utf-8?B?UzNVeUtYMjB2MC9abVBneXl3UzRaaThoeGRCZ2pFMk5yS1RLWFovQ2s4d0Iy?= =?utf-8?B?UmcvbDB1cmdJenREU0RmL0dnMEl5NWlTaFFORkU2ZUErNzNkK3YyakJxQnFk?= =?utf-8?B?KzlGVmxBSnJXQkZFWmt0Ni9OcHJNaWxObGF2NEFKaEpReW93QUJYM1JzNjBD?= =?utf-8?B?LzRpS0dNK1I4bGJuUGdmSitKY1dqYVluUFJMUWhKaFVSazdYbnB3SnRRWDhK?= =?utf-8?B?bWZZK1R1VE45VlJYYktQVXpTVVJZcVFxZEpFWGZKamgxWDVrenlkNTBKMlJs?= =?utf-8?B?VGtFUXNENFZ1SUJ0U0lRZkhBRENYcUlrMzFzUmx5Y0ovakVvT0dzZGNNWHRW?= =?utf-8?B?WGhuNEd4aFV5NlRvM20wejhsZ25jUXdVTFRwYytxbUtWZVkvanJaN293Nm9X?= =?utf-8?B?RU5RM0V1RkdLMCthS0xQQWVneWpJMmxmcWpLa2hUeGRtOE9JdDV2S01ONWts?= =?utf-8?B?S2NudmtscE9HNlgvbnhVcUdWNEFJTWxGZThiU21vY09Sbng4bFd1WHhWS0pE?= =?utf-8?B?QVAyUjNxZUZobkpkYldKS3dQcDBNUk9ld1BiVzJjV1ZBWTd6NXRjNHJKMk94?= =?utf-8?B?NzBoR2VXMXFLUFZRcUQwS0lab0ZZS3RNN1JZeTUxTWJMVm4yNjZGNkJzaGdW?= =?utf-8?B?TE04aHpQcWcvNXYwMldtd25VZFVmVlFRU1Jjbkc0V3Q3ZFlnOXZoRXN1bis0?= =?utf-8?B?TktjU3dia1Q1MmQvNHJEVjBMUks1bEpyN1NESVAzallmWm94Q0VhVmNmMGNT?= =?utf-8?B?dWVKMWkxcEtGYjF0dTZ3WmRMTG9sclM3ci9TTkhhQUZpczBPMlhQczUzbGs2?= =?utf-8?B?OUpkdGh6Y3BUL0VKWWF5bmM2d01tSHVIOHZnVkg1amFuVmtDM3laK3QrV3d5?= =?utf-8?B?b3o1L2RXRStzZ2doUm4zTFEzT25UV3RoWC9MdzFaRzQvc3ROL2k4RG5lcHZ4?= =?utf-8?Q?yiedhfQVeVZM6SD0SpPpHJrZt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32e19a8a-ae8c-433d-f3fa-08dc48c5bdeb X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 10:08:51.9064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sfsje34Q4qoP8kRxIGFgSr2hVLcTT7NbO8lSgvk215gGTL/g+17hIezAbwNeJBi9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6763 X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On 3/20/2024 6:06 AM, Gregory Etelson wrote: > Hello Ferruh, > >>BUT overall how can we catch issues like this in the feature, we don't >>have a good way to test testpmd flow commands. >>@Ori, @Gregory, do you have any idea? >>cc'ed CI mail list too. > > We have a tool for unit tests based on the testpmd. > The tool details are here:  > https://drive.google.com/drive/folders/1cHrPwx4fUJ6ibUCtHd4kNKsrmmvQvvOj?usp=drive_link . > There's also a short description here: > https://inbox.dpdk.org/ci/2a287ee7-cda4-f2ab-a4e6-a47021f8573f@nvidia.com/ > > Consider an option when a code patch is accompanied with a short test > script that validates that patch functionality. > DPDK CI can run the script to verify that the patch functions correctly. > > Thanks Gregory, I missed this proposal, we need something to verify flow APIs, so +1 to the effort. What is the status of incorporating this feature into dts? But I guess it won't catch this issue, as it uses full flow commands. This issue is related to the testpmd command parsing code. I wonder if we can find a way to verify testpmd parsing code?