DPDK CI discussions
 help / color / mirror / Atom feed
* Re: [PATCH 2/2] app/testpmd: add testpmd based sleeping
       [not found]   ` <98399365-a3ab-9ade-4102-22e3582e2358@amd.com>
@ 2023-03-17 11:09     ` Anthony Harivel
  2023-03-17 16:22       ` Stephen Hemminger
  2023-03-21 11:45       ` Ferruh Yigit
  0 siblings, 2 replies; 3+ messages in thread
From: Anthony Harivel @ 2023-03-17 11:09 UTC (permalink / raw)
  To: Ferruh Yigit, Aman Singh, Yuying Zhang
  Cc: dev, rjarry, david.marchand, ktraynor, ci, aconole

Ferruh Yigit, Mar 16, 2023 at 18:05:
> Hi Anthony,
>
> What is the motivation here?

Hi Ferruh,

AFAIK testpmd is the reference tool used for CI and tests whether it is
for functional or performance tests and I think it would be in
everyone's interest to consume less CPU during them. Moreover, all
patches coming to the ML are going through validation tests and this
could reduce the maintenance cost of the project.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] app/testpmd: add testpmd based sleeping
  2023-03-17 11:09     ` [PATCH 2/2] app/testpmd: add testpmd based sleeping Anthony Harivel
@ 2023-03-17 16:22       ` Stephen Hemminger
  2023-03-21 11:45       ` Ferruh Yigit
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2023-03-17 16:22 UTC (permalink / raw)
  To: Anthony Harivel
  Cc: Ferruh Yigit, Aman Singh, Yuying Zhang, dev, rjarry,
	david.marchand, ktraynor, ci, aconole

On Fri, 17 Mar 2023 12:09:04 +0100
"Anthony Harivel" <aharivel@redhat.com> wrote:

> Ferruh Yigit, Mar 16, 2023 at 18:05:
> > Hi Anthony,
> >
> > What is the motivation here?  
> 
> Hi Ferruh,
> 
> AFAIK testpmd is the reference tool used for CI and tests whether it is
> for functional or performance tests and I think it would be in
> everyone's interest to consume less CPU during them. Moreover, all
> patches coming to the ML are going through validation tests and this
> could reduce the maintenance cost of the project.

But it introduces another variable, and the performance would vary based on
sleeping and HW interaction. I think testpmd should just run with 100% CPU,
and leave the heuristics stuff to some of the example applications.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] app/testpmd: add testpmd based sleeping
  2023-03-17 11:09     ` [PATCH 2/2] app/testpmd: add testpmd based sleeping Anthony Harivel
  2023-03-17 16:22       ` Stephen Hemminger
@ 2023-03-21 11:45       ` Ferruh Yigit
  1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2023-03-21 11:45 UTC (permalink / raw)
  To: Anthony Harivel, Aman Singh, Yuying Zhang, Hunt, David
  Cc: dev, rjarry, david.marchand, ktraynor, ci, aconole, Robin Jarry

On 3/17/2023 11:09 AM, Anthony Harivel wrote:
> Ferruh Yigit, Mar 16, 2023 at 18:05:
>> Hi Anthony,
>>
>> What is the motivation here?
> 
> Hi Ferruh,
> 
> AFAIK testpmd is the reference tool used for CI and tests whether it is
> for functional or performance tests and I think it would be in
> everyone's interest to consume less CPU during them. Moreover, all
> patches coming to the ML are going through validation tests and this
> could reduce the maintenance cost of the project.
> 

I don't think testpmd CPU usage is a real concern, it is only used by
limited number of people and only for a limited duration.
And optimizations like this may jeopardize its main task.


On the other hand, CPU/power consumption of a DPDK application in
production is a concern, and there may be many parties interested in to
reduce watt/core with a reasonable performance impact.

There is already a 'power' library for this purpose, to enable power
optimizations for all DPDK applications, instead of just implementing
them on a specific application (like testpmd).

In my experience heuristics approaches (as done in your patch) depends
on workload, while it helps for some usecases it may hurt in others.
Still there may be customers willing to test a specific one for a
specific workload.

What do you think to have these heuristics approaches implemented in the
power library, and add a new power sample application that selects one
of existing algorithm as a kind of plugin?
It can start with single algorithm, that is what you used in this patch.
But overall how to add them into power library needs to be designed.

cc'ed @Dave as power library/sample maintainer.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-21 11:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230316151438.186241-1-aharivel@redhat.com>
     [not found] ` <20230316151438.186241-2-aharivel@redhat.com>
     [not found]   ` <98399365-a3ab-9ade-4102-22e3582e2358@amd.com>
2023-03-17 11:09     ` [PATCH 2/2] app/testpmd: add testpmd based sleeping Anthony Harivel
2023-03-17 16:22       ` Stephen Hemminger
2023-03-21 11:45       ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).