From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 050C5427FA for ; Tue, 21 Mar 2023 12:46:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F37A74282D; Tue, 21 Mar 2023 12:46:03 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id EB2C7410DF; Tue, 21 Mar 2023 12:46:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DVr7OBMQj05UaTU8Sczrtp8iULh3/eEfTkSZ54rSLDELoin2OF3QTmsegjWafA7rExxxExFqtMK8zZqJ1EZ00gKfqV8tQtU6bkUDsK/BI82pFJe6EBhk4DXm/MvC0YEX9lfsdmz3BwFZNRJCpwEHciaNXYB5mOoz6nFwOxdtk7f/gS2OoiCDK4NJY95awwmbMXTF139rYZUFObe73Lq+DkQnTqY2iYMvilxr43GUr59TPCZ8C9i9Y+7CboYDPLKDoM6SemWn2GFpckZIWtAWyTWNO25Cgb0iHijCu5G4zd1PohQkRgW2/jWZfvdsR/A/H5k/r/mfvR92gVN9rV1Nmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pgayf8dprsFDDlst2X3464ADX9GTK2NITp9/EnR1qrQ=; b=oHBxM2IDlJO/59ist9nEV8h7NYP1ZD71JXr7Wy0W73O8rSFvtZBYgSgdj2v/JQdh+xulozMHADNbzWVHz06COo69H0P/MirL6pZZ8sKjRTjVePjCWBIEkwskNRBGgjxWRAOgyAvoleMDKqmqYAf9gb7KK6AQ7I4W2EbGj3hnFEE3nBDcHv16rXJgVmSj1iBYbqqoQesRoxb1FTD6cbODgWa1WakMaqMCkisnwf/fLJaScYod/gnxvQ8jqa1PvPRL3daMW8Qn4doaMZXHV7oRoyQpob20FgghwKMmLSbu66pp8QImhb1A7WTkGMgoxy9ZafLQV5HnVsXKxE4aYwrXOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pgayf8dprsFDDlst2X3464ADX9GTK2NITp9/EnR1qrQ=; b=apTk65RSCCHkwSv0zV0hMo9GAAc47rPebi7QmVXd8kxEB+g69F8M8la/RSGWeoF7iZSqcb8JGrXikswQ7JF4Ld4IrHTSFtIsvIewq7wZvxMF9sg2N0lc/R5nYdoFhFg8EwqKuhm6tHh8qx5mcwzjxfrw9F+sSLqMWIrYAhVXCU8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB5883.namprd12.prod.outlook.com (2603:10b6:208:37b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 11:45:59 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 11:45:59 +0000 Message-ID: <46ee2b41-bbbc-3abf-4733-3a692639a9e8@amd.com> Date: Tue, 21 Mar 2023 11:45:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: Anthony Harivel , Aman Singh , Yuying Zhang , "Hunt, David" Cc: dev@dpdk.org, rjarry@redhat.com, david.marchand@redhat.com, ktraynor@redhat.com, ci@dpdk.org, aconole@redhat.com, Robin Jarry References: <20230316151438.186241-1-aharivel@redhat.com> <20230316151438.186241-2-aharivel@redhat.com> <98399365-a3ab-9ade-4102-22e3582e2358@amd.com> From: Ferruh Yigit Subject: Re: [PATCH 2/2] app/testpmd: add testpmd based sleeping In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0083.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB5883:EE_ X-MS-Office365-Filtering-Correlation-Id: 7aa34be0-2abf-4f52-51ae-08db2a01d683 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rs660nPaIY1gOwF6fpX0PValwi9dGHxdPaQT9WGfgU0eYskn2iylf5WHywJJIks/w78An7jLkM5MU4QGNo7KPApFRSyM2E5HyMA3QrQ2ZycgoblQIpPlOxKS/z+6y4iFmwOt33A6fykdxd7VmuiGGaWUUNb2+7lHaVyweHyneceVTKxu8fjxJYAtTgS/d8MHLHpV6vdhOpLaw+1dxTei4GmDLfnwDPOC2xgQp/KqAnUQFW3eUa2IhvpJ4jjNkpl91J1Rhseac7HMMo8mWnEr8ca1M0TTf2X5Fv26cbz98mlHGi7bo7bwb67k8Oh4oXVUKGm9iIM/K2SzVQ528/Zfg/lNj6itUODmlaRYL+0XFbnGZEzaQUrpQmD5eYEOj8zRi1JpERVz3a+6sViPMeHRQf+bKdNdXeXKnBvAiHdMRntZQ9+p77Soih0DjOck2RZryNMsdx5jPIXDMKFxrF0XuyOEdZTAMLZrCB+GIYHp/WTog+gzlUFpJmjTSgkQWnChKbU3a7igiZpjSgETlGPehJNugg1nwTbXaII4h9r+Owjdb1Ue8Wp7FqZWEsTAWNUiwZQiFboL/E33LKJV72+nCSImo4gbgVaO1PdjIPA+coZwtbuxzxsygPioHhvMYJym0BZ3GHxsh8sR06WrNOfq90046WxAjF7fZ8TjFnyKeUkfK/++NSK7Ob0ZxkfjlFpDSZViNhFMp412Fk34PISyN6Ln3EixcZGyWzNX/zpSrkM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(451199018)(38100700002)(31696002)(110136005)(7416002)(8676002)(316002)(44832011)(66946007)(66476007)(36756003)(66556008)(5660300002)(8936002)(4326008)(41300700001)(2906002)(478600001)(86362001)(83380400001)(6666004)(2616005)(31686004)(186003)(6506007)(26005)(53546011)(6512007)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlZUN0FQbldRcFRvT2pHWDhRaWJwaGJNZjZxKzNWcWNldHJHVDZKSlNNNi9R?= =?utf-8?B?VW1aeWg2SEpndnIwOFIxcHZtRlBpNXNVNFVFSzByNlVOOHlDdWk3bCsxbERo?= =?utf-8?B?cTM3Z3MrTHp5MEhTQlpkN1I0RHp4RlZDVTVDU29KamZ1SWJ6TlhWQUFxWUVh?= =?utf-8?B?UVNlSDdwaXFTaS9DVkxNd0J1QWMvRFI4dHVXNDQrZ0szeWJZeTdUeGcxMDZm?= =?utf-8?B?TDB4NUMvcTYwK2hIakJhZ3JSb3ZqQnZTdUEvNDIrd2hMTU1TSVlyUlhoVllv?= =?utf-8?B?Y0xqWmNmT2FFK25GS3NVRHJuWEFiNDVnK1QvdDFtT2s2OVZJRHB4aGY2NWov?= =?utf-8?B?RUM2Y0MrMWtlM0pCL1c4NzhtMm85NHJGN2t4TXNJWW9abjB6NUN5YzIzOXl3?= =?utf-8?B?L0ZlbzRma3lHdXdZRmF4L2szcDNlVVdCb1E5NW51M3hMdkVEWXArNUFHZkVw?= =?utf-8?B?czQ4M29BREtEUHpKWUF1Z0lNWHU3WkhFd3lEUSt5S1d5SFc2NEFkZ09NZHpo?= =?utf-8?B?TDZuNndQejVDc0hXWEQ1RFBjTDZlMTBoemE1NURSRXZtalYydlBuT1pvY2xj?= =?utf-8?B?MURPdTFxcTlKYTNVWFE4N1pjNVJVMEJRZkRxZGd1MWhWQ0pRNUdPQlVIbkhq?= =?utf-8?B?eEQyWWRYaUNYalVLQmwwTVArYlNRaEI2dFVEdUxYSVJ3NWJnK0tRa1NidytH?= =?utf-8?B?R2xnWkZGKzFEb3krMWJJbHRpQ2FIaG93UTFYWWZTZGdzcExIc2VTR3FjenVI?= =?utf-8?B?NDBpNVRkUnRmcWlnUk04bUZNNDJ5MXRVZlo4bWlwSFc1aUtrV1ZML2dJbmQ3?= =?utf-8?B?UDN1Nm9hSDNTQnd5bUQzZm9aSXZjZ2U0VFhZR1l2VTA0Q3ZWcldUeFFtcjNw?= =?utf-8?B?K01CRzYrbU5tUnhnaWo4WExOT0RSWDFVeXR4c2h2bVlNYXRmUG4vcXRkTEho?= =?utf-8?B?Qy8xZlBjTjkvUnRORGF5ZHhwQzN3QTltMWxGSUpmUXcxd2pKQndQTjFtaFFu?= =?utf-8?B?NUUzM0RKVTBNajVRdHMxb0VOeTdLc3o0QVdyZDZMelNzUXNiWXY5SHJmTXpv?= =?utf-8?B?MVRoZE82NW91N1N4Q3VGTzVHZUZlUnpmZlJuTGhPa1Y0eE9RSGZUODhzVFRC?= =?utf-8?B?TnJTb3Z5M3BWbytTUlZDSmVyc2tySzE5RlhrSUhFeU5LbHlPb1UzQ3BMYmpp?= =?utf-8?B?UmEwZnNhTkJPVWVPc2tyU0hoODlZVWw2MUFVRGdycXZ1Z3R3NlloNmhEMnJu?= =?utf-8?B?RGwrcmZYUmJuUVFHVHB0bXRPN3hNSExpRSt6YWxDK2U1a2RXbUlmYzVpVlRj?= =?utf-8?B?VEtLcnRmQTdKRVhiWVdQNzlXTFVqb2t2am9yL3d0b1BZUWtIZmhkSk9sTFlv?= =?utf-8?B?L0pWbTlGbVFDaHZjZW0wQTVaMmRhUHllMEEzTVZxMVRXZ1BrMXI0dDNvdWVS?= =?utf-8?B?akdITmFxMXpBQzBwVXRnZVA1S0o1VzBwdGN4NjRvQUg1dW9CTWNwc21VaEwv?= =?utf-8?B?N3BsV1VUajNFb05kS0Y3Y1dFZUNjLzM0bzZ3dno2clFYQlJ1MzFzMnBJaUNp?= =?utf-8?B?M2l0cG5lQ1NWWnRkbFU4SzVuUVBPUG95ekYrUXlTMG9WRGJQcng1MmRycGZw?= =?utf-8?B?anlhVExUbjVNMzhqYW9oNHJtTEF1a3dJOFNyN2JEbEJVVGt2M0hJTlE1VGdv?= =?utf-8?B?Y2swMlRhNVE3Wko1MWlUanROT216VDB3cWoybUI2eC9wN2IrNTdwZUw2eCt1?= =?utf-8?B?K3pJcG1qMHovblYvMjFoR2pBWlhXRG8ycGh1SjJHL2prdEdSV1VMWVByYWph?= =?utf-8?B?RWVsM0s1dFFsd2RGRE9SVWQxa29UdGxIN0xMb0FlOE9JYitlK2JBNjJRdWRq?= =?utf-8?B?SkNhbklVbEhrUmZQTGtvbTJwQWdINGlkQ0d5bzcxVEh2QUpTL01DaDV6UlZw?= =?utf-8?B?OHBZT0NoUHY4NUFrSnVwSUpWV2UzSlFEMURyYXcwRFM2b2tIY3QxWDlzalo3?= =?utf-8?B?ZHdhYm00WmtMOVhXNEw0b0VmQzVVM2lLMXBjNjhycURITXNvZVNWQU5UK2FO?= =?utf-8?B?V2tVRmpBQnNmejduYUlxYjdEWnpuTFd3YUV1M1R1RDRxL1Bra285VGtCZXU5?= =?utf-8?Q?Q30w+S4OoimB/sfIS+KT/vDCb?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7aa34be0-2abf-4f52-51ae-08db2a01d683 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 11:45:58.8914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rc4CjHb5kdGYA88lkoYHD6h18OfscdLJXlD8EFOgLvGx2iRlaRVT8f6Ahwg7OcR6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5883 X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On 3/17/2023 11:09 AM, Anthony Harivel wrote: > Ferruh Yigit, Mar 16, 2023 at 18:05: >> Hi Anthony, >> >> What is the motivation here? > > Hi Ferruh, > > AFAIK testpmd is the reference tool used for CI and tests whether it is > for functional or performance tests and I think it would be in > everyone's interest to consume less CPU during them. Moreover, all > patches coming to the ML are going through validation tests and this > could reduce the maintenance cost of the project. > I don't think testpmd CPU usage is a real concern, it is only used by limited number of people and only for a limited duration. And optimizations like this may jeopardize its main task. On the other hand, CPU/power consumption of a DPDK application in production is a concern, and there may be many parties interested in to reduce watt/core with a reasonable performance impact. There is already a 'power' library for this purpose, to enable power optimizations for all DPDK applications, instead of just implementing them on a specific application (like testpmd). In my experience heuristics approaches (as done in your patch) depends on workload, while it helps for some usecases it may hurt in others. Still there may be customers willing to test a specific one for a specific workload. What do you think to have these heuristics approaches implemented in the power library, and add a new power sample application that selects one of existing algorithm as a kind of plugin? It can start with single algorithm, that is what you used in this patch. But overall how to add them into power library needs to be designed. cc'ed @Dave as power library/sample maintainer.