DPDK CI discussions
 help / color / mirror / Atom feed
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: "Wei, FangfangX" <fangfangx.wei@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"Xu, Qian Q" <qian.q.xu@intel.com>
Cc: "ci@dpdk.org" <ci@dpdk.org>, "O'Driscoll, Tim" <tim.odriscoll@intel.com>
Subject: Re: [dpdk-ci] script to determine target repo (was DPDK Lab)
Date: Wed, 21 Jun 2017 08:20:21 +0000	[thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B0721805ED@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <067B569323FEB248B5CB480E1954F4346F4174FD@SHSMSX101.ccr.corp.intel.com>

Hi Fangfang,

My comments on the questions you asked:

1. For determining the repo tree to target, I don't believe that we can ever come up with a 100% accurate rule, as the tree to which a set is to be applied can be difficult to determine, so it may be done on the basis of on-list discussion. A 90% accurate rule it what we may have to accept. However, since applying a patchset to a tree should not be a time-consuming operation, I suggest any script produce a list of possible trees in priority order to try. If not net, then try main, etc. etc.

2. Using the order from patch titles is correct.

/Bruce

> -----Original Message-----
> From: Wei, FangfangX
> Sent: Wednesday, June 21, 2017 8:46 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Xu, Qian Q
> <qian.q.xu@intel.com>
> Cc: ci@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> O'Driscoll, Tim <tim.odriscoll@intel.com>
> Subject: RE: [dpdk-ci] script to determine target repo (was DPDK Lab)
> 
> Hi Thomas,
> 
> What's the status about the script which determine target repo for each
> patch set?
> Currently I used the rule which you told me before: "the subject prefix on
> the patches should provide the hint. If the majority of the patches start
> with "net/" then it's for next-net, and similarly for crypto. Patches with
> virtio or vhost go to that tree, etc".
> But I'm not sure about the 100% correct repo.
> Looking forward to your script.
> 
> Another thing, Qian told me that you want to know the apply sequence about
> many patches in one patch set.
> I don't apply patches with the order of patchwork id, but the names' order
> about them.
> Such as, patchset 25081-25085, the order of patchwork id is not the
> correct patches' order.
> http://dpdk.org/patch/25081, subject: [dpdk-dev,v2,1/5] net/qede:
> refactoring vport handling code http://dpdk.org/patch/25083, subject:
> [dpdk-dev,v2,2/5] net/qede: refactoring multi-queue implementation
> http://dpdk.org/patch/25084, subject: [dpdk-dev,v2,3/5] net/qede/base:
> upgrade the FW to 8.20.0.0 http://dpdk.org/patch/25082, subject: [dpdk-
> dev,v2,4/5] net/qede: fix VXLAN tunnel Tx offload flag setting
> http://dpdk.org/patch/25085, subject: [dpdk-dev,v2,5/5] net/qede: refactor
> Tx routine After download them, the patches' names are as below:
> http://dpdk.org/patch/25081: dpdk-dev-v2-1-5-net-qede-refactoring-vport-
> handling-code.patch
> http://dpdk.org/patch/25083: dpdk-dev-v2-2-5-net-qede-refactoring-multi-
> queue-implementation.patch
> http://dpdk.org/patch/25084: dpdk-dev-v2-3-5-net-qede-base-upgrade-the-FW-
> to-8.20.0.0.patch
> http://dpdk.org/patch/25082: dpdk-dev-v2-4-5-net-qede-fix-VXLAN-tunnel-Tx-
> offload-flag-setting.patch
> http://dpdk.org/patch/25085: dpdk-dev-v2-5-5-net-qede-refactor-Tx-
> routine.patch
> 
> So applying these patches based on the order of their names, it will be
> correct.
> 
> 
> Best Regards
> Fangfang Wei
> 
> 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, April 25, 2017 2:51 PM
> To: Xu, Qian Q <qian.q.xu@intel.com>
> Cc: ci@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Wei,
> FangfangX <fangfangx.wei@intel.com>; O'Driscoll, Tim
> <tim.odriscoll@intel.com>; Liu, Yuanhan <yuanhan.liu@intel.com>
> Subject: Re: [dpdk-ci] script to determine target repo (was DPDK Lab)
> 
> 25/04/2017 08:23, Xu, Qian Q:
> > Thanks Thomas and Bruce for your comments. Currently we are trying to
> > start the per patch set performance test investigation and need to know
> the Target repo for each patch set.
> > The goal is to get 100% correct repo to go for each patch set. It's
> important for the credit of the performance result.
> > @Thomas, could you provide any script to support the auto-filter after
> the 17.05 release? Currently, we don't have the ability to make it.
> 
> OK, it is on my todo list.
> 
> Other task: I want to check the series support in the patchwork git.

  reply	other threads:[~2017-06-21  8:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <26FA93C7ED1EAA44AB77D62FBE1D27BA722C837C@IRSMSX108.ger.corp.intel.com>
     [not found] ` <HE1PR0501MB21370D6ACD0931D36925D085BD0D0@HE1PR0501MB2137.eurprd05.prod.outlook.com>
     [not found]   ` <82F45D86ADE5454A95A89742C8D1410E3B5BA2BB@shsmsx102.ccr.corp.intel.com>
     [not found]     ` <1564461.MHdNEdeViC@xps13>
2017-04-13  5:25       ` [dpdk-ci] DPDK Lab Xu, Qian Q
2017-04-13  6:46         ` [dpdk-ci] script to determine target repo (was DPDK Lab) Thomas Monjalon
2017-04-25  6:23           ` Xu, Qian Q
2017-04-25  6:24             ` Xu, Qian Q
2017-04-25  6:37             ` Wei, FangfangX
2017-04-25  6:41               ` Wei, FangfangX
2017-04-25  6:48               ` Thomas Monjalon
2017-04-25  6:50             ` Thomas Monjalon
2017-06-21  7:45               ` Wei, FangfangX
2017-06-21  8:20                 ` Richardson, Bruce [this message]
2017-06-21  8:33                   ` Thomas Monjalon
2017-06-23  8:43                     ` Xu, Qian Q
2017-06-23  9:30                       ` Richardson, Bruce
2017-06-26  3:47                         ` Xu, Qian Q
2017-06-26  6:23                         ` Jerin Jacob
2017-06-26 13:26                           ` Xu, Qian Q
2017-06-30  8:41                     ` Wei, FangfangX
2017-06-30  9:22                       ` Thomas Monjalon
2017-04-13  8:24         ` [dpdk-ci] DPDK Lab Richardson, Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59AF69C657FD0841A61C55336867B5B0721805ED@IRSMSX104.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ci@dpdk.org \
    --cc=fangfangx.wei@intel.com \
    --cc=qian.q.xu@intel.com \
    --cc=thomas@monjalon.net \
    --cc=tim.odriscoll@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).