DPDK CI discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ali Alnubani <alialnu@nvidia.com>,
	kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>,
	"dev@dpdk.org" <dev@dpdk.org>, dpdklab <dpdklab@iol.unh.edu>
Cc: Kumara Parameshwaran <kparameshwar@vmware.com>,
	"ci@dpdk.org" <ci@dpdk.org>, Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from name
Date: Mon, 7 Feb 2022 17:25:23 +0000
Message-ID: <7fd3bad5-d443-ae87-8788-e5b656050201@intel.com> (raw)
In-Reply-To: <DM4PR12MB5167CC42C602B975CFFD15BBDA2C9@DM4PR12MB5167.namprd12.prod.outlook.com>

On 2/7/2022 4:47 PM, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, February 7, 2022 6:37 PM
>> To: Ali Alnubani <alialnu@nvidia.com>; kumaraparameshwaran rathinavel
>> <kumaraparamesh92@gmail.com>; dev@dpdk.org; dpdklab
>> <dpdklab@iol.unh.edu>
>> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org
>> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from
>> name
>>
>> On 2/7/2022 4:08 PM, Ali Alnubani wrote:
>>>> -----Original Message-----
>>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> Sent: Thursday, February 3, 2022 1:32 PM
>>>> To: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>;
>>>> dev@dpdk.org
>>>> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>;
>> ci@dpdk.org;
>>>> Ali Alnubani <alialnu@nvidia.com>
>>>> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from
>>>> name
>>>>
>>>> On 2/3/2022 11:09 AM, kumaraparameshwaran rathinavel wrote:
>>>>> Ferruh,
>>>>>
>>>>> Since in the older patch we had introduced rte_eth_dev_get_by_name
>>>> patch and had been merged to dpdk-next-net, the current patch failed
>> for
>>>> the build when I submitted the patch. Is there a way to enforce it to dpdk-
>>>> next-net ?
>>>>>
>>>>
>>>> CIs apply it onto the main repo, there is a script that chose which
>>>> tree to apply, it seems it is not working as expected for the
>>>> 'drivers/net:' case, cc'ed ci mail list and @Ali for it.
>>>>
>>>
>>> Sorry for the delayed response,
>>>
>>> The script (https://git.dpdk.org/tools/dpdk-
>> ci/tree/tools/pw_maintainers_cli.py) correctly chooses next-net for this
>> patch:
>>> $ MAINTAINERS_FILE_PATH=/path/to/MAINTAINERS
>> tools/pw_maintainers_cli.py --type patch list-trees 106830
>>> Output: dpdk-next-net
>>>
>>> Did the script fail for some reason during this build?
>>
>> In the community CI, initially it tried to build the patch on top of main repo,
>> and it failed.
>>
>> Build looks OK now since I manually triggered re-build it on top of next-net.
> 
> Hi Ferruh,
> 
> Did the job initially decide to apply on main repo because it was chosen by the script?

That is my understanding. Community CI decides which repo to apply based on
your script, as far as I know. But I don't know if there may be any version
difference etc..

> Is it possible to see the pw_maintainers_cli.py command that was used and its output?

I don't know, maybe community CI maintainers may know.

  reply	other threads:[~2022-02-07 17:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220203082412.79028-1-kumaraparamesh92@gmail.com>
     [not found] ` <CANxNyatu+tyqf1gyxM_1P_=oCyNiEOMdpbWSMLOnhgiffAnQGw@mail.gmail.com>
2022-02-03 11:31   ` Ferruh Yigit
2022-02-07 16:08     ` Ali Alnubani
2022-02-07 16:36       ` Ferruh Yigit
2022-02-07 16:47         ` Ali Alnubani
2022-02-07 17:25           ` Ferruh Yigit [this message]
2022-02-07 19:58             ` Owen Hilyard
2022-02-10 20:44               ` Yigit, Ferruh
2022-02-10 22:06                 ` Owen Hilyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fd3bad5-d443-ae87-8788-e5b656050201@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=aconole@redhat.com \
    --cc=alialnu@nvidia.com \
    --cc=ci@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=kparameshwar@vmware.com \
    --cc=kumaraparamesh92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git