From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Kevin Traynor <ktraynor@redhat.com>,
David Marchand <david.marchand@redhat.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>
Cc: dev <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>,
Aaron Conole <aconole@redhat.com>, "ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support
Date: Tue, 10 Mar 2020 09:36:42 +0000 [thread overview]
Message-ID: <8145ace5-7b3e-82fa-95e2-28dc1844459e@intel.com> (raw)
In-Reply-To: <21697353.6Emhk5qWAg@xps>
On 3/10/2020 7:48 AM, Thomas Monjalon wrote:
> 10/03/2020 03:00, Wang, Haiyue:
>>> -----Original Message-----
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Tuesday, March 10, 2020 03:34
>>> To: Thomas Monjalon <thomas@monjalon.net>; David Marchand <david.marchand@redhat.com>; Ye, Xiaolong
>>> <xiaolong.ye@intel.com>
>>> Cc: Wang, Haiyue <haiyue.wang@intel.com>; dev <dev@dpdk.org>; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang,
>>> Qiming <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
>>> Aaron Conole <aconole@redhat.com>; ci@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
>>> Subject: Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support
>>>
>>> On 09/03/2020 17:57, Thomas Monjalon wrote:
>>>> 09/03/2020 17:20, Ye Xiaolong:
>>>>> Hi, David
>>>>>
>>>>> On 03/09, David Marchand wrote:
>>>>>> On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>>>>>>>
>>>>>>> A DCF (Device Config Function) based approach is proposed where a device
>>>>>>> bound to the device's VF0 can act as a sole controlling entity to exercise
>>>>>>> advance functionality (such as switch, ACL) for rest of the VFs.
>>>>>>>
>>>>>>> The DCF works as a standalone PMD to support this function, which shares the
>>>>>>> ice PMD flow control core function and the iavf virtchnl mailbox core module.
>>>>>>>
>>>>>>> This patchset is based on:
>>>>>>> [1] https://patchwork.dpdk.org/cover/66417/ update ice base code
>>>>>>
>>>>>> The problem is that the CI(s) won't handle this.
>>>>>> Example for the robot: https://travis-ci.com/ovsrobot/dpdk/builds/152461907
>>>>>>
>>>>>> Maybe we could add something as an annotation to the cover letter or
>>>>>> the first patch of a series so that the CI(s) can detect and try to be
>>>>>> intelligent?
>>>>>
>>>>> Agree, It'd be helpful if the cover letter of the first patch contains some
>>>>> base tree info including the base commit and dependency patchset info (if any),
>>>>> so the CI can determine the correct base on top of which the developer's
>>>>> patchset applies to avoid any apply issue and potential false positive.
>>>>>
>>>>> And I know there is one option '--base'' of `git format-patch` which is
>>>>> dedicated for this kind of usage, it can help create the base tree info block
>>>>> which can be easily consumed by the CI. Here is the simple intro of it.
>>>>>
>>>>> Imagine that on top of the public commit P (already in upstream), the developer
>>>>> applied well-known (on-flight, in the mailing list but not merged yet) patches
>>>>> X, Y and Z from somebody else or himself, and then built his three-patch series
>>>>> A, B, C, the commit history would be like:
>>>>>
>>>>> ................................................
>>>>> ---P---X---Y---Z---A---B---C
>>>>> ................................................
>>>>>
>>>>> With `git format-patch --base=P -3 C`,
>>>>>
>>>>> where P could be the exact commit sha, or variants e.g. HEAD~6, we can also use
>>>>> --base=auto for convenience, the base tree information block will be shown at
>>>>> the end of the first message the command outputs (either the first patch, or
>>>>> the cover letter), like this:
>>>>>
>>>>> ------------
>>>>> base-commit: P
>>>>> prerequisite-patch-id: X
>>>>> prerequisite-patch-id: Y
>>>>> prerequisite-patch-id: Z
>>>>> ------------
>>>>>
>>>>> Here P is the commit sha, and X,Y,Z are the patch ids of the dependency patches.
>>>>>
>>>>>
>>>>> With this info in place, I think CI should be able to setup the exact base for
>>>>> the coming patchset, the missing part I can see is the mapping of
>>>>> (in-flight patch <-> patch id), since we have all the in-flight patches in
>>>>> patchwork, creating and maintaining such mapping in DB is doable, what do you
>>>>> think?
>>>>
>>>> I think it would simpler to list dependencies as patchwork ids.
>>>> Example:
>>>> Depends-on: series-42, patch-12345
>>>>
>>>
>>
>> Just list the 'series' ? Since it can download the whole patchset with
>> the single link format like:
>>
>> Depends-on: series-8843 --> https://patchwork.dpdk.org/series/8843/mbox/
>
> Yes, I was proposing both format: series-X and patch-Y (on top of series-X).
> But we probably never need to be specific about a single patch.
> I think you are right, we can keep only "series-X" syntax,
> and allow describing a list of series, ordered and separated with comma.
>
+1 to "Depends-on: series-#####" syntax
next prev parent reply other threads:[~2020-03-10 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200309141437.11800-1-haiyue.wang@intel.com>
2020-03-09 15:36 ` David Marchand
2020-03-09 16:20 ` Ye Xiaolong
2020-03-09 17:57 ` Thomas Monjalon
2020-03-09 19:34 ` Kevin Traynor
2020-03-10 2:00 ` Wang, Haiyue
2020-03-10 7:48 ` Thomas Monjalon
2020-03-10 9:36 ` Ferruh Yigit [this message]
2020-03-10 14:11 ` Aaron Conole
2020-03-10 14:09 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8145ace5-7b3e-82fa-95e2-28dc1844459e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aconole@redhat.com \
--cc=beilei.xing@intel.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=ktraynor@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=thomas@monjalon.net \
--cc=wei.zhao1@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).