DPDK CI discussions
 help / color / mirror / Atom feed
From: "Xu, Qian Q" <qian.q.xu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "ci@dpdk.org" <ci@dpdk.org>,
	"Wei, FangfangX" <fangfangx.wei@intel.com>,
	"Liu, Yong" <yong.liu@intel.com>
Subject: Re: [dpdk-ci] Intel PerPatch Build
Date: Tue, 29 Nov 2016 03:56:55 +0000	[thread overview]
Message-ID: <82F45D86ADE5454A95A89742C8D1410E3927590F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <3110646.SlUphBRNZp@xps13>

See below inline, thx. 

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
Sent: Monday, November 28, 2016 6:09 PM
To: Xu, Qian Q <qian.q.xu@intel.com>
Cc: ci@dpdk.org; Wei, FangfangX <fangfangx.wei@intel.com>
Subject: Re: Intel PerPatch Build

2016-11-28 07:30, Xu, Qian Q:
> Hi, Thomas
> Pls note that we have updated the per patch Intel compilation check 
> report, and it's the per patch build report. You can get the 
> test-status result from below report. If you have any comments for the 
> report, just feel free to let us know.

Thanks for improving the report.
I have few comments.

The list of test reports is easier to read if every report titles start with [dpdk-test-report] |SUCCESS| (or |FAILURE|) I think you can remove [Intel PerPatch Build] in the title.

---Sure, Fangfang will change it. 

I feel we need to split the report.
What do you think of having a report per OS? or a report per build?
It would show easily how big is the failure by looking at the counters and descriptions in patchwork.
The email volume would be bigger but is it a problem?
----current report is for per patch build report, and for each patch, we now have 18 builds. We will send out 1 build report for 1 patch.  If we send 18 reports for 1 patch, then it may be too many reports. 
If you want to check how many failures for the build, for example, 18 builds, then 1 failures, there is 2 ways to check. 
1. you can get how many failures information from the Build Summary. 
> Patch17274-17274 --> compile pass
> Build Summary: 18 Builds Done, 18 Successful, 0 Failures

2. We can add the failure numbers in the title, such as [dpdk-test-report] |2 FAILURE|xxxxx

Does it make sense? 



You need to use the script send-patch-report.sh.
It will make your reports integrated in patchwork.
---Fangfang will check your scripts and try it. 

If I understand well you test every patches of a series at once and send the report for the last patch of the series?
----No. We send the report for each patch of the series, not the last one. The process of per patch build check is as below. 
1. We pull the patchset, for example, we have 10 patches in 1 patchset. We will apply all the patches to the git tree. 
If apply failed for one tree, we will try other trees(such as next-virtio, next-crypto, next-net), if any tree can be applied, then 
We think the patch apply OK. If all trees can't be applied, we take it as Failure. Then we will send out 10 patch reports, each one is Failure. 

2. If apply patch is OK, then we do per patch build check one by one. After 10 patch's build done, we will send report one by one. 
For example, 10 patches in 1 patchset, we will do 18 builds for each patch, totally 180 builds for the patchset. Then send report for each patch after the last patch. 
Test1: patch1: 18 build
Test2: patch1 + patch2: 18 build
....
Test10: patch1+xxx+patch10: 18build

Is it clear? 

I think it is a good option while waiting for a real series support in patchwork and dpdk-ci scripts.
--We can provide per patch result, no need patchset result. 
 
> Patch17274-17274 --> compile pass
> Build Summary: 18 Builds Done, 18 Successful, 0 Failures

  reply	other threads:[~2016-11-29  3:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <587443$9qu68@orsmga002.jf.intel.com>
2016-11-28  7:30 ` [dpdk-ci] [dpdk-test-report] [Intel PerPatch Build] |SUCCESS| pw17274 [PATCH, v2] maintainers: update testpmd maintainer Xu, Qian Q
2016-11-28 10:08   ` [dpdk-ci] Intel PerPatch Build Thomas Monjalon
2016-11-29  3:56     ` Xu, Qian Q [this message]
2016-11-29  9:20       ` Thomas Monjalon
2016-11-30  6:49         ` Xu, Qian Q
2016-11-30  8:33           ` Thomas Monjalon
2016-11-30  9:25             ` Xu, Qian Q
2016-11-30  9:46               ` Thomas Monjalon
2016-12-01  9:00                 ` Xu, Qian Q
2016-12-01  9:26                   ` Thomas Monjalon
2016-12-01  9:29                     ` Wei, FangfangX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82F45D86ADE5454A95A89742C8D1410E3927590F@shsmsx102.ccr.corp.intel.com \
    --to=qian.q.xu@intel.com \
    --cc=ci@dpdk.org \
    --cc=fangfangx.wei@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).