DPDK CI discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xu, Qian Q" <qian.q.xu@intel.com>
Cc: ci@dpdk.org, "Wei, FangfangX" <fangfangx.wei@intel.com>,
	"Liu, Yong" <yong.liu@intel.com>
Subject: Re: [dpdk-ci] Intel PerPatch Build
Date: Tue, 29 Nov 2016 10:20:59 +0100	[thread overview]
Message-ID: <8972903.ZmvP4EtD2m@xps13> (raw)
In-Reply-To: <82F45D86ADE5454A95A89742C8D1410E3927590F@shsmsx102.ccr.corp.intel.com>

2016-11-29 03:56, Xu, Qian Q:
> I feel we need to split the report.
> What do you think of having a report per OS? or a report per build?
> It would show easily how big is the failure by looking at the counters and descriptions in patchwork.
> The email volume would be bigger but is it a problem?
> ----current report is for per patch build report, and for each patch, we now have 18 builds. We will send out 1 build report for 1 patch.  If we send 18 reports for 1 patch, then it may be too many reports.

Why is it too many reports?

> If you want to check how many failures for the build, for example, 18 builds, then 1 failures, there is 2 ways to check. 
> 1. you can get how many failures information from the Build Summary. 
> > Patch17274-17274 --> compile pass
> > Build Summary: 18 Builds Done, 18 Successful, 0 Failures
> 
> 2. We can add the failure numbers in the title, such as [dpdk-test-report] |2 FAILURE|xxxxx
> 
> Does it make sense? 

In one build test, there can be several errors (even if we stop at the first error).
And one error can be seen in several build tests.
So we cannot really count the number of real errors, but we can count the number
of tests which are failing.
Yes we could add the number of failed tests in a test report.
I just thought that it would be simpler to understand if sending 1 report per test.

An example of the benefit of splitting:
An error with recent GCC is a failure.
An error with ICC or an old GCC may be just a warning.
Finer is the grain of the reports, better is the patchwork overview.
Today, we have few tests only. But later we could have more and more
test instances sending the same kind of reports.

Another example:
If a test is failing for some reasons, it will fail for every patches.
We must have a way to ignore it when reading the results.
If it is a separate report, it is easier to ignore.

> If I understand well you test every patches of a series at once and send the report for the last patch of the series?
> ----No. We send the report for each patch of the series, not the last one. The process of per patch build check is as below. 
> 1. We pull the patchset, for example, we have 10 patches in 1 patchset. We will apply all the patches to the git tree. 
> If apply failed for one tree, we will try other trees(such as next-virtio, next-crypto, next-net), if any tree can be applied, then 
> We think the patch apply OK. If all trees can't be applied, we take it as Failure. Then we will send out 10 patch reports, each one is Failure. 
> 
> 2. If apply patch is OK, then we do per patch build check one by one. After 10 patch's build done, we will send report one by one. 
> For example, 10 patches in 1 patchset, we will do 18 builds for each patch, totally 180 builds for the patchset. Then send report for each patch after the last patch. 
> Test1: patch1: 18 build
> Test2: patch1 + patch2: 18 build
> ....
> Test10: patch1+xxx+patch10: 18build
> 
> Is it clear? 

OK perfect, thanks


PS: please Qian, could you configure your email client to use reply quoting?

  reply	other threads:[~2016-11-29  9:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <587443$9qu68@orsmga002.jf.intel.com>
2016-11-28  7:30 ` [dpdk-ci] [dpdk-test-report] [Intel PerPatch Build] |SUCCESS| pw17274 [PATCH, v2] maintainers: update testpmd maintainer Xu, Qian Q
2016-11-28 10:08   ` [dpdk-ci] Intel PerPatch Build Thomas Monjalon
2016-11-29  3:56     ` Xu, Qian Q
2016-11-29  9:20       ` Thomas Monjalon [this message]
2016-11-30  6:49         ` Xu, Qian Q
2016-11-30  8:33           ` Thomas Monjalon
2016-11-30  9:25             ` Xu, Qian Q
2016-11-30  9:46               ` Thomas Monjalon
2016-12-01  9:00                 ` Xu, Qian Q
2016-12-01  9:26                   ` Thomas Monjalon
2016-12-01  9:29                     ` Wei, FangfangX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8972903.ZmvP4EtD2m@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=ci@dpdk.org \
    --cc=fangfangx.wei@intel.com \
    --cc=qian.q.xu@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).