I'm used to Gerrit where reruns on a given version always run with the same parent commit. I think this makes sense since this would give us a way to rerun with the same parent and the latest parent (using a new upload). Also, the version we're trying to rerun may no longer apply to the current HEAD, so it makes sense from this point of view as well. Juraj From: ci On Behalf Of Lincoln Lavoie Sent: Tuesday, October 12, 2021 2:39 PM To: Ferruh Yigit Cc: Thinh Tran ; Brandon Lo ; Zhang, Qi Z ; dev ; Yang, Qiming ; ci@dpdk.org; Aaron Conole ; dpdklab ; Singh, Aman Deep ; David Marchand Subject: Re: [dpdk-ci] [dpdk-dev] RHEL7 failures Ferruh and Thinh, Yes, that will also work and should trigger the rebuild to the tip of the current git repo / branch. Apologizes for forgetting that behavior is built into the runner. All, That raises the question, for the planned work to allow triggering rebuilds / reruns through patchwork, what is the expected behavior, rerun exactly what was run before, or move to the current pointer (assuming it's moved on) and build/run on top of that? What best aligns with everyone's expectations, so we don't get confusion, etc.? Cheers, Lincoln On Mon, Oct 11, 2021 at 8:58 PM Ferruh Yigit > wrote: On 10/11/2021 11:45 PM, Thinh Tran wrote: > Hi Brandon, > > Does the rebuild have the fix for RHEL 7? Please check. > > I just checked the build status, it still hits the same failure on RHEL 7: https://lab.dpdk.org/results/dashboard/patchsets/19066/ Your patch still applied on 'dpdk (086d426406bd3f6fac96a15bbd871c7fe714bc2d)', which doesn't have the fix. It seems 'Rebuild' still using the same commit from dpdk. Submitting a new version of the patch can be easiest solution to run CI on correct version. > > [1502/2903] Compiling C object drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o > FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o > ccache cc -Idrivers/net/ice/base/libice_base.a.p -Idrivers/net/ice/base -I../drivers/net/ice/base -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-unused-value -Wno-unused-but-set-variable -Wno-unused-variable -Wno-unused-parameter -MD -MQ > drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c ../drivers/net/ice/base/ice_parser_rt.c > ../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel': > ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] > d64 = *(u64 *)&b[0]; > ^ > ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel': > ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] > d32 = *(u32 *)&v[0]; > ^ > cc1: all warnings being treated as errors > > Thanks, > Thinh Tran > > On 10/11/2021 12:17 PM, Brandon Lo wrote: >> Hi Thinh, >> >> I have started a rerun of the patch >> https://patches.dpdk.org/patch/100042 (patchset >> https://lab.dpdk.org/results/dashboard/patchsets/19066/). >> You should see the new results reported over email soon. >> >> Thanks, >> Brandon >> >> >> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran > wrote: >>> >>> Hi Linconln, >>> >>> I have this patch set 100042 - build/ppc: enable build support for Power10 >>> https://patches.dpdk.org/patch/100042 >>> >>> Thanks, >>> Thinh Tran >>> >>> >>> >>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote: >>>> Hi Thinh, The CI won't automatically go back and retest failures after a >>>> patch was applied. This is a corner case, where a bad change was merged >>>> and affected all patches downstream of that merge. We can retrigger >>>> specific patches, just ZjQcmQRYFpfptBannerStart >>>> This Message Is From an External Sender >>>> This message came from outside your organization. >>>> ZjQcmQRYFpfptBannerEnd >>>> Hi Thinh, >>>> >>>> The CI won't automatically go back and retest failures after a patch was >>>> applied. This is a corner case, where a bad change was merged and >>>> affected all patches downstream of that merge. We can retrigger >>>> specific patches, just let us know the patch number or the URI of the >>>> patch(es). >>>> >>>> Cheers, >>>> Lincoln >>>> >>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran >>>> >> wrote: >>>> >>>> >>>> Hi, >>>> I'm wondering how or when the CI would re-pick up the patches those >>>> were >>>> failed due to this issue? >>>> >>>> Regards, >>>> Thinh Tran >>>> >>>> On 10/6/2021 10:40 PM, Zhang, Qi Z wrote: >>>> > Hi Ferruh, David and Aman: >>>> > >>>> > Sorry for late response due to PRC holiday. >>>> > I have just tested the patch and there is no issue be >>>> detected for functions >>>> > Thank you so much for the help! >>>> > >>>> > Regards >>>> > Qi >>>> > >>>> >> -----Original Message----- >>>> >> From: Yigit, Ferruh >>>> >> >>>> >> Sent: Wednesday, October 6, 2021 5:46 AM >>>> >> To: Lincoln Lavoie >>>> >>; dev >>>> >>; Yang, Qiming >>>> >> >>; Zhang, >>>> Qi Z >> >>>> >> Cc: ci@dpdk.org >; Aaron Conole >>>> >>; dpdklab >>>> >> >>; Singh, Aman >>>> Deep >>; >>>> >> David Marchand >>>> >> >>>> >> Subject: Re: [dpdk-dev] RHEL7 failures >>>> >> >>>> >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote: >>>> >>> Hello Qiming and Qi, >>>> >>> >>>> >>> The CI is picking up failures when building on RHEL7, where >>>> warnings >>>> >>> are being treated as errors. This looks like something has been >>>> >>> merged into the mainline, as it's failing across all patches. >>>> >>> >>>> >>> Here is the specific failure: >>>> >>> >>>> >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel': >>>> >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing >>>> >>> type-punned pointer will break strict-aliasing rules >>>> >>> [-Werror=strict-aliasing] >>>> >>> d64 = *(u64 *)&b[0]; >>>> >>> ^ >>>> >>> ../drivers/net/ice/base/ice_parser_rt.c: In function >>>> '_reg_bit_sel': >>>> >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing >>>> >>> type-punned pointer will break strict-aliasing rules >>>> >>> [-Werror=strict-aliasing] >>>> >>> d32 = *(u32 *)&v[0]; >>>> >>> ^ >>>> >>> cc1: all warnings being treated as errors >>>> >>> >>>> >>> You can download a full set of logs from here (for a failing run): >>>> >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/ >>>> >>>> >>> >>>> >> >>>> >> Issue was reported by David, Aman sent the fix [1] and it is >>>> already merged by >>>> >> David [2], it should be fixed now, can you please double check? >>>> >> >>>> >> [1] >>>> >> >>>> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman >>>> >>>> >> .deep.singh@intel.com/ >>>> >> >>>> >> [2] >>>> >> >>>> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809 >>>> >>>> >> 021b154 >>>> >>>> >>>> >>>> -- >>>> *Lincoln Lavoie* >>>> Principal Engineer, Broadband Technologies >>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824 >>>> lylavoie@iol.unh.edu > >>>> https://www.iol.unh.edu >>>> +1-603-674-2755 (m) >>>> >> >> >> -- Lincoln Lavoie Principal Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m) [Image removed by sender.]