Re: [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files

[Ali Alnubani <alialnu@mellanox.com>]

Hi David,
Thanks for the fix.

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, January 7, 2020 12:29 AM
> To: David Marchand <david.marchand@redhat.com>
> Cc: ci@dpdk.org; Ali Alnubani <alialnu@mellanox.com>
> Subject: Re: [PATCH] tools: fix tree detection for "unmaintained" files
> 
> 06/01/2020 12:15, David Marchand:
> > Implicitly, if a file has no official maintainer / tree, it is in the
> > end maintained in the master branch.
> >
> > This problem has been seen while looking at test failures reported on
> > the series
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D7981&amp;data
> =02%7C01%7Calialnu%40mellanox.com%7C973da6c13b094a514bc008d792f7d
> 986%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63713946551617
> 2792&amp;sdata=US%2FBhk2huEVZDPXCUTqgwKNqqMJFuL7oxd049pXKLe
> M%3D&amp;reserved=0.
> >
> > This series mixes changes in ethdev, net/tap and EAL, and thus should
> > go through the main repository.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > -            if _tree:
> > -                tree_list.append(_tree)
> > +            # No identified tree for a file means that it should go through
> > +            # the main repository.
> > +            if not _tree:
> > +                _tree = 'dpdk'
> > +            tree_list.append(_tree)
> 
> It looks good to me.
> This is the expected behaviour but it seems the case was forgotten when
> writing this function.
> 
> Waiting for the review/ack from Ali before merging.
> Thanks
> 

Acked-by: Ali Alnubani <alialnu@mellanox.com>

Thanks,
Ali