From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "David Marchand" <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"dpdklab@iol.unh.edu" <dpdklab@iol.unh.edu>,
"ci@dpdk.org" <ci@dpdk.org>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"mattias.ronnblom" <mattias.ronnblom@ericsson.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Aaron Conole" <aconole@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: RE: [PATCH v3] test/service: fix spurious failures by extending timeout
Date: Mon, 27 Feb 2023 08:41:18 +0000 [thread overview]
Message-ID: <BN0PR11MB5712BE4C2CBF77B160A7F5A6D7AF9@BN0PR11MB5712.namprd11.prod.outlook.com> (raw)
In-Reply-To: <4132916.ZDofJx8uAJ@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, February 23, 2023 8:11 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: David Marchand <david.marchand@redhat.com>; dev@dpdk.org;
> dpdklab@iol.unh.edu; ci@dpdk.org; Honnappa.Nagarahalli@arm.com;
> mattias.ronnblom <mattias.ronnblom@ericsson.com>; Morten Brørup
> <mb@smartsharesystems.com>; Tyler Retzlaff <roretzla@linux.microsoft.com>;
> Aaron Conole <aconole@redhat.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Subject: Re: [PATCH v3] test/service: fix spurious failures by extending timeout
>
> 03/02/2023 16:12, Bruce Richardson:
> > On Fri, Feb 03, 2023 at 03:03:38PM +0000, Van Haaren, Harry wrote:
> > > From: Van Haaren, Harry
> > >
> > > <snip>
> > >
> > > > > The timeout approach just does not have its place in a functional test.
> > > > > Either this test is rewritten, or it must go to the performance tests
> > > > > list so that we stop getting false positives.
> > > > > Can you work on this?
> > > >
> > > > I'll investigate various approaches on Thursday and reply here with suggested
> > > > next steps.
> > >
> > > I've identified 3 checks that fail in CI (from the above log outputs), all 3 cases
> > > Have different dlays: 100 ms delay, 200 ms delay and 1000ms.
> > > In the CI, the service-core just hasn't been scheduled (yet) and causes the
> "failure".
> >
> > For me, the question is - why hasn't the service-core been scheduled? Can
> > we use sched-yield or some other mechanism to force a wakeup of it?
>
> Harry, you didn't reply to this question please.
Same answer as similar topic in the other thread:
> > I'm not aware of a way to make *a specific other pthread* wakeup. We could sacrifice
> > the current lcore that's waiting for the service-lcore, with a sched_yield() as you suggest.
> > It would potentially "churn" the scheduler enough to give the service core some CPU?
> > It's a guess/gamble in the end, kind of like the timeouts we have today..
Patch sent as requested in other email.
next prev parent reply other threads:[~2023-02-27 8:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 8:17 [PATCH] " Harry van Haaren
2022-10-06 8:28 ` [PATCH v2] " Harry van Haaren
2022-10-06 8:39 ` David Marchand
2022-10-06 8:54 ` Mattias Rönnblom
2022-10-06 8:37 ` [PATCH] " Mattias Rönnblom
2022-10-06 12:52 ` [PATCH v3] " Harry van Haaren
2022-10-06 13:27 ` Morten Brørup
2022-10-06 19:33 ` David Marchand
2023-01-26 9:29 ` David Marchand
2023-01-31 17:24 ` Van Haaren, Harry
2023-02-03 15:03 ` Van Haaren, Harry
2023-02-03 15:12 ` Bruce Richardson
2023-02-23 20:10 ` Thomas Monjalon
2023-02-27 8:41 ` Van Haaren, Harry [this message]
2023-02-03 15:16 ` Thomas Monjalon
2023-02-03 16:09 ` Van Haaren, Harry
2023-02-23 20:15 ` Thomas Monjalon
2023-02-27 8:41 ` Van Haaren, Harry
2022-10-06 14:00 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN0PR11MB5712BE4C2CBF77B160A7F5A6D7AF9@BN0PR11MB5712.namprd11.prod.outlook.com \
--to=harry.van.haaren@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).