DPDK CI discussions
 help / color / mirror / Atom feed
* Re: [dpdk-ci] [dpdk-dev] [PATCH v3 0/2] fix mingw build error
       [not found]     ` <2799531.7hoMMOPb9E@thomas>
@ 2021-02-02  8:36       ` David Marchand
  2021-02-02  9:09         ` Rong, Leyi
  0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2021-02-02  8:36 UTC (permalink / raw)
  To: Leyi Rong, Dmitry Kozlyuk
  Cc: Thomas Monjalon, Bruce Richardson, Tal Shnaiderman, Qi Zhang,
	Pallavi Kadam, Yigit, Ferruh, Ranjit Menon, Beilei Xing, dev,
	Aaron Conole, ci, dpdklab

On Thu, Jan 28, 2021 at 10:27 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 28/01/2021 13:28, David Marchand:
> > On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong <leyi.rong@intel.com> wrote:
> > >
> > > This patchset fix mingw build error when avx512 is introduced.
> > >
> > > ---
> > > v2:
> > > - Set i40e_avx512_cc_support to false to avoid the build error under
> > >   windows with mingw.
> > >
> > > Leyi Rong (2):
> > >   config: disable avx512 on mingw cross build
> > >   net/i40e: fix mingw build error
> > >
> > >  config/x86/cross-mingw       | 3 +++
> > >  drivers/net/i40e/meson.build | 4 ++++
> > >  2 files changed, 7 insertions(+)
> >
> > LGTM with fc32 mingw.
> > Tested-by: David Marchand <david.marchand@redhat.com>
>
> Applied, thanks.
>
> Dmitry found a lighter alternative option to be tested and discussed.

We still have build failures at UNH for Windows, on the rc2 tag:
http://mails.dpdk.org/archives/test-report/2021-February/177464.html

Is this issue being looked at?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] [PATCH v3 0/2] fix mingw build error
  2021-02-02  8:36       ` [dpdk-ci] [dpdk-dev] [PATCH v3 0/2] fix mingw build error David Marchand
@ 2021-02-02  9:09         ` Rong, Leyi
  0 siblings, 0 replies; 2+ messages in thread
From: Rong, Leyi @ 2021-02-02  9:09 UTC (permalink / raw)
  To: David Marchand, Dmitry Kozlyuk
  Cc: Thomas Monjalon, Richardson, Bruce, Tal Shnaiderman, Zhang, Qi Z,
	Kadam, Pallavi, Yigit, Ferruh, Menon, Ranjit, Xing, Beilei, dev,
	Aaron Conole, ci, dpdklab


> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, February 2, 2021 4:37 PM
> To: Rong, Leyi <leyi.rong@intel.com>; Dmitry Kozlyuk
> <dmitry.kozliuk@gmail.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Richardson, Bruce
> <bruce.richardson@intel.com>; Tal Shnaiderman <talshn@nvidia.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Kadam, Pallavi <pallavi.kadam@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; dev <dev@dpdk.org>; Aaron Conole
> <aconole@redhat.com>; ci@dpdk.org; dpdklab <dpdklab@iol.unh.edu>
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error
> 
> On Thu, Jan 28, 2021 at 10:27 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > 28/01/2021 13:28, David Marchand:
> > > On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong <leyi.rong@intel.com> wrote:
> > > >
> > > > This patchset fix mingw build error when avx512 is introduced.
> > > >
> > > > ---
> > > > v2:
> > > > - Set i40e_avx512_cc_support to false to avoid the build error under
> > > >   windows with mingw.
> > > >
> > > > Leyi Rong (2):
> > > >   config: disable avx512 on mingw cross build
> > > >   net/i40e: fix mingw build error
> > > >
> > > >  config/x86/cross-mingw       | 3 +++
> > > >  drivers/net/i40e/meson.build | 4 ++++
> > > >  2 files changed, 7 insertions(+)
> > >
> > > LGTM with fc32 mingw.
> > > Tested-by: David Marchand <david.marchand@redhat.com>
> >
> > Applied, thanks.
> >
> > Dmitry found a lighter alternative option to be tested and discussed.
> 
> We still have build failures at UNH for Windows, on the rc2 tag:
> http://mails.dpdk.org/archives/test-report/2021-February/177464.html
> 
> Is this issue being looked at?
> 
> 
> --
> David Marchand

Hi David,

Seems the issue still exist on the platform which CPU has AVX512 capability, I think previous patch is not verified to cover this case.
Will send hotfix patch for this.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-02  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210126153819.63625-1-leyi.rong@intel.com>
     [not found] ` <20210127142706.6290-1-leyi.rong@intel.com>
     [not found]   ` <CAJFAV8xyGY1BHdXaS_wN8Kz4O-++rj0RyYMkEFhkLW2StyBr=w@mail.gmail.com>
     [not found]     ` <2799531.7hoMMOPb9E@thomas>
2021-02-02  8:36       ` [dpdk-ci] [dpdk-dev] [PATCH v3 0/2] fix mingw build error David Marchand
2021-02-02  9:09         ` Rong, Leyi

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git