DPDK CI discussions
 help / color / mirror / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "zhaoyan.chen@intel.com" <zhaoyan.chen@intel.com>,
	"ci@dpdk.org" <ci@dpdk.org>,
	"sys_stv@intel.com" <sys_stv@intel.com>
Cc: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: [dpdk-ci] Wrong Checkpatch failure in Intel CI
Date: Tue, 31 Mar 2020 19:51:19 +0000	[thread overview]
Message-ID: <BYAPR18MB2424E0F36D07CD83B441E676C8C80@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)

Hello,

It looks like "devtools/check-symbol-change.sh" cached in Intel Patchwork CI.
The commit[2] is fixed the issue reported by [1]. The commit[2] already part of
Master but some reason some this cached in CI system and it pick OLD checkpatch infra.

Could someone look into this issue from Intel side?


[1]
http://mails.dpdk.org/archives/test-report/2020-March/123095.html

[2]
commit f08885494f241b115ad66763b585fbfb486d5160
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date:   Mon Mar 23 17:26:13 2020 +0530

    devtools: fix symbol map change check

    Fix check symbol change script to detect new diff file when
    it is in between  "--- /dev/null" to "b/lib/...".
    Current awk line expects line to start with "a/..."
    which is not always true for all diffs.
    As a result if in_map was '1' earlier, it will not be changed
    to '0' and we get check patch errors which are not true.

    Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
    Cc: stable@dpdk.org

    Signed-off-by: David Marchand <david.marchand@redhat.com>
    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
    Acked-by: Neil Horman <nhorman@tuxdriver.com>
    Tested-by: Jerin Jacob <jerinj@marvell.com>


             reply	other threads:[~2020-03-31 19:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 19:51 Jerin Jacob Kollanukkaran [this message]
2020-03-31 20:03 ` Thomas Monjalon
2020-03-31 20:12   ` [dpdk-ci] [EXT] " Jerin Jacob Kollanukkaran
2020-03-31 20:39     ` Thomas Monjalon
2020-04-01 11:22       ` Jerin Jacob Kollanukkaran
2020-04-01 12:18         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2424E0F36D07CD83B441E676C8C80@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=ndabilpuram@marvell.com \
    --cc=sys_stv@intel.com \
    --cc=thomas@monjalon.net \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).