DPDK CI discussions
 help / color / mirror / Atom feed
From: Jeremy Plsek <jplsek@iol.unh.edu>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ali Alnubani <alialnu@mellanox.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	 "ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [dpdk-ci] [PATCH v4] add script to decide best tree match for patches
Date: Fri, 19 Apr 2019 13:33:09 -0400	[thread overview]
Message-ID: <CA+xUZB4OdmRDmVsTGr1mprJz5TwXakC+1uGp_CuhcmadPz4ZEA@mail.gmail.com> (raw)
In-Reply-To: <2149176.42v1TqmSes@xps>

I thinks so. Only more patchsets will tell, but that could be improved
after the fact. So I think it's fine to merge it in.

At first glance, the only part that I don't think is implemented is
mentioned here: https://bugs.dpdk.org/show_bug.cgi?id=166#c35
> We must match the common prefix of the git trees.
> Examples:
> dpdk-next-net-intel + dpdk = dpdk
> dpdk-next-net-intel + dpdk-next-net-mlx = dpdk-next-net
Since some of the patches are being set to dpdk-next-net-mlx instead
of dpdk-next-net. But I'm fine with how it is right now and wouldn't
mind it getting changed to this later on.

On Fri, Apr 19, 2019 at 12:24 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 19/04/2019 18:21, Jeremy Plsek:
> > On Thu, Apr 18, 2019 at 4:16 AM Ali Alnubani <alialnu@mellanox.com> wrote:
> > > Did you guys get a chance to test this version?
> >
> > We've switched to using it a few days ago.
> > Some examples of it switching branches:
> > https://lab.dpdk.org/results/dashboard/patchsets/5503/
> > https://lab.dpdk.org/results/dashboard/patchsets/5499/
> > https://lab.dpdk.org/results/dashboard/patchsets/5498/
>
> Is it working as you expect?
> May I merge it in dpdk-ci?
>
>


-- 
Jeremy Plsek
UNH InterOperability Laboratory

  reply	other threads:[~2019-04-19 17:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12 14:48 [dpdk-ci] [PATCH v2] " Ali Alnubani
2019-02-15 21:28 ` Jeremy Plsek
2019-02-15 23:08   ` Thomas Monjalon
2019-02-17  8:09     ` Ali Alnubani
2019-02-16 16:03 ` [dpdk-ci] [PATCH v3] " Ali Alnubani
2019-04-09 16:12   ` [dpdk-ci] [PATCH v4] " Ali Alnubani
2019-04-18  8:16     ` Ali Alnubani
2019-04-19 16:21       ` Jeremy Plsek
2019-04-19 16:24         ` Thomas Monjalon
2019-04-19 17:33           ` Jeremy Plsek [this message]
2019-04-19 17:55             ` Thomas Monjalon
2019-04-19 18:06               ` Jeremy Plsek
2019-04-19 19:41                 ` Thomas Monjalon
2019-04-19 19:45                   ` Jeremy Plsek
2019-04-19 20:39     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+xUZB4OdmRDmVsTGr1mprJz5TwXakC+1uGp_CuhcmadPz4ZEA@mail.gmail.com \
    --to=jplsek@iol.unh.edu \
    --cc=alialnu@mellanox.com \
    --cc=ci@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).