DPDK CI discussions
 help / color / mirror / Atom feed
From: Jeremy Spewock <jspewock@iol.unh.edu>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Patrick Robb <probb@iol.unh.edu>,
	Ali Alnubani <alialnu@nvidia.com>, "ci@dpdk.org" <ci@dpdk.org>,
	Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH v7 0/4] Add ACVP Tool
Date: Wed, 12 Apr 2023 17:10:40 -0400	[thread overview]
Message-ID: <CAAA20UTiYFJ1AVxn6B76M0BhYnxpEXYw88km+YDm+oEmnrvyAw@mail.gmail.com> (raw)
In-Reply-To: <2276688.ElGaqSPkdT@thomas>

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

Hello,

I can see why you would want to squash everything into one patch; I had
just thought that the intention with maintaining the structure of the old
patch series was to preserve Brandon's original commits and comments
alongside some minor expansion where necessary. If it would be
preferred however, I can resubmit with everything squashed into a single
patch.

Aaron, if you could also review this series and give your thoughts on the
matter as well that would be greatly appreciated.

Thanks,
Jeremy

On Wed, Apr 12, 2023 at 4:16 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> Hi,
>
> Aaron is the maintainer.
> I can also push the commits.
>
> I think you should squash all in one patch
> and provide an explanation in the commit message
> about what this tool is for exactly.
>
>
> 11/04/2023 23:22, Patrick Robb:
> > Hi Ali,
> >
> > Aaron says he is not a maintainer either. Do you know whether there is
> some
> > place I can look to see who the current maintainers are? There isn't an
> > equivalent to the MAINTAINERS file like in the main DPDK repo.
> >
> > Thomas, you might be the only current maintainer on this repo. We'll be
> > grateful at the lab if you're able to merge this patch.
> >
> > Best,
> > Patrick
> >
> > On Mon, Apr 10, 2023 at 11:19 AM Ali Alnubani <alialnu@nvidia.com>
> wrote:
> >
> > > > Hi Ali,
> > > >
> > > > Is this good to be merged since it's been acked by a maintainer with
> no
> > > more discussion afterwards? Or is there something more to be done here?
> > > [..]
> > >
> > > Hello Patrick,
> > >
> > > Already acked from my side, waiting for a maintainer to merge if they
> have
> > > no other comments (Thomas/Aaron).
> > >
> > > Thanks,
> > > Ali
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 2413 bytes --]

  reply	other threads:[~2023-04-12 21:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 18:39 jspewock
2023-04-03 18:39 ` [PATCH v7 1/4] tools: add acvp_tool jspewock
2023-04-03 18:39 ` [PATCH v7 2/4] tools: add default config file for acvp_tool jspewock
2023-04-03 18:39 ` [PATCH v7 3/4] tools: add requirements " jspewock
2023-04-03 18:39 ` [PATCH v7 4/4] doc: add readme " jspewock
2023-04-04 13:20 ` [PATCH v7 0/4] Add ACVP Tool Ali Alnubani
2023-04-10 14:56   ` Patrick Robb
2023-04-10 15:19     ` Ali Alnubani
2023-04-11 21:22       ` Patrick Robb
2023-04-12  8:16         ` Thomas Monjalon
2023-04-12 21:10           ` Jeremy Spewock [this message]
2023-04-13 21:20             ` Aaron Conole
2023-04-13 21:20           ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAA20UTiYFJ1AVxn6B76M0BhYnxpEXYw88km+YDm+oEmnrvyAw@mail.gmail.com \
    --to=jspewock@iol.unh.edu \
    --cc=aconole@redhat.com \
    --cc=alialnu@nvidia.com \
    --cc=ci@dpdk.org \
    --cc=probb@iol.unh.edu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).