Re: [PATCH v6 3/6] containers/builder: Dockerfile creation script

[Adam Hassick <ahassick@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

This script is not intended to be run by the end user on their machine's
bare environment. The CI worker container will acquire the needed python
version to run this script when the container is built; the end user does
not need to install python 3.10 themselves. The
"make_docker_files_in_container" target in the Makefile is the intended way
to call this script. The build and push targets then depend on that target.

To me, this appears fine, but let me know if you have any concerns.

On Thu, Jun 22, 2023 at 11:55 AM Ali Alnubani <alialnu@nvidia.com> wrote:

> > -----Original Message-----
> > From: Adam Hassick <ahassick@iol.unh.edu>
> > Sent: Thursday, May 25, 2023 8:15 PM
> > To: ci@dpdk.org
> > Cc: aconole@redhat.com; Ali Alnubani <alialnu@nvidia.com>; Owen Hilyard
> > <ohilyard@iol.unh.edu>; Adam Hassick <ahassick@iol.unh.edu>
> > Subject: [PATCH v6 3/6] containers/builder: Dockerfile creation script
> >
> > From: Owen Hilyard <ohilyard@iol.unh.edu>
> >
> > This script will template out all of the Dockerfiles based on the
> > definitions provided in the inventory using the jinja2 templating
> > library.
> >
> [..]
> > +
> > +def get_host_arch() -> str:
> > +    machine: str = platform.machine()
> > +    match machine:
>
> This adds a nondocumented dependency on Python 3.10.
>


-- 
*Adam Hassick*
Senior Developer
UNH InterOperability Lab
ahassick@iol.unh.edu
iol.unh.edu <https://www.iol.unh.edu/>
+1 (603) 475-8248

[-- Attachment #2: Type: text/html, Size: 3075 bytes --]