From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98EB445B6A; Fri, 18 Oct 2024 19:25:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DF8E40267; Fri, 18 Oct 2024 19:25:43 +0200 (CEST) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by mails.dpdk.org (Postfix) with ESMTP id 8EB5A4025C for ; Fri, 18 Oct 2024 19:25:41 +0200 (CEST) Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-e29267b4dc4so2274870276.0 for ; Fri, 18 Oct 2024 10:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1729272341; x=1729877141; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nnGRKhYB8a4DeYCpp7bMCQuqqyeG1nJAOupFnI4+pnk=; b=eTEfRxILA3bKT7cAxy5DqRunru6rAbNedDtDmvTAfyjWhFgwRoIRgAM9BfvEW8cpGm WNm/S57fKiCejwY71dvrR4dWN2XnJg5/OCoTcEtJvqDO3vJk+/nHBFWymag7wlX69cdN S1smP7fNRREEcnLjFDSzp9O7aNIMEXR5QCJQ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729272341; x=1729877141; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nnGRKhYB8a4DeYCpp7bMCQuqqyeG1nJAOupFnI4+pnk=; b=iN/gRkqHHoAfQTxl+6ZeQEnlFfReM8waoVS85uMJ+SD3BXBKapRifmvhTd+2xrqv/P uLsf0swUL6RDyyxA3NhizXjLWiI3a/Z67XErzW1R8FBxrQBbkd5k66acInwuABvliyIY o3YSnPWP+4T5doLyYG7ZnhiNz29yRg+9H/9z7uNtxYgeEjwxHzzLGTVt8MA+dom9S9XP T5leDPF866nvKbHs7dgoF/VZnMXR/vwlt7nLF7BQ+0QQilxnuapyB6uJILpsWa9ud+Pw dGxaKYyx+z/XnNzfK5DgiINExk7XfxIJS08MkWyR//GtTVK8McjrL6ifPYrSpCo/JGuo g9ag== X-Gm-Message-State: AOJu0Yy69vgpGJQaP9m+CEEw5SDcWDbF9XlIL/Iq0T9mBxgD0Mz0RD56 DrY6rOeCvSyu8eHbAF5JXnZU/FgETOtsWOnJd/2RfVC5Yudgd9z7SElSmIyQSmApZzxM8ouspF4 B6n3UQWw1XIyV7+Rov7fbcpznLjTi57FKMQ5afw== X-Google-Smtp-Source: AGHT+IEiD8j6TMGGqGfPsEwqjM8nATH6/3OraXmhfzHNXHy4eJ+HOTZT+c7347aTXTDjnNCEbyAocgmqMAAsMSQHUoo= X-Received: by 2002:a05:6902:f86:b0:e29:7bd5:cec9 with SMTP id 3f1490d57ef6-e2bb11ba256mr2693436276.12.1729272340789; Fri, 18 Oct 2024 10:25:40 -0700 (PDT) MIME-Version: 1.0 References: <20241015213211.587-1-mmahajan@iol.unh.edu> In-Reply-To: <20241015213211.587-1-mmahajan@iol.unh.edu> From: Adam Hassick Date: Fri, 18 Oct 2024 13:28:28 -0400 Message-ID: Subject: Re: [PATCH] tools: run check-meson.py in create_series_artifact To: Manit Mahajan Cc: ci@dpdk.org, probb@iol.unh.edu, thomas@monjalon.net, aconole@redhat.com, bruce.richardson@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On Tue, Oct 15, 2024 at 5:34=E2=80=AFPM Manit Mahajan wrote: > > The check-meson.py is a python script that runs checks on meson.build > files in DPDK. Checks include, splitting a line into a code part and a > comment part, list of files are correctly indented, and more. Updating > create_series_artifact.py to run the check-meson.py so check-meson.py can > be run on all incoming patches. In UNH CI, we will report a build failure= if the Looks like the two lines above are too long, I am seeing a warning when running checkpatch. > check-meson.py reports an error. > > Signed-off-by: Manit Mahajan > --- > tools/create_series_artifact.py | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/tools/create_series_artifact.py b/tools/create_series_artifa= ct.py > index 550ea82..bfc97f8 100755 > --- a/tools/create_series_artifact.py > +++ b/tools/create_series_artifact.py > @@ -251,6 +251,24 @@ class ProjectTree(object): > self.set_properties(apply_error=3Derror) > return not error > > + > + def check_meson(self) -> bool: > + > + result =3D subprocess.run( > + ['python', os.path.join(self.path, "devtools/check-meson.py"= ), '-d', str(self.path), '-v'], > + cwd=3Dself.path, > + stdout=3Dsubprocess.PIPE, > + stderr=3Dsubprocess.PIPE, > + ) > + > + self.log("Running Check Meson") > + self.log(result.stdout.decode()) > + self.log(result.stderr.decode()) > + > + error =3D "Error" in result.stdout.decode() > + self.set_properties(meson_error=3Derror) > + return not error > + > def test_build(self) -> bool: > ninja_result: Optional[subprocess.CompletedProcess] =3D None > meson_result: subprocess.CompletedProcess =3D subprocess.run( > @@ -454,8 +472,14 @@ def collect_series_info(args: argparse.Namespace) ->= CreateSeriesParameters: > > > def try_to_apply(tree: ProjectTree) -> bool: > - return tree.apply_patch_series() and tree.test_build() and tree.crea= te_tarball() > > + artifact_build_result =3D True > + artifact_build_result &=3D tree.apply_patch_series() > + artifact_build_result &=3D tree.check_meson() > + artifact_build_result &=3D tree.test_build() > + artifact_build_result &=3D tree.create_tarball() > + > + return artifact_build_result > > def main() -> int: > data =3D collect_series_info(parse_args()) > -- > 2.41.0 >