DPDK CI discussions
 help / color / Atom feed
* Re: [dpdk-ci] Understanding results of patchwork
       [not found]   ` <CAJFAV8xmLOdY3uoi1wD8jpdMRTYtAbgq8zXxhXqWETYBNA+7qw@mail.gmail.com>
@ 2020-04-15 16:45     ` Ferruh Yigit
  2020-04-15 17:11       ` Aaron Conole
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2020-04-15 16:45 UTC (permalink / raw)
  To: David Marchand
  Cc: Ajit Khaparde, Aaron Conole, sys_stv, Chen, Zhaoyan, Lincoln Lavoie, ci

On 4/15/2020 5:42 PM, David Marchand wrote:
> On Wed, Apr 15, 2020 at 6:34 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 4/15/2020 3:40 PM, Ajit Khaparde wrote:
>>> Ferruh,
>>> I am trying to apply this patchset.
>>> https://patchwork.dpdk.org/project/dpdk/list/?series=9386
>>>
>>> So I am trying to check if the patches passed all the checks.
>>> I can see only the checkpatch for individual patches and the
>>> travis result - presumably for the complete set.
>>>
>>> https://travis-ci.com/ovsrobot/dpdk/builds/160349438
>>>
>>> For previous versions, I had seen results for individual patches and performance
>>> results also. Is it enough to apply the patches based on just the travis and
>>> checkpatch results?
>>>
>>
>> Hi Ajit,
>>
>> We expect other checks, cc'ed David too.
> 
> Better to Cc: ci@dpdk.org from my pov.

Agree, cc'ed now.

> 
> 
>>
>> Intel-compilation seems not sending the reports for a day, last one is from
>> yesterday, it may be stuck in some set, etc.. @Zhaoyan, can you please check it?
>>
>> The community lab one is still on pending state, it may be because it is a big
>> patchset.
>> https://lab.dpdk.org/results/dashboard/patchsets/10445/
>>
>>
>> And @David, @Aaron, does travis checks patchset only or does it checks each
>> patch in set?
> 
> Travis checks the whole patchset at the last patch.

Thanks, so we are missing patch by patch checks in our CI checks, since as far
as I know Intel check is also for patchset.

> The dpdk.org server sends checkpatch reports for each patch.
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-ci] Understanding results of patchwork
  2020-04-15 16:45     ` [dpdk-ci] Understanding results of patchwork Ferruh Yigit
@ 2020-04-15 17:11       ` Aaron Conole
  2020-04-15 17:24         ` Ajit Khaparde
  0 siblings, 1 reply; 3+ messages in thread
From: Aaron Conole @ 2020-04-15 17:11 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: David Marchand, Ajit Khaparde, sys_stv, Chen\,
	Zhaoyan, Lincoln Lavoie, ci\

Ferruh Yigit <ferruh.yigit@intel.com> writes:

> On 4/15/2020 5:42 PM, David Marchand wrote:
>> On Wed, Apr 15, 2020 at 6:34 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 4/15/2020 3:40 PM, Ajit Khaparde wrote:
>>>> Ferruh,
>>>> I am trying to apply this patchset.
>>>> https://patchwork.dpdk.org/project/dpdk/list/?series=9386
>>>>
>>>> So I am trying to check if the patches passed all the checks.
>>>> I can see only the checkpatch for individual patches and the
>>>> travis result - presumably for the complete set.
>>>>
>>>> https://travis-ci.com/ovsrobot/dpdk/builds/160349438
>>>>
>>>> For previous versions, I had seen results for individual patches and performance
>>>> results also. Is it enough to apply the patches based on just the travis and
>>>> checkpatch results?
>>>>
>>>
>>> Hi Ajit,
>>>
>>> We expect other checks, cc'ed David too.
>> 
>> Better to Cc: ci@dpdk.org from my pov.
>
> Agree, cc'ed now.
>
>> 
>> 
>>>
>>> Intel-compilation seems not sending the reports for a day, last one is from
>>> yesterday, it may be stuck in some set, etc.. @Zhaoyan, can you please check it?
>>>
>>> The community lab one is still on pending state, it may be because it is a big
>>> patchset.
>>> https://lab.dpdk.org/results/dashboard/patchsets/10445/
>>>
>>>
>>> And @David, @Aaron, does travis checks patchset only or does it checks each
>>> patch in set?
>> 
>> Travis checks the whole patchset at the last patch.
>
> Thanks, so we are missing patch by patch checks in our CI checks, since as far
> as I know Intel check is also for patchset.

For now, we only check the series as a whole in travis to save on
time.  It's expected that someone / something else would do
patch-at-a-time for the series, to preserve the ability to bisect
through series.

>> The dpdk.org server sends checkpatch reports for each patch.
>> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-ci] Understanding results of patchwork
  2020-04-15 17:11       ` Aaron Conole
@ 2020-04-15 17:24         ` Ajit Khaparde
  0 siblings, 0 replies; 3+ messages in thread
From: Ajit Khaparde @ 2020-04-15 17:24 UTC (permalink / raw)
  To: Aaron Conole
  Cc: Ferruh Yigit, David Marchand, sys_stv, Chen, Zhaoyan, Lincoln Lavoie, ci

[-- Attachment #1: Type: text/plain, Size: 2311 bytes --]

On Wed, Apr 15, 2020 at 10:11 AM Aaron Conole <aconole@redhat.com> wrote:

> Ferruh Yigit <ferruh.yigit@intel.com> writes:
>
> > On 4/15/2020 5:42 PM, David Marchand wrote:
> >> On Wed, Apr 15, 2020 at 6:34 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> >>>
> >>> On 4/15/2020 3:40 PM, Ajit Khaparde wrote:
> >>>> Ferruh,
> >>>> I am trying to apply this patchset.
> >>>> https://patchwork.dpdk.org/project/dpdk/list/?series=9386
> >>>>
> >>>> So I am trying to check if the patches passed all the checks.
> >>>> I can see only the checkpatch for individual patches and the
> >>>> travis result - presumably for the complete set.
> >>>>
> >>>> https://travis-ci.com/ovsrobot/dpdk/builds/160349438
> >>>>
> >>>> For previous versions, I had seen results for individual patches and
> performance
> >>>> results also. Is it enough to apply the patches based on just the
> travis and
> >>>> checkpatch results?
> >>>>
> >>>
> >>> Hi Ajit,
> >>>
> >>> We expect other checks, cc'ed David too.
> >>
> >> Better to Cc: ci@dpdk.org from my pov.
> >
> > Agree, cc'ed now.
> >
> >>
> >>
> >>>
> >>> Intel-compilation seems not sending the reports for a day, last one is
> from
> >>> yesterday, it may be stuck in some set, etc.. @Zhaoyan, can you please
> check it?
> >>>
> >>> The community lab one is still on pending state, it may be because it
> is a big
> >>> patchset.
> >>> https://lab.dpdk.org/results/dashboard/patchsets/10445/
> >>>
> >>>
> >>> And @David, @Aaron, does travis checks patchset only or does it checks
> each
> >>> patch in set?
> >>
> >> Travis checks the whole patchset at the last patch.
> >
> > Thanks, so we are missing patch by patch checks in our CI checks, since
> as far
> > as I know Intel check is also for patchset.
>
> For now, we only check the series as a whole in travis to save on
> time.  It's expected that someone / something else would do
> patch-at-a-time for the series, to preserve the ability to bisect
> through series.
>
Ok, thanks for the clarification.
We went through the exercise. Since this was a big patchset,
I was trying to be extra careful. So I wanted to make sure reports for all
automated checks are in. That's when I started digging into the reports
and the process.

Thanks


> >> The dpdk.org server sends checkpatch reports for each patch.
> >>
>
>

[-- Attachment #2: Type: text/html, Size: 4454 bytes --]

<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 15, 2020 at 10:11 AM Aaron Conole &lt;<a href="mailto:aconole@redhat.com">aconole@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ferruh Yigit &lt;<a href="mailto:ferruh.yigit@intel.com" target="_blank">ferruh.yigit@intel.com</a>&gt; writes:<br>
<br>
&gt; On 4/15/2020 5:42 PM, David Marchand wrote:<br>
&gt;&gt; On Wed, Apr 15, 2020 at 6:34 PM Ferruh Yigit &lt;<a href="mailto:ferruh.yigit@intel.com" target="_blank">ferruh.yigit@intel.com</a>&gt; wrote:<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; On 4/15/2020 3:40 PM, Ajit Khaparde wrote:<br>
&gt;&gt;&gt;&gt; Ferruh,<br>
&gt;&gt;&gt;&gt; I am trying to apply this patchset.<br>
&gt;&gt;&gt;&gt; <a href="https://patchwork.dpdk.org/project/dpdk/list/?series=9386" rel="noreferrer" target="_blank">https://patchwork.dpdk.org/project/dpdk/list/?series=9386</a><br>
&gt;&gt;&gt;&gt;<br>
&gt;&gt;&gt;&gt; So I am trying to check if the patches passed all the checks.<br>
&gt;&gt;&gt;&gt; I can see only the checkpatch for individual patches and the<br>
&gt;&gt;&gt;&gt; travis result - presumably for the complete set.<br>
&gt;&gt;&gt;&gt;<br>
&gt;&gt;&gt;&gt; <a href="https://travis-ci.com/ovsrobot/dpdk/builds/160349438" rel="noreferrer" target="_blank">https://travis-ci.com/ovsrobot/dpdk/builds/160349438</a><br>
&gt;&gt;&gt;&gt;<br>
&gt;&gt;&gt;&gt; For previous versions, I had seen results for individual patches and performance<br>
&gt;&gt;&gt;&gt; results also. Is it enough to apply the patches based on just the travis and<br>
&gt;&gt;&gt;&gt; checkpatch results?<br>
&gt;&gt;&gt;&gt;<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Hi Ajit,<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; We expect other checks, cc&#39;ed David too.<br>
&gt;&gt; <br>
&gt;&gt; Better to Cc: <a href="mailto:ci@dpdk.org" target="_blank">ci@dpdk.org</a> from my pov.<br>
&gt;<br>
&gt; Agree, cc&#39;ed now.<br>
&gt;<br>
&gt;&gt; <br>
&gt;&gt; <br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Intel-compilation seems not sending the reports for a day, last one is from<br>
&gt;&gt;&gt; yesterday, it may be stuck in some set, etc.. @Zhaoyan, can you please check it?<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; The community lab one is still on pending state, it may be because it is a big<br>
&gt;&gt;&gt; patchset.<br>
&gt;&gt;&gt; <a href="https://lab.dpdk.org/results/dashboard/patchsets/10445/" rel="noreferrer" target="_blank">https://lab.dpdk.org/results/dashboard/patchsets/10445/</a><br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; And @David, @Aaron, does travis checks patchset only or does it checks each<br>
&gt;&gt;&gt; patch in set?<br>
&gt;&gt; <br>
&gt;&gt; Travis checks the whole patchset at the last patch.<br>
&gt;<br>
&gt; Thanks, so we are missing patch by patch checks in our CI checks, since as far<br>
&gt; as I know Intel check is also for patchset.<br>
<br>
For now, we only check the series as a whole in travis to save on<br>
time.  It&#39;s expected that someone / something else would do<br>
patch-at-a-time for the series, to preserve the ability to bisect<br>
through series.<br></blockquote><div>Ok, thanks for the clarification. </div><div class="gmail_default" style="font-family:tahoma,sans-serif">We went through the exercise. Since this was a big patchset,</div><div class="gmail_default" style="font-family:tahoma,sans-serif">I was trying to be extra careful. So I wanted to make sure reports for all</div><div class="gmail_default" style="font-family:tahoma,sans-serif">automated checks are in. That&#39;s when I started digging into the reports</div><div class="gmail_default" style="font-family:tahoma,sans-serif">and the process.</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">Thanks</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
&gt;&gt; The <a href="http://dpdk.org" rel="noreferrer" target="_blank">dpdk.org</a> server sends checkpatch reports for each patch.<br>
&gt;&gt; <br>
<br>
</blockquote></div></div>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CACZ4nhvvNPB71Gs3DnpLmUDBPmkyOCmBL8qf9-_ynKRXc9itcA@mail.gmail.com>
     [not found] ` <d463e85b-83aa-300c-b89e-7f9138d18ff3@intel.com>
     [not found]   ` <CAJFAV8xmLOdY3uoi1wD8jpdMRTYtAbgq8zXxhXqWETYBNA+7qw@mail.gmail.com>
2020-04-15 16:45     ` [dpdk-ci] Understanding results of patchwork Ferruh Yigit
2020-04-15 17:11       ` Aaron Conole
2020-04-15 17:24         ` Ajit Khaparde

DPDK CI discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox