From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACA27A034C for ; Mon, 24 Oct 2022 14:52:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7F7B4069C; Mon, 24 Oct 2022 14:52:42 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 0BDCF40695 for ; Mon, 24 Oct 2022 14:52:41 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id n7so8374292plp.1 for ; Mon, 24 Oct 2022 05:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DKo7uglq85jF19TeQC4m57XOd2bK0gtUUEuuMkEej8w=; b=UCrN/WbywveDLT7tU+JgLB19QM6sx4dn6175UHqrfW7cYR+PCUSMzwI0pxUbcKDNTF MDquOSBc4AkpYfxRUIUb3fyoPRurF1j1HBzJvI3yFiyoeIJ4J7Sv3if0R3jNIFQZP/Ny cE8rHl+G0g/8oPJgb0HRYygI964E+dewLQuAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DKo7uglq85jF19TeQC4m57XOd2bK0gtUUEuuMkEej8w=; b=sUIwl9vCxIzmotRO3VcbYBGWuvoOuRat2sModmw6+cxqxJtMTJ1BecofJHTE+j+XjJ yCyM8MUPw1BDiyEgiuyaGNS2OqW2PKlJOZAXNWbAN25AVcCdLCLgIIEK7UXWatlfC0M0 Y6ioS5aUlD8hszV+1zLCU9av9+l2LQQ1vOqcrOcVkLEluE3JSxFbeCJf3esiJCCc6NFy ci/vaq+0kJA2iwOJ5sTDck7K+uQr8O2EFD9e23W0aPmFbSW0jJN7v7tzErQvTWK7ZQbH 6v8lHVf7ndzCTo3Em9QNv0gXWd4jh+6ChmCIPOZn2ML3Zh4zxYVa48WBBddZq/zXDa92 z9Xw== X-Gm-Message-State: ACrzQf110wLjMrdP6mqeT0beCR9YsU4ZgxVP0doC9d8DpQuCmL1YkGbc CLioPNQUA3MxcIHkKZub4/rDnr0oGwGdocWgIoHk6Q== X-Google-Smtp-Source: AMsMyM7WRsR6u4dB2guUpHaxlSWIOV0S3I+EqXhnefC4GN7qrGPvx4poW3kcQOm0JE6KHboguzpBU7G3mtKVVAqwh4U= X-Received: by 2002:a17:90b:190f:b0:211:5d2a:ade9 with SMTP id mp15-20020a17090b190f00b002115d2aade9mr28320173pjb.76.1666615960204; Mon, 24 Oct 2022 05:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20221019125307.258582-1-ohilyard@iol.unh.edu> <20221019125307.258582-5-ohilyard@iol.unh.edu> In-Reply-To: From: Owen Hilyard Date: Mon, 24 Oct 2022 08:52:04 -0400 Message-ID: Subject: Re: [PATCH v2 4/6] containers/templates: Templates for Dockerfiles To: Ali Alnubani Cc: "ci@dpdk.org" , "aconole@redhat.com" Content-Type: multipart/alternative; boundary="00000000000049119e05ebc7441f" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --00000000000049119e05ebc7441f Content-Type: text/plain; charset="UTF-8" On Wed, Oct 19, 2022 at 3:24 PM Ali Alnubani wrote: > > -----Original Message----- > > From: ohilyard@iol.unh.edu > > Sent: Wednesday, October 19, 2022 3:53 PM > > To: ci@dpdk.org > > Cc: aconole@redhat.com; Ali Alnubani ; Owen Hilyard > > > > Subject: [PATCH v2 4/6] containers/templates: Templates for Dockerfiles > > > > From: Owen Hilyard > > > > Adds a variety of extensible templates used to create the Dockerfiles > > for each target. All templates inherit from base, and most distros and > > distro families have their own templates that are used to define common > > functionality. Multiple versions of a distro may use a single template > > if they are similar enough (ex: fedora). > > > > Signed-off-by: Owen Hilyard > > --- > [..] > > diff --git > > a/containers/template_engine/templates/containers/base.dockerfile.j2 > > b/containers/template_engine/templates/containers/base.dockerfile.j2 > > new file mode 100644 > > index 0000000..c6194e9 > > --- /dev/null > > +++ b/containers/template_engine/templates/containers/base.dockerfile.j2 > > @@ -0,0 +1,81 @@ > [..] > > +# install libabigail > > +{% block install_libabigail %} > > +COPY libabigail libabigail > > +RUN --mount=type=cache,target=/ccache cd libabigail && mkdir build && > > autoreconf -i && cd build && ../configure --prefix=/usr/local && make all > > install && \ > > + ldconfig && cd .. && rm -rf libabigail > > Current directory is /libabigail/build/. You need to go back another > directory before executing "rm -rf libabigail". > > $ podman run -it --rm localhost/ubuntu20.04_compile > $ du -chs /libabigail/ > 1.9G /libabigail/ > 1.9G total > I'll fix that for v3. > By the way, do we have to build libabigail when > DPDK_CI_CONTAINERS_BUILD_ABI is disabled? > Technically no, but libabigail is installed via the package manager for distros that have it (Fedora, RHEL 7 & 8, and a few others). At UNH, we value environment consistency (same tools in every container) much more than disk space or build time. I'll add an option for anyone who has different preferences/priorities in v3. > > +{% endblock install_libabigail %} > [..] > --00000000000049119e05ebc7441f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Oct 19, 2022 at 3:24 PM Ali = Alnubani <alialnu@nvidia.com&g= t; wrote:
> -----Original Message-----
> From: ohilya= rd@iol.unh.edu <ohilyard@iol.unh.edu>
> Sent: Wednesday, October 19, 2022 3:53 PM
> To: ci@dpdk.org > Cc: aconole@re= dhat.com; Ali Alnubani <alialnu@nvidia.com>; Owen Hilyard
> <ohilyard= @iol.unh.edu>
> Subject: [PATCH v2 4/6] containers/templates: Templates for Dockerfile= s
>
> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> Adds a variety of extensible templates used to create the Dockerfiles<= br> > for each target. All templates inherit from base, and most distros and=
> distro families have their own templates that are used to define commo= n
> functionality. Multiple versions of a distro may use a single template=
> if they are similar enough (ex: fedora).
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
[..]
> diff --git
> a/containers/template_engine/templates/containers/base.dockerfile.j2 > b/containers/template_engine/templates/containers/base.dockerfile.j2 > new file mode 100644
> index 0000000..c6194e9
> --- /dev/null
> +++ b/containers/template_engine/templates/containers/base.dockerfile.= j2
> @@ -0,0 +1,81 @@
[..]
> +# install libabigail
> +{% block install_libabigail %}
> +COPY libabigail libabigail
> +RUN --mount=3Dtype=3Dcache,target=3D/ccache cd libabigail && = mkdir build &&
> autoreconf -i && cd build && ../configure --prefix=3D/= usr/local && make all
> install && \
> +=C2=A0 =C2=A0 ldconfig && cd .. && rm -rf libabigail<= br>
Current directory is /libabigail/build/. You need to go back another direct= ory before executing "rm -rf libabigail".

$ podman run -it --rm localhost/ubuntu20.04_compile
$ du -chs /libabigail/
1.9G=C2=A0 =C2=A0 /libabigail/
1.9G=C2=A0 =C2=A0 total

I'll fix th= at for v3.=C2=A0
=C2=A0
By the way, do we have to build libabigail when DPDK_CI_CONTAINERS_BUILD_AB= I is disabled?

Technically no, but liba= bigail is installed via the package manager for distros that have it (Fedor= a, RHEL 7 & 8, and a few others). At UNH, we value environment consiste= ncy (same tools in every container) much more than disk space or build time= . I'll add an option for anyone who has different preferences/prioritie= s in v3.=C2=A0
=C2=A0
> +{% endblock install_libabigail %}
[..]
--00000000000049119e05ebc7441f--