* Re: [PATCH v1] drivers/net: use internal API to get eth dev from name [not found] ` <CANxNyatu+tyqf1gyxM_1P_=oCyNiEOMdpbWSMLOnhgiffAnQGw@mail.gmail.com> @ 2022-02-03 11:31 ` Ferruh Yigit 2022-02-07 16:08 ` Ali Alnubani 0 siblings, 1 reply; 8+ messages in thread From: Ferruh Yigit @ 2022-02-03 11:31 UTC (permalink / raw) To: kumaraparameshwaran rathinavel, dev Cc: Kumara Parameshwaran, ci, Ali Alnubani On 2/3/2022 11:09 AM, kumaraparameshwaran rathinavel wrote: > Ferruh, > > Since in the older patch we had introduced rte_eth_dev_get_by_name patch and had been merged to dpdk-next-net, the current patch failed for the build when I submitted the patch. Is there a way to enforce it to dpdk-next-net ? > CIs apply it onto the main repo, there is a script that chose which tree to apply, it seems it is not working as expected for the 'drivers/net:' case, cc'ed ci mail list and @Ali for it. Meanwhile I re-run the community lab tests on top of next-net repo, still some other checks, like Intel ones, will continue to fail until patches reach to main tree. > On Thu, Feb 3, 2022 at 1:54 PM Kumara Parameshwaran <kumaraparamesh92@gmail.com <mailto:kumaraparamesh92@gmail.com>> wrote: > > From: Kumara Parameshwaran <kparameshwar@vmware.com <mailto:kparameshwar@vmware.com>> > > Make changes in PMDs to use the new function where > rte_eth_dev_get_port_by_name is used to get port_id > to access rte_eth_devices > > Signed-off-by: Kumara Parameshwaran <kparameshwar@vmware.com <mailto:kparameshwar@vmware.com>> ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v1] drivers/net: use internal API to get eth dev from name 2022-02-03 11:31 ` [PATCH v1] drivers/net: use internal API to get eth dev from name Ferruh Yigit @ 2022-02-07 16:08 ` Ali Alnubani 2022-02-07 16:36 ` Ferruh Yigit 0 siblings, 1 reply; 8+ messages in thread From: Ali Alnubani @ 2022-02-07 16:08 UTC (permalink / raw) To: Ferruh Yigit, kumaraparameshwaran rathinavel, dev Cc: Kumara Parameshwaran, ci > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@intel.com> > Sent: Thursday, February 3, 2022 1:32 PM > To: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>; > dev@dpdk.org > Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org; > Ali Alnubani <alialnu@nvidia.com> > Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from > name > > On 2/3/2022 11:09 AM, kumaraparameshwaran rathinavel wrote: > > Ferruh, > > > > Since in the older patch we had introduced rte_eth_dev_get_by_name > patch and had been merged to dpdk-next-net, the current patch failed for > the build when I submitted the patch. Is there a way to enforce it to dpdk- > next-net ? > > > > CIs apply it onto the main repo, there is a script that chose which > tree to apply, it seems it is not working as expected for the > 'drivers/net:' case, cc'ed ci mail list and @Ali for it. > Sorry for the delayed response, The script (https://git.dpdk.org/tools/dpdk-ci/tree/tools/pw_maintainers_cli.py) correctly chooses next-net for this patch: $ MAINTAINERS_FILE_PATH=/path/to/MAINTAINERS tools/pw_maintainers_cli.py --type patch list-trees 106830 Output: dpdk-next-net Did the script fail for some reason during this build? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] drivers/net: use internal API to get eth dev from name 2022-02-07 16:08 ` Ali Alnubani @ 2022-02-07 16:36 ` Ferruh Yigit 2022-02-07 16:47 ` Ali Alnubani 0 siblings, 1 reply; 8+ messages in thread From: Ferruh Yigit @ 2022-02-07 16:36 UTC (permalink / raw) To: Ali Alnubani, kumaraparameshwaran rathinavel, dev, dpdklab Cc: Kumara Parameshwaran, ci On 2/7/2022 4:08 PM, Ali Alnubani wrote: >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> Sent: Thursday, February 3, 2022 1:32 PM >> To: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>; >> dev@dpdk.org >> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org; >> Ali Alnubani <alialnu@nvidia.com> >> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from >> name >> >> On 2/3/2022 11:09 AM, kumaraparameshwaran rathinavel wrote: >>> Ferruh, >>> >>> Since in the older patch we had introduced rte_eth_dev_get_by_name >> patch and had been merged to dpdk-next-net, the current patch failed for >> the build when I submitted the patch. Is there a way to enforce it to dpdk- >> next-net ? >>> >> >> CIs apply it onto the main repo, there is a script that chose which >> tree to apply, it seems it is not working as expected for the >> 'drivers/net:' case, cc'ed ci mail list and @Ali for it. >> > > Sorry for the delayed response, > > The script (https://git.dpdk.org/tools/dpdk-ci/tree/tools/pw_maintainers_cli.py) correctly chooses next-net for this patch: > $ MAINTAINERS_FILE_PATH=/path/to/MAINTAINERS tools/pw_maintainers_cli.py --type patch list-trees 106830 > Output: dpdk-next-net > > Did the script fail for some reason during this build? In the community CI, initially it tried to build the patch on top of main repo, and it failed. Build looks OK now since I manually triggered re-build it on top of next-net. ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v1] drivers/net: use internal API to get eth dev from name 2022-02-07 16:36 ` Ferruh Yigit @ 2022-02-07 16:47 ` Ali Alnubani 2022-02-07 17:25 ` Ferruh Yigit 0 siblings, 1 reply; 8+ messages in thread From: Ali Alnubani @ 2022-02-07 16:47 UTC (permalink / raw) To: Ferruh Yigit, kumaraparameshwaran rathinavel, dev, dpdklab Cc: Kumara Parameshwaran, ci > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@intel.com> > Sent: Monday, February 7, 2022 6:37 PM > To: Ali Alnubani <alialnu@nvidia.com>; kumaraparameshwaran rathinavel > <kumaraparamesh92@gmail.com>; dev@dpdk.org; dpdklab > <dpdklab@iol.unh.edu> > Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org > Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from > name > > On 2/7/2022 4:08 PM, Ali Alnubani wrote: > >> -----Original Message----- > >> From: Ferruh Yigit <ferruh.yigit@intel.com> > >> Sent: Thursday, February 3, 2022 1:32 PM > >> To: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>; > >> dev@dpdk.org > >> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; > ci@dpdk.org; > >> Ali Alnubani <alialnu@nvidia.com> > >> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from > >> name > >> > >> On 2/3/2022 11:09 AM, kumaraparameshwaran rathinavel wrote: > >>> Ferruh, > >>> > >>> Since in the older patch we had introduced rte_eth_dev_get_by_name > >> patch and had been merged to dpdk-next-net, the current patch failed > for > >> the build when I submitted the patch. Is there a way to enforce it to dpdk- > >> next-net ? > >>> > >> > >> CIs apply it onto the main repo, there is a script that chose which > >> tree to apply, it seems it is not working as expected for the > >> 'drivers/net:' case, cc'ed ci mail list and @Ali for it. > >> > > > > Sorry for the delayed response, > > > > The script (https://git.dpdk.org/tools/dpdk- > ci/tree/tools/pw_maintainers_cli.py) correctly chooses next-net for this > patch: > > $ MAINTAINERS_FILE_PATH=/path/to/MAINTAINERS > tools/pw_maintainers_cli.py --type patch list-trees 106830 > > Output: dpdk-next-net > > > > Did the script fail for some reason during this build? > > In the community CI, initially it tried to build the patch on top of main repo, > and it failed. > > Build looks OK now since I manually triggered re-build it on top of next-net. Hi Ferruh, Did the job initially decide to apply on main repo because it was chosen by the script? Is it possible to see the pw_maintainers_cli.py command that was used and its output? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] drivers/net: use internal API to get eth dev from name 2022-02-07 16:47 ` Ali Alnubani @ 2022-02-07 17:25 ` Ferruh Yigit 2022-02-07 19:58 ` Owen Hilyard 0 siblings, 1 reply; 8+ messages in thread From: Ferruh Yigit @ 2022-02-07 17:25 UTC (permalink / raw) To: Ali Alnubani, kumaraparameshwaran rathinavel, dev, dpdklab Cc: Kumara Parameshwaran, ci, Aaron Conole On 2/7/2022 4:47 PM, Ali Alnubani wrote: >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> Sent: Monday, February 7, 2022 6:37 PM >> To: Ali Alnubani <alialnu@nvidia.com>; kumaraparameshwaran rathinavel >> <kumaraparamesh92@gmail.com>; dev@dpdk.org; dpdklab >> <dpdklab@iol.unh.edu> >> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org >> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from >> name >> >> On 2/7/2022 4:08 PM, Ali Alnubani wrote: >>>> -----Original Message----- >>>> From: Ferruh Yigit <ferruh.yigit@intel.com> >>>> Sent: Thursday, February 3, 2022 1:32 PM >>>> To: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>; >>>> dev@dpdk.org >>>> Cc: Kumara Parameshwaran <kparameshwar@vmware.com>; >> ci@dpdk.org; >>>> Ali Alnubani <alialnu@nvidia.com> >>>> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from >>>> name >>>> >>>> On 2/3/2022 11:09 AM, kumaraparameshwaran rathinavel wrote: >>>>> Ferruh, >>>>> >>>>> Since in the older patch we had introduced rte_eth_dev_get_by_name >>>> patch and had been merged to dpdk-next-net, the current patch failed >> for >>>> the build when I submitted the patch. Is there a way to enforce it to dpdk- >>>> next-net ? >>>>> >>>> >>>> CIs apply it onto the main repo, there is a script that chose which >>>> tree to apply, it seems it is not working as expected for the >>>> 'drivers/net:' case, cc'ed ci mail list and @Ali for it. >>>> >>> >>> Sorry for the delayed response, >>> >>> The script (https://git.dpdk.org/tools/dpdk- >> ci/tree/tools/pw_maintainers_cli.py) correctly chooses next-net for this >> patch: >>> $ MAINTAINERS_FILE_PATH=/path/to/MAINTAINERS >> tools/pw_maintainers_cli.py --type patch list-trees 106830 >>> Output: dpdk-next-net >>> >>> Did the script fail for some reason during this build? >> >> In the community CI, initially it tried to build the patch on top of main repo, >> and it failed. >> >> Build looks OK now since I manually triggered re-build it on top of next-net. > > Hi Ferruh, > > Did the job initially decide to apply on main repo because it was chosen by the script? That is my understanding. Community CI decides which repo to apply based on your script, as far as I know. But I don't know if there may be any version difference etc.. > Is it possible to see the pw_maintainers_cli.py command that was used and its output? I don't know, maybe community CI maintainers may know. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] drivers/net: use internal API to get eth dev from name 2022-02-07 17:25 ` Ferruh Yigit @ 2022-02-07 19:58 ` Owen Hilyard 2022-02-10 20:44 ` Yigit, Ferruh 0 siblings, 1 reply; 8+ messages in thread From: Owen Hilyard @ 2022-02-07 19:58 UTC (permalink / raw) To: Ferruh Yigit Cc: Ali Alnubani, kumaraparameshwaran rathinavel, dev, dpdklab, Kumara Parameshwaran, ci, Aaron Conole [-- Attachment #1: Type: text/plain, Size: 8282 bytes --] The Community CI hasn't been able to schedule downtime to update dpdk-ci across all of our systems since the refactoring Ali did. However, the patch was still applied on next-net and had a compilation error. See https://lab.dpdk.org/results/dashboard/patchsets/20895/. It was applied onto https://git.dpdk.org/next/dpdk-next-net/commit/?id=7445a787de053776616e41ab1d79090bd0f5ce33 . Owen Here's the build log in case you were having issues seeing it: [1/1511] Compiling C object drivers/librte_net_null.so.22.1.p/meson-generated_.._rte_net_null.pmd.c.o [2/1511] Compiling C object drivers/librte_net_octeontx.so.22.1.p/meson-generated_.._rte_net_octeontx.pmd.c.o [3/1511] Compiling C object drivers/librte_net_null.a.p/meson-generated_.._rte_net_null.pmd.c.o [4/1511] Compiling C object drivers/librte_net_octeontx_ep.so.22.1.p/meson-generated_.._rte_net_octeontx_ep.pmd.c.o [5/1511] Compiling C object drivers/librte_net_octeontx.a.p/meson-generated_.._rte_net_octeontx.pmd.c.o [6/1511] Compiling C object drivers/librte_net_pcap.so.22.1.p/meson-generated_.._rte_net_pcap.pmd.c.o [7/1511] Compiling C object drivers/librte_net_pfe.a.p/meson-generated_.._rte_net_pfe.pmd.c.o [8/1511] Linking static target drivers/librte_net_null.a [9/1511] Linking static target drivers/librte_net_octeontx.a [10/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_init_ops.c.o [11/1511] Linking static target drivers/librte_net_pfe.a [12/1511] Linking target drivers/librte_net_mlx5.so.22.1 [13/1511] Linking target drivers/librte_common_sfc_efx.so.22.1 [14/1511] Linking target drivers/librte_common_cnxk.so.22.1 [15/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_hw.c.o [16/1511] Compiling C object drivers/librte_net_octeontx_ep.a.p/meson-generated_.._rte_net_octeontx_ep.pmd.c.o [17/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_init_fw_funcs.c.o [18/1511] Linking target drivers/librte_net_bond.so.22.1 FAILED: drivers/librte_net_bond.so.22.1 cc -o drivers/librte_net_bond.so.22.1 drivers/librte_net_bond.so.22.1.p/meson-generated_.._rte_net_bond.pmd.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_8023ad.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_alb.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_api.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_args.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_flow.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_pmd.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_bond.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 lib/librte_sched.so.22.1 lib/librte_ip_frag.so.22.1 lib/librte_hash.so.22.1 lib/librte_rcu.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/bonding/version.map drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_api.c.o: In function `rte_eth_bond_create': rte_eth_bond_api.c:(.text+0x12e6): undefined reference to `rte_eth_dev_get_by_name' collect2: error: ld returned 1 exit status [19/1511] Linking target drivers/librte_net_ipn3ke.so.22.1 FAILED: drivers/librte_net_ipn3ke.so.22.1 cc -o drivers/librte_net_ipn3ke.so.22.1 drivers/librte_net_ipn3ke.so.22.1.p/meson-generated_.._rte_net_ipn3ke.pmd.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_ethdev.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_flow.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_representor.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_tm.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_ipn3ke.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 drivers/librte_bus_ifpga.so.22.1 lib/librte_rawdev.so.22.1 lib/librte_sched.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/ipn3ke/version.map drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_ethdev.c.o: In function `ipn3ke_vswitch_probe': ipn3ke_ethdev.c:(.text+0x7a2): undefined reference to `rte_eth_dev_get_by_name' collect2: error: ld returned 1 exit status [20/1511] Linking target drivers/librte_net_memif.so.22.1 FAILED: drivers/librte_net_memif.so.22.1 cc -o drivers/librte_net_memif.so.22.1 drivers/librte_net_memif.so.22.1.p/meson-generated_.._rte_net_memif.pmd.c.o drivers/libtmp_rte_net_memif.a.p/net_memif_memif_socket.c.o drivers/libtmp_rte_net_memif.a.p/net_memif_rte_eth_memif.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_memif.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 lib/librte_hash.so.22.1 lib/librte_rcu.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/memif/version.map drivers/libtmp_rte_net_memif.a.p/net_memif_rte_eth_memif.c.o: In function `memif_mp_send_region': rte_eth_memif.c:(.text+0x12ce): undefined reference to `rte_eth_dev_get_by_name' collect2: error: ld returned 1 exit status [21/1511] Compiling C object drivers/librte_net_pcap.a.p/meson-generated_.._rte_net_pcap.pmd.c.o [22/1511] Compiling C object drivers/librte_net_pfe.so.22.1.p/meson-generated_.._rte_net_pfe.pmd.c.o [23/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_dev.c.o [24/1511] Linking static target drivers/librte_net_octeontx_ep.a [25/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_int.c.o [26/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_l2.c.o [27/1511] Generating symbol file drivers/librte_bus_fslmc.so.22.1.p/librte_bus_fslmc.so.22.1.symbols [28/1511] Generating symbol file drivers/librte_bus_dpaa.so.22.1.p/librte_bus_dpaa.so.22.1.symbols [29/1511] Generating rte_net_ngbe.sym_chk with a custom command (wrapped by meson to capture output) [30/1511] Generating symbol file lib/librte_port.so.22.1.p/librte_port.so.22.1.symbols [31/1511] Generating rte_net_octeontx.sym_chk with a custom command (wrapped by meson to capture output) [32/1511] Generating symbol file drivers/librte_common_cnxk.so.22.1.p/librte_common_cnxk.so.22.1.symbols [33/1511] Generating rte_net_pfe.sym_chk with a custom command (wrapped by meson to capture output) [34/1511] Generating symbol file drivers/librte_common_sfc_efx.so.22.1.p/librte_common_sfc_efx.so.22.1.symbols [35/1511] Generating rte_net_null.sym_chk with a custom command (wrapped by meson to capture output) ninja: build stopped: subcommand failed. [-- Attachment #2: Type: text/html, Size: 8665 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v1] drivers/net: use internal API to get eth dev from name 2022-02-07 19:58 ` Owen Hilyard @ 2022-02-10 20:44 ` Yigit, Ferruh 2022-02-10 22:06 ` Owen Hilyard 0 siblings, 1 reply; 8+ messages in thread From: Yigit, Ferruh @ 2022-02-10 20:44 UTC (permalink / raw) To: Owen Hilyard Cc: Ali Alnubani, kumaraparameshwaran rathinavel, dev, dpdklab, Kumara Parameshwaran, ci, Aaron Conole [-- Attachment #1: Type: text/plain, Size: 9416 bytes --] Hi Owen, I can’t open the link. But it was initially applied to the main repo, later I manually re-run it on next-net. Compile error also verifies this [1], ‘rte_eth_dev_get_by_name()’ was added in next-net and missing in the main repo, error is related to API being missing. Anyway, if the latest script in the CI select ‘next-net’ tree for the patch, I think we are good. Can you please confirm this? [1] rte_eth_bond_api.c:(.text+0x12e6): undefined reference to `rte_eth_dev_get_by_name' From: Owen Hilyard <ohilyard@iol.unh.edu> Sent: Monday, February 7, 2022 7:59 PM To: Yigit, Ferruh <ferruh.yigit@intel.com> Cc: Ali Alnubani <alialnu@nvidia.com>; kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>; dev@dpdk.org; dpdklab <dpdklab@iol.unh.edu>; Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org; Aaron Conole <aconole@redhat.com> Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from name The Community CI hasn't been able to schedule downtime to update dpdk-ci across all of our systems since the refactoring Ali did. However, the patch was still applied on next-net and had a compilation error. See https://lab.dpdk.org/results/dashboard/patchsets/20895/. It was applied onto https://git.dpdk.org/next/dpdk-next-net/commit/?id=7445a787de053776616e41ab1d79090bd0f5ce33. Owen Here's the build log in case you were having issues seeing it: [1/1511] Compiling C object drivers/librte_net_null.so.22.1.p/meson-generated_.._rte_net_null.pmd.c.o [2/1511] Compiling C object drivers/librte_net_octeontx.so.22.1.p/meson-generated_.._rte_net_octeontx.pmd.c.o [3/1511] Compiling C object drivers/librte_net_null.a.p/meson-generated_.._rte_net_null.pmd.c.o [4/1511] Compiling C object drivers/librte_net_octeontx_ep.so.22.1.p/meson-generated_.._rte_net_octeontx_ep.pmd.c.o [5/1511] Compiling C object drivers/librte_net_octeontx.a.p/meson-generated_.._rte_net_octeontx.pmd.c.o [6/1511] Compiling C object drivers/librte_net_pcap.so.22.1.p/meson-generated_.._rte_net_pcap.pmd.c.o [7/1511] Compiling C object drivers/librte_net_pfe.a.p/meson-generated_.._rte_net_pfe.pmd.c.o [8/1511] Linking static target drivers/librte_net_null.a [9/1511] Linking static target drivers/librte_net_octeontx.a [10/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_init_ops.c.o [11/1511] Linking static target drivers/librte_net_pfe.a [12/1511] Linking target drivers/librte_net_mlx5.so.22.1 [13/1511] Linking target drivers/librte_common_sfc_efx.so.22.1 [14/1511] Linking target drivers/librte_common_cnxk.so.22.1 [15/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_hw.c.o [16/1511] Compiling C object drivers/librte_net_octeontx_ep.a.p/meson-generated_.._rte_net_octeontx_ep.pmd.c.o [17/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_init_fw_funcs.c.o [18/1511] Linking target drivers/librte_net_bond.so.22.1 FAILED: drivers/librte_net_bond.so.22.1 cc -o drivers/librte_net_bond.so.22.1 drivers/librte_net_bond.so.22.1.p/meson-generated_.._rte_net_bond.pmd.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_8023ad.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_alb.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_api.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_args.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_flow.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_pmd.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_bond.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 lib/librte_sched.so.22.1 lib/librte_ip_frag.so.22.1 lib/librte_hash.so.22.1 lib/librte_rcu.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/bonding/version.map drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_api.c.o: In function `rte_eth_bond_create': rte_eth_bond_api.c:(.text+0x12e6): undefined reference to `rte_eth_dev_get_by_name' collect2: error: ld returned 1 exit status [19/1511] Linking target drivers/librte_net_ipn3ke.so.22.1 FAILED: drivers/librte_net_ipn3ke.so.22.1 cc -o drivers/librte_net_ipn3ke.so.22.1 drivers/librte_net_ipn3ke.so.22.1.p/meson-generated_.._rte_net_ipn3ke.pmd.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_ethdev.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_flow.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_representor.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_tm.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_ipn3ke.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 drivers/librte_bus_ifpga.so.22.1 lib/librte_rawdev.so.22.1 lib/librte_sched.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/ipn3ke/version.map drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_ethdev.c.o: In function `ipn3ke_vswitch_probe': ipn3ke_ethdev.c:(.text+0x7a2): undefined reference to `rte_eth_dev_get_by_name' collect2: error: ld returned 1 exit status [20/1511] Linking target drivers/librte_net_memif.so.22.1 FAILED: drivers/librte_net_memif.so.22.1 cc -o drivers/librte_net_memif.so.22.1 drivers/librte_net_memif.so.22.1.p/meson-generated_.._rte_net_memif.pmd.c.o drivers/libtmp_rte_net_memif.a.p/net_memif_memif_socket.c.o drivers/libtmp_rte_net_memif.a.p/net_memif_rte_eth_memif.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_memif.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 lib/librte_hash.so.22.1 lib/librte_rcu.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/memif/version.map drivers/libtmp_rte_net_memif.a.p/net_memif_rte_eth_memif.c.o: In function `memif_mp_send_region': rte_eth_memif.c:(.text+0x12ce): undefined reference to `rte_eth_dev_get_by_name' collect2: error: ld returned 1 exit status [21/1511] Compiling C object drivers/librte_net_pcap.a.p/meson-generated_.._rte_net_pcap.pmd.c.o [22/1511] Compiling C object drivers/librte_net_pfe.so.22.1.p/meson-generated_.._rte_net_pfe.pmd.c.o [23/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_dev.c.o [24/1511] Linking static target drivers/librte_net_octeontx_ep.a [25/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_int.c.o [26/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_l2.c.o [27/1511] Generating symbol file drivers/librte_bus_fslmc.so.22.1.p/librte_bus_fslmc.so.22.1.symbols [28/1511] Generating symbol file drivers/librte_bus_dpaa.so.22.1.p/librte_bus_dpaa.so.22.1.symbols [29/1511] Generating rte_net_ngbe.sym_chk with a custom command (wrapped by meson to capture output) [30/1511] Generating symbol file lib/librte_port.so.22.1.p/librte_port.so.22.1.symbols [31/1511] Generating rte_net_octeontx.sym_chk with a custom command (wrapped by meson to capture output) [32/1511] Generating symbol file drivers/librte_common_cnxk.so.22.1.p/librte_common_cnxk.so.22.1.symbols [33/1511] Generating rte_net_pfe.sym_chk with a custom command (wrapped by meson to capture output) [34/1511] Generating symbol file drivers/librte_common_sfc_efx.so.22.1.p/librte_common_sfc_efx.so.22.1.symbols [35/1511] Generating rte_net_null.sym_chk with a custom command (wrapped by meson to capture output) ninja: build stopped: subcommand failed. [-- Attachment #2: Type: text/html, Size: 16061 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] drivers/net: use internal API to get eth dev from name 2022-02-10 20:44 ` Yigit, Ferruh @ 2022-02-10 22:06 ` Owen Hilyard 0 siblings, 0 replies; 8+ messages in thread From: Owen Hilyard @ 2022-02-10 22:06 UTC (permalink / raw) To: Yigit, Ferruh Cc: Ali Alnubani, kumaraparameshwaran rathinavel, dev, dpdklab, Kumara Parameshwaran, ci, Aaron Conole [-- Attachment #1: Type: text/plain, Size: 72 bytes --] The latest script in CI correctly selects 'next-net' for this patch. > [-- Attachment #2: Type: text/html, Size: 544 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-02-10 22:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220203082412.79028-1-kumaraparamesh92@gmail.com>
[not found] ` <CANxNyatu+tyqf1gyxM_1P_=oCyNiEOMdpbWSMLOnhgiffAnQGw@mail.gmail.com>
2022-02-03 11:31 ` [PATCH v1] drivers/net: use internal API to get eth dev from name Ferruh Yigit
2022-02-07 16:08 ` Ali Alnubani
2022-02-07 16:36 ` Ferruh Yigit
2022-02-07 16:47 ` Ali Alnubani
2022-02-07 17:25 ` Ferruh Yigit
2022-02-07 19:58 ` Owen Hilyard
2022-02-10 20:44 ` Yigit, Ferruh
2022-02-10 22:06 ` Owen Hilyard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).