From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68D41A0547 for ; Thu, 9 Sep 2021 10:31:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3713040041; Thu, 9 Sep 2021 10:31:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 763024003E for ; Thu, 9 Sep 2021 10:31:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631176284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uftEBiUuPhn+CNGYjDKRwJnpUy1PNq4nitM1EuMaTNg=; b=ik2mmkJhwU/mY2flD2YElrlq+rVNRPEz0NKJu5cs3tI2a0iQuQtvpgTZN1rgyhkOHVxKjf dTbxSd3QWHj3IwgZldU09cknGoChNKkknfmArQmTA4e/xY7EQrOiwpRFjQCrWXWlFQmWFy Xzgeh2YuB6yzzXELLGrnCg7HlvqE9q0= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-v8DP_DZNPcqIxu_zQs0m9g-1; Thu, 09 Sep 2021 04:31:21 -0400 X-MC-Unique: v8DP_DZNPcqIxu_zQs0m9g-1 Received: by mail-lf1-f69.google.com with SMTP id a23-20020a19fc17000000b003f0973fa819so370721lfi.11 for ; Thu, 09 Sep 2021 01:31:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uftEBiUuPhn+CNGYjDKRwJnpUy1PNq4nitM1EuMaTNg=; b=ZK9Mo0S4QQVkDh4+pQh2cLBvJXjXzM3LAPrlp6H2Hhowm17ccrioQWavh0eDg39+uP jYDYkdtc1q7wFueVp+cBccDEfIqkzoXIyM0rDg9tp4lOO55kVBVV59MCXOpc/Dy1d1Cp cWPhSwTl6Xqg3oixn0RKGaD3gJT5AkIc4BRpNO5KovGxiu7/TaRu7emELOFKK4maWJsY /j1fZ3dGuyszL4hlwmYVcxQOevVRVnDL34rHGg+IMVddaX46DdVUc3R5xaPWFoQ5Xgp7 VeR7e0Bp6Cx3smBB6PyVqz7+DCn+lHln5Smxbk6aM4GnvsDbGY2r/KUh7k9isjFOHw5R 9JKA== X-Gm-Message-State: AOAM532aK3+Z1okR83/SuLrhm9dpnPM8xsPzbpZZiZymOymVjMzEzKQL yqpvuXbzWJLpoOeZU2lVDoNSycODOz8wsaCpsSReyqGuOKJOh9BiCfCFioFx+Dy+58lWNLNR1Zk ArY5Nd8jHnuGjOzmptA== X-Received: by 2002:a05:6512:d2:: with SMTP id c18mr1501317lfp.484.1631176280047; Thu, 09 Sep 2021 01:31:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIV8shT66oFpR0MRAHp9OI7bmL4iVDglRxP9a4Dja1I6sYnUM/OVBD/kr99x51yvhgDZ04hXXggJcJIlWsXj0= X-Received: by 2002:a05:6512:d2:: with SMTP id c18mr1501308lfp.484.1631176279843; Thu, 09 Sep 2021 01:31:19 -0700 (PDT) MIME-Version: 1.0 References: <20210908151936.5556-1-alialnu@nvidia.com> In-Reply-To: <20210908151936.5556-1-alialnu@nvidia.com> From: David Marchand Date: Thu, 9 Sep 2021 10:31:08 +0200 Message-ID: To: Ali Alnubani Cc: ci@dpdk.org, Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" On Wed, Sep 8, 2021 at 5:19 PM Ali Alnubani wrote: > > The unit test check_release_notes was failing because it didn't > find some of the DPDK sources, which has been causing the CI > script checkpatch.sh to sometimes report false positives. > > Signed-off-by: Ali Alnubani > --- > tests/checkpatch.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/checkpatch.sh b/tests/checkpatch.sh > index 0ce5414..2034e32 100755 > --- a/tests/checkpatch.sh > +++ b/tests/checkpatch.sh > @@ -43,7 +43,7 @@ if echo $subject | grep -qi 'v[2-9].*\]' && [ -z "$reply" ] ; then > replyto_msg='Must be a reply to the first patch (--in-reply-to).\n\n' > fi > > -report=$($dpdkdir/devtools/checkpatches.sh -q $email) || failed=true > +report=$(cd $dpdkdir && devtools/checkpatches.sh -q $email) || failed=true > report=$(echo "$report" | sed '1,/^###/d') > > label='checkpatch' I did not find the time to investigate those false positives, thanks for the fix. Just summarizing the chat I add with Thomas. We could fix the checkpatches.sh script in dpdk so that it looks for the VERSION file relatively to the script location. But it would remove the possibility to call devtools/checkpatches.sh from a different working directory. Whether this is a valid usecase is unclear, but we don't know what other users of this script might be doing. Your fix is simple enough and I don't see side effect. Acked-by: David Marchand -- David Marchand