* [dpdk-ci] SPDK compilation issue @ 2020-11-17 7:35 David Marchand 2020-11-17 13:22 ` Lincoln Lavoie 0 siblings, 1 reply; 12+ messages in thread From: David Marchand @ 2020-11-17 7:35 UTC (permalink / raw) To: Lincoln Lavoie, dpdklab; +Cc: Thomas Monjalon, ci Hello, The SPDK job started failing following EAL changes. I proposed a fix to SPDK https://review.spdk.io/gerrit/c/spdk/spdk/+/5116. Not sure when it will be merged/fixed (first time submission for me). For now, I'll ignore failure reports for this job. If it gets too long to be fixed in SPDK, we might want to disable the job. -- David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] SPDK compilation issue 2020-11-17 7:35 [dpdk-ci] SPDK compilation issue David Marchand @ 2020-11-17 13:22 ` Lincoln Lavoie 2020-11-17 13:44 ` Zawadzki, Tomasz 0 siblings, 1 reply; 12+ messages in thread From: Lincoln Lavoie @ 2020-11-17 13:22 UTC (permalink / raw) To: David Marchand, tomasz.zawadzki; +Cc: dpdklab, Thomas Monjalon, ci [-- Attachment #1: Type: text/plain, Size: 859 bytes --] HI David, Looping in Tomasz, who's been our primary contact on the SPDK side of things. I know Brandon just updated the SPDK test to pull from their latest LTS release from October. Cheers, Lincoln On Tue, Nov 17, 2020 at 2:35 AM David Marchand <david.marchand@redhat.com> wrote: > Hello, > > The SPDK job started failing following EAL changes. > > I proposed a fix to SPDK https://review.spdk.io/gerrit/c/spdk/spdk/+/5116. > Not sure when it will be merged/fixed (first time submission for me). > > For now, I'll ignore failure reports for this job. > If it gets too long to be fixed in SPDK, we might want to disable the job. > > > -- > David Marchand > > -- *Lincoln Lavoie* Senior Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m) <https://www.iol.unh.edu> [-- Attachment #2: Type: text/html, Size: 2260 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] SPDK compilation issue 2020-11-17 13:22 ` Lincoln Lavoie @ 2020-11-17 13:44 ` Zawadzki, Tomasz 2020-11-17 13:59 ` David Marchand 0 siblings, 1 reply; 12+ messages in thread From: Zawadzki, Tomasz @ 2020-11-17 13:44 UTC (permalink / raw) To: Lincoln Lavoie, David Marchand; +Cc: dpdklab, Thomas Monjalon, ci [-- Attachment #1.1: Type: text/plain, Size: 1436 bytes --] Hi David, Lincoln, Thank you for bringing this up. We’ll make sure to get this merged to latest SPDK and v20.10.x branch that is used for DPDK testing. Thanks, Tomek From: Lincoln Lavoie <lylavoie@iol.unh.edu> Sent: Tuesday, November 17, 2020 2:23 PM To: David Marchand <david.marchand@redhat.com>; Zawadzki, Tomasz <tomasz.zawadzki@intel.com> Cc: dpdklab <dpdklab@iol.unh.edu>; Thomas Monjalon <thomas@monjalon.net>; ci@dpdk.org Subject: Re: SPDK compilation issue HI David, Looping in Tomasz, who's been our primary contact on the SPDK side of things. I know Brandon just updated the SPDK test to pull from their latest LTS release from October. Cheers, Lincoln On Tue, Nov 17, 2020 at 2:35 AM David Marchand <david.marchand@redhat.com<mailto:david.marchand@redhat.com>> wrote: Hello, The SPDK job started failing following EAL changes. I proposed a fix to SPDK https://review.spdk.io/gerrit/c/spdk/spdk/+/5116. Not sure when it will be merged/fixed (first time submission for me). For now, I'll ignore failure reports for this job. If it gets too long to be fixed in SPDK, we might want to disable the job. -- David Marchand -- Lincoln Lavoie Senior Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu> https://www.iol.unh.edu +1-603-674-2755 (m) [Image removed by sender.]<https://www.iol.unh.edu> [-- Attachment #1.2: Type: text/html, Size: 5693 bytes --] [-- Attachment #2: image001.jpg --] [-- Type: image/jpeg, Size: 588 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] SPDK compilation issue 2020-11-17 13:44 ` Zawadzki, Tomasz @ 2020-11-17 13:59 ` David Marchand 2020-11-18 8:36 ` Zawadzki, Tomasz 0 siblings, 1 reply; 12+ messages in thread From: David Marchand @ 2020-11-17 13:59 UTC (permalink / raw) To: Zawadzki, Tomasz; +Cc: Lincoln Lavoie, dpdklab, Thomas Monjalon, ci On Tue, Nov 17, 2020 at 2:45 PM Zawadzki, Tomasz <tomasz.zawadzki@intel.com> wrote: > > Hi David, Lincoln, > > Thank you for bringing this up. We’ll make sure to get this merged to latest SPDK and v20.10.x branch that is used for DPDK testing. Cool, and thanks for the review. -- David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] SPDK compilation issue 2020-11-17 13:59 ` David Marchand @ 2020-11-18 8:36 ` Zawadzki, Tomasz 2020-11-18 9:32 ` David Marchand 0 siblings, 1 reply; 12+ messages in thread From: Zawadzki, Tomasz @ 2020-11-18 8:36 UTC (permalink / raw) To: David Marchand; +Cc: Lincoln Lavoie, dpdklab, Thomas Monjalon, ci Hi David, The change is now integrated into SPDK. Checking out branch v20.10.x will allow to resume SPDK job at UNH. Thanks, Tomek > -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Tuesday, November 17, 2020 2:59 PM > To: Zawadzki, Tomasz <tomasz.zawadzki@intel.com> > Cc: Lincoln Lavoie <lylavoie@iol.unh.edu>; dpdklab <dpdklab@iol.unh.edu>; > Thomas Monjalon <thomas@monjalon.net>; ci@dpdk.org > Subject: Re: [dpdk-ci] SPDK compilation issue > > On Tue, Nov 17, 2020 at 2:45 PM Zawadzki, Tomasz > <tomasz.zawadzki@intel.com> wrote: > > > > Hi David, Lincoln, > > > > Thank you for bringing this up. We’ll make sure to get this merged to latest > SPDK and v20.10.x branch that is used for DPDK testing. > > Cool, and thanks for the review. > > > -- > David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] SPDK compilation issue 2020-11-18 8:36 ` Zawadzki, Tomasz @ 2020-11-18 9:32 ` David Marchand 2020-11-18 14:07 ` [dpdk-ci] [dpdklab] " Lincoln Lavoie 0 siblings, 1 reply; 12+ messages in thread From: David Marchand @ 2020-11-18 9:32 UTC (permalink / raw) To: Zawadzki, Tomasz, Lincoln Lavoie; +Cc: dpdklab, Thomas Monjalon, ci Hello, On Wed, Nov 18, 2020 at 9:36 AM Zawadzki, Tomasz <tomasz.zawadzki@intel.com> wrote: > > Hi David, > > The change is now integrated into SPDK. Checking out branch v20.10.x will allow to resume SPDK job at UNH. Thanks Tomasz! Lincoln, Do you know when this change will be picked up by the UNH job? -- David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] [dpdklab] Re: SPDK compilation issue 2020-11-18 9:32 ` David Marchand @ 2020-11-18 14:07 ` Lincoln Lavoie 2020-11-18 15:56 ` Brandon Lo 0 siblings, 1 reply; 12+ messages in thread From: Lincoln Lavoie @ 2020-11-18 14:07 UTC (permalink / raw) To: David Marchand; +Cc: Zawadzki, Tomasz, dpdklab, Thomas Monjalon, ci [-- Attachment #1: Type: text/plain, Size: 946 bytes --] Hi David, Let me check with Brandon. I believe it should pick it up, but I'm not 100% sure. We generally don't track the downstream branches as closely because the goal is testing DPDK patches with a "stable" system, i.e. not having a patch on SDPK testing cause a failure on DPDK CI. Cheers, Lincoln On Wed, Nov 18, 2020 at 4:32 AM David Marchand <david.marchand@redhat.com> wrote: > Hello, > > On Wed, Nov 18, 2020 at 9:36 AM Zawadzki, Tomasz > <tomasz.zawadzki@intel.com> wrote: > > > > Hi David, > > > > The change is now integrated into SPDK. Checking out branch v20.10.x > will allow to resume SPDK job at UNH. > > Thanks Tomasz! > > Lincoln, > Do you know when this change will be picked up by the UNH job? > > > -- > David Marchand > > -- *Lincoln Lavoie* Senior Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m) <https://www.iol.unh.edu> [-- Attachment #2: Type: text/html, Size: 2303 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] [dpdklab] Re: SPDK compilation issue 2020-11-18 14:07 ` [dpdk-ci] [dpdklab] " Lincoln Lavoie @ 2020-11-18 15:56 ` Brandon Lo 2020-11-18 18:26 ` David Marchand 0 siblings, 1 reply; 12+ messages in thread From: Brandon Lo @ 2020-11-18 15:56 UTC (permalink / raw) To: Lincoln Lavoie Cc: David Marchand, Zawadzki, Tomasz, dpdklab, Thomas Monjalon, ci [-- Attachment #1: Type: text/plain, Size: 1805 bytes --] Hi everyone, The SPDK compile job pulls from the LTS branch before every SPDK compile test. I have checked the local repository and it currently shows that it did pick up the commit 'a73286870ebf189629937515bd28714937f2498b: env_dpdk/pci: adapt to 20.11 EAL changes' Looking at the logs, I can see the changes have taken place. However, the error/warning messages are the same, and they highlight the lines that have already been changed. This issue persists after clearing the cache and rebuilding the container used to compile. Has anyone had an issue like this before? Thanks, Brandon On Wed, Nov 18, 2020 at 9:09 AM Lincoln Lavoie <lylavoie@iol.unh.edu> wrote: > Hi David, > > Let me check with Brandon. I believe it should pick it up, but I'm not > 100% sure. We generally don't track the downstream branches as closely > because the goal is testing DPDK patches with a "stable" system, i.e. not > having a patch on SDPK testing cause a failure on DPDK CI. > > Cheers, > Lincoln > > On Wed, Nov 18, 2020 at 4:32 AM David Marchand <david.marchand@redhat.com> > wrote: > >> Hello, >> >> On Wed, Nov 18, 2020 at 9:36 AM Zawadzki, Tomasz >> <tomasz.zawadzki@intel.com> wrote: >> > >> > Hi David, >> > >> > The change is now integrated into SPDK. Checking out branch v20.10.x >> will allow to resume SPDK job at UNH. >> >> Thanks Tomasz! >> >> Lincoln, >> Do you know when this change will be picked up by the UNH job? >> >> >> -- >> David Marchand >> >> > > -- > *Lincoln Lavoie* > Senior Engineer, Broadband Technologies > 21 Madbury Rd., Ste. 100, Durham, NH 03824 > lylavoie@iol.unh.edu > https://www.iol.unh.edu > +1-603-674-2755 (m) > <https://www.iol.unh.edu> > -- Brandon Lo UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu www.iol.unh.edu [-- Attachment #2: Type: text/html, Size: 4830 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] [dpdklab] Re: SPDK compilation issue 2020-11-18 15:56 ` Brandon Lo @ 2020-11-18 18:26 ` David Marchand 2020-11-18 18:36 ` David Marchand 0 siblings, 1 reply; 12+ messages in thread From: David Marchand @ 2020-11-18 18:26 UTC (permalink / raw) To: Brandon Lo; +Cc: Lincoln Lavoie, Zawadzki, Tomasz, dpdklab, Thomas Monjalon, ci On Wed, Nov 18, 2020 at 4:57 PM Brandon Lo <blo@iol.unh.edu> wrote: > The SPDK compile job pulls from the LTS branch before every SPDK compile test. > I have checked the local repository and it currently shows that it did pick up the commit 'a73286870ebf189629937515bd28714937f2498b: env_dpdk/pci: adapt to 20.11 EAL changes' > > Looking at the logs, I can see the changes have taken place. However, the error/warning messages are the same, and they highlight the lines that have already been changed. > This issue persists after clearing the cache and rebuilding the container used to compile. Has anyone had an issue like this before? > Do you mean that this job in a container is compiling the SPDK sources before my change, or with my change? -- David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] [dpdklab] Re: SPDK compilation issue 2020-11-18 18:26 ` David Marchand @ 2020-11-18 18:36 ` David Marchand 2020-11-19 8:37 ` David Marchand 0 siblings, 1 reply; 12+ messages in thread From: David Marchand @ 2020-11-18 18:36 UTC (permalink / raw) To: Brandon Lo; +Cc: Lincoln Lavoie, Zawadzki, Tomasz, dpdklab, Thomas Monjalon, ci On Wed, Nov 18, 2020 at 7:26 PM David Marchand <david.marchand@redhat.com> wrote: > > On Wed, Nov 18, 2020 at 4:57 PM Brandon Lo <blo@iol.unh.edu> wrote: > > The SPDK compile job pulls from the LTS branch before every SPDK compile test. > > I have checked the local repository and it currently shows that it did pick up the commit 'a73286870ebf189629937515bd28714937f2498b: env_dpdk/pci: adapt to 20.11 EAL changes' > > > > Looking at the logs, I can see the changes have taken place. However, the error/warning messages are the same, and they highlight the lines that have already been changed. > > This issue persists after clearing the cache and rebuilding the container used to compile. Has anyone had an issue like this before? > > > > Do you mean that this job in a container is compiling the SPDK sources > before my change, or with my change? Ok, this is my fault. I just don't understand how it passed my test... so I'll have to double check my setup when compiling SPDK. And I'll submit an additional fix to SPDK tomorrow. -- David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] [dpdklab] Re: SPDK compilation issue 2020-11-18 18:36 ` David Marchand @ 2020-11-19 8:37 ` David Marchand 2020-11-24 11:05 ` David Marchand 0 siblings, 1 reply; 12+ messages in thread From: David Marchand @ 2020-11-19 8:37 UTC (permalink / raw) To: Brandon Lo, Zawadzki, Tomasz; +Cc: Lincoln Lavoie, dpdklab, Thomas Monjalon, ci On Wed, Nov 18, 2020 at 7:36 PM David Marchand <david.marchand@redhat.com> wrote: > I just don't understand how it passed my test... so I'll have to > double check my setup when compiling SPDK. I was still pointing at a 20.08 installation directory (forgot to call ninja install after switching to dpdk main branch and rebuilding). The fix is ready and tested, sent to review. -- David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-ci] [dpdklab] Re: SPDK compilation issue 2020-11-19 8:37 ` David Marchand @ 2020-11-24 11:05 ` David Marchand 0 siblings, 0 replies; 12+ messages in thread From: David Marchand @ 2020-11-24 11:05 UTC (permalink / raw) To: Brandon Lo, Zawadzki, Tomasz; +Cc: Lincoln Lavoie, dpdklab, Thomas Monjalon, ci On Thu, Nov 19, 2020 at 9:37 AM David Marchand <david.marchand@redhat.com> wrote: > > On Wed, Nov 18, 2020 at 7:36 PM David Marchand > <david.marchand@redhat.com> wrote: > > I just don't understand how it passed my test... so I'll have to > > double check my setup when compiling SPDK. > > I was still pointing at a 20.08 installation directory (forgot to call > ninja install after switching to dpdk main branch and rebuilding). > The fix is ready and tested, sent to review. The fix landed in the v20.10.x branch this morning (Thanks Tomasz!). And I can see that jobs posted after are now fine with the spdk job. So we are good now. -- David Marchand ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-11-24 11:05 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-17 7:35 [dpdk-ci] SPDK compilation issue David Marchand 2020-11-17 13:22 ` Lincoln Lavoie 2020-11-17 13:44 ` Zawadzki, Tomasz 2020-11-17 13:59 ` David Marchand 2020-11-18 8:36 ` Zawadzki, Tomasz 2020-11-18 9:32 ` David Marchand 2020-11-18 14:07 ` [dpdk-ci] [dpdklab] " Lincoln Lavoie 2020-11-18 15:56 ` Brandon Lo 2020-11-18 18:26 ` David Marchand 2020-11-18 18:36 ` David Marchand 2020-11-19 8:37 ` David Marchand 2020-11-24 11:05 ` David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).