DPDK CI discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Liu, Changpeng" <changpeng.liu@intel.com>,
	 Thomas Monjalon <thomas@monjalon.net>,
	Aaron Conole <aconole@redhat.com>, dpdklab <dpdklab@iol.unh.edu>,
	ci@dpdk.org
Subject: Re: [dpdk-ci] [PATCH] vhost: rename driver callbacks struct
Date: Wed, 3 Nov 2021 09:36:26 +0100	[thread overview]
Message-ID: <CAJFAV8wi6Hx-JLedinM7U+=oe_1N3Wjf=Wj38suyEjbL+o+t1Q@mail.gmail.com> (raw)
In-Reply-To: <SN6PR11MB35040942741F6318830526549C8C9@SN6PR11MB3504.namprd11.prod.outlook.com>

On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> Testing issues reported in patchwork is expected as SPDK uses
> this struct, so we can ignore it as SPDK will rename it when it
> adapts to DPDK 21.11

Please, no.
We can't simply say "ignore failure in CI".

The SPDK build test must be disabled in CI first.
You can create a bugzilla and assign it to UNH lab.
Example: https://bugs.dpdk.org/show_bug.cgi?id=579

Once done, we can merge this patch in DPDK.


In parallel, either prepare the patch or talk to SPDK guys to handle
this change.
Once this is done, update the bugzilla so that we can get SPDK build
tested again in CI.

Thanks.


-- 
David Marchand


       reply	other threads:[~2021-11-03  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211102104748.57078-1-maxime.coquelin@redhat.com>
     [not found] ` <SN6PR11MB35040942741F6318830526549C8C9@SN6PR11MB3504.namprd11.prod.outlook.com>
2021-11-03  8:36   ` David Marchand [this message]
2021-11-03  8:38     ` Maxime Coquelin
2021-11-03  9:52       ` Maxime Coquelin
2021-11-03 13:11         ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
2021-11-03 13:16           ` Maxime Coquelin
2021-11-03 14:38             ` Lincoln Lavoie
2021-11-03  9:10     ` [dpdk-ci] " Xia, Chenbo
2021-11-04  2:48       ` Liu, Changpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wi6Hx-JLedinM7U+=oe_1N3Wjf=Wj38suyEjbL+o+t1Q@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=aconole@redhat.com \
    --cc=changpeng.liu@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=ci@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=maxime.coquelin@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).