DPDK CI discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dpdklab@iol.unh.edu, Lincoln Lavoie <lylavoie@iol.unh.edu>
Cc: ci@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	 Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-ci] Compiling dpdk in non compilation tests
Date: Sun, 25 Oct 2020 09:35:38 +0100	[thread overview]
Message-ID: <CAJFAV8wo0C8RwMpTqYNrthb9fzkh5G0MBH+L9j-y+RnG3Bvzsw@mail.gmail.com> (raw)

Looking at CI reports this morning, I noticed this on the series "ice:
update base code".

https://lab.dpdk.org/results/dashboard/patchsets/13992/

- Compilation is failing on OpenSuse, but I think this is because its
toolchain does not have AVX512 support.
This seems to be a regression introduced by the series, indeed, cool.


- On Ubuntu 18.04, build is fine, but unit tests are ko.
Looking into the unit tests zipped logs, I can see that:
* the unit tests job builds its own binaries,
* the unit tests environment is not the same as the build test
environment (only copying significant differences below):

Build:
The Meson build system
Version: 0.55.3
...
C compiler for the host machine: cc (gcc 7.5.0 "cc (Ubuntu
7.5.0-3ubuntu1~18.04) 7.5.0")
C linker for the host machine: cc ld.bfd 2.30
...
Run-time dependency libpcap found: YES 1.8.1
Has header "pcap.h" with dependency libpcap: YES
...
Fetching value of define "__AVX2__" : 1
Fetching value of define "__AVX512BW__" : 1
Fetching value of define "__AVX512CD__" : 1
Fetching value of define "__AVX512DQ__" : 1
Fetching value of define "__AVX512F__" : 1
Fetching value of define "__AVX512VL__" : 1
...
Run-time dependency jansson found: YES 2.11
...

vs

Unit tests:
The Meson build system
Version: 0.53.1
...
C compiler for the host machine: cc (gcc 7.5.0 "cc (Ubuntu
7.5.0-3ubuntu1~18.04) 7.5.0")
C linker for the host machine: cc GNU ld.bfd 2.30
...
Run-time dependency libpcap found: NO (tried pkgconfig)
Library pcap found: NO
...
Fetching value of define "__AVX2__" :
Fetching value of define "__AVX512BW__" :
Fetching value of define "__AVX512CD__" :
Fetching value of define "__AVX512DQ__" :
Fetching value of define "__AVX512F__" :
Fetching value of define "__AVX512VL__" :
...
Run-time dependency jansson found: NO (tried pkgconfig and cmake)
...


The Unit tests env does not have a AVX512 enabled toolchain, or
something in meson disables it, hence the compilation fails and the
unit tests are marked as failed while it has nothing to do with
functional tests.


Please rework the CI pipeline so that the Unit tests job only does
functional tests, while binaries are built by the Build test job.


Thanks.

-- 
David Marchand


             reply	other threads:[~2020-10-25  8:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-25  8:35 David Marchand [this message]
2020-10-27  9:17 ` Richardson, Bruce
2020-10-27 13:41   ` [dpdk-ci] [dpdklab] " Brandon Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wo0C8RwMpTqYNrthb9fzkh5G0MBH+L9j-y+RnG3Bvzsw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=ci@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=lylavoie@iol.unh.edu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).