From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B41943B79; Thu, 7 Mar 2024 08:57:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14D0F40A6D; Thu, 7 Mar 2024 08:57:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 65F2D402F2 for ; Thu, 7 Mar 2024 08:56:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709798217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RqCC4mUN+s+HP+KxdGjrTJqY0w8RWIz3FumgSePTIJk=; b=cmqNaNdb8b1IHQNfvsFM+blMr/puX5Jx7NajiEE2U31v3Hu91CCh/jrO8aJ/5xLhxQ+BAv AvH58ql8diWcwn2lYhZcfB76rxv9vAydBxr6OlweYz6qavWwfR3N5D4qnxiNVtv/kd45fR DkBtP8yb+txkhMh9zoODJP8eZQALcRU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-lJH2sKnVOxCbvfLh-s2lgQ-1; Thu, 07 Mar 2024 02:56:55 -0500 X-MC-Unique: lJH2sKnVOxCbvfLh-s2lgQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d359de20dcso2835331fa.1 for ; Wed, 06 Mar 2024 23:56:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709798214; x=1710403014; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RqCC4mUN+s+HP+KxdGjrTJqY0w8RWIz3FumgSePTIJk=; b=G9apaqbbaQqW+OtP+ra4sehx2i77Hz7hXGo7egrzRlgeFasm3kdDu7h68aq3+L+y5i IDhw6W9+KJP1a+Ay3B2XpcNk0KEmcno4u/Ya0pRokOJ/zZYgSEuYFXEdxi/QWcPriv/4 kx/4B8TV6pui7ylCyzI1hwOiVK7wxLYwu8gQpOEvO94VfWMt70KleDHdyMuZ9rfJtO2u DIjXfsPRrvsHw1G46qeY3jqkq2jgJjtWjci+JRTxU/n3vPQXxE1WPSsVuQhX7ZwPYMAu cJMKASegvJtkU3eAArn+0wgtFsuIE59vYLSJH/N8vf/+tL2ERjPmX2OyC9ZgF6fp49ds DfoA== X-Forwarded-Encrypted: i=1; AJvYcCVF6a/hgSERgMOP186hE3Ehze/thwfSJpsZBEwCjQv2FjJQbNcItwmRzoC5HM5AKH8fQnd4x+vWkXuOjg== X-Gm-Message-State: AOJu0YzhbKXzq+4trj29tZRzb5Be5pbIk5HOhEz44puF5jL9gx+uwFiA svE10RYpPPzk0sHr58qZu7ycLis+PHSCYy6lM0VJYA1Omn/rxo8nM5MDV1hXotkIAxSRerJ12Wd fzZDaQROyqUAFwKGnQD3NS4YangnbzZK0Eu36koierjczTIAJFyoTWRK+azssJBYL604lF10LHI r+KBcbBJoTyjhqxw== X-Received: by 2002:a2e:a413:0:b0:2d2:e82e:75f6 with SMTP id p19-20020a2ea413000000b002d2e82e75f6mr847695ljn.44.1709798214272; Wed, 06 Mar 2024 23:56:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwzRYXSsjs/kksYlGuOrf4OXda3GG5axFweWqla6j5nxxmJXoc4EXgHIQcWdot7tLafcGxWUCiInCGccFXLy8= X-Received: by 2002:a2e:a413:0:b0:2d2:e82e:75f6 with SMTP id p19-20020a2ea413000000b002d2e82e75f6mr847682ljn.44.1709798213819; Wed, 06 Mar 2024 23:56:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Thu, 7 Mar 2024 08:56:41 +0100 Message-ID: Subject: Re: Intel QAT 8970 accel card on ARM Ampere Server To: Patrick Robb Cc: Honnappa Nagarahalli , Ruifeng Wang , =?UTF-8?Q?Juraj_Linke=C5=A1?= , Dharmik Jayesh Thakkar , "ci@dpdk.org" , nd , Wathsala Wathawana Vithanage , Paul Szczepanek , Dhruv Tripathi X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Hello Patrick, On Thu, Mar 7, 2024 at 6:27=E2=80=AFAM Patrick Robb wro= te: > 1. As Dharmik and David discussed, there are some QAT devices that > need VFIO denylist=3D1. To account for this, in cryptodev_common.py > (which the crypto perf testsuite imports), we need to add: > > given the c62x device id is 37c8 > > if dev_id in ["37c8", "435", "19e2"]: > test_case.dut.send_expect('modprobe -r vfio_iommu_type1; modprobe > -r vfio_pci; modprobe -r vfio_virqfd; modprobe -r vfio', '# ', 5) > test_case.dut.send_expect('modprobe vfio-pci disable_denylist=3D1 > enable_sriov=3D1 vfio-pci.ids=3D8086:37c9', '# ', 5) > test_case.dut.send_expect('echo "1" | tee > /sys/module/vfio/parameters/enable_unsafe_noiommu_mode', '# ', 5) > > In order to maintain the custom vfio loading Dharmik recommended. The > latter two dev ids in that list are for DH895XCC and C3XXX, since they > are also included in > https://github.com/torvalds/linux/commit/50173329c8cc0c892eaa7a9d0f0692ac= 39cd7b04 > > David and Dharmik, I think this is correct, but please chime in if it isn= 't. You probably missed one question I had, mixed with my grmbl about disable_denylist. """ However, I don't think the vfio-pci.ids syntax works for passing parameters= . And in any case, why do you need to set this initial list? Binding devices (using either driverctl or dpdk-devbind.py) to vfio-pci should be done the "usual" way, or is there some special case again for QAT? """ Re-reading vfio-pci kernel parsing code, the syntax for vfio-pci.ids seems ok, my bad. But I am still not clear if there is a need for a special case here. bind_qat_device() calls test_case.dut.bind_eventdev_port which itself calls dpdk-devbind to bind the VF to vfio-pci. So here, on the topic of loading vfio-pci wrt the QAT quirk, you only need: # modprobe vfio-pci disable_denylist=3D1 enable_sriov=3D1 --=20 David Marchand