[PATCH] Increasing ci meson version to .57

[PATCH] Increasing ci meson version to .57

[Patrick Robb]

There is a proposed increase in the minimum meson version to .57
This patch aligns the linux setup ci script with this change.

Signed-off-by: Patrick Robb <probb@iol.unh.edu>
---
 .ci/linux-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
index 975bf32144..c7b6a86d38 100755
--- a/.ci/linux-setup.sh
+++ b/.ci/linux-setup.sh
@@ -4,7 +4,7 @@
 [ "$(id -u)" != '0' ] || alias sudo=
 
 # need to install as 'root' since some of the unit tests won't run without it
-sudo python3 -m pip install --upgrade 'meson==0.53.2'
+sudo python3 -m pip install --upgrade 'meson==0.57'
 
 # setup hugepages. error ignored because having hugepage is not mandatory.
 cat /proc/meminfo
-- 
2.46.1

Re: [PATCH] Increasing ci meson version to .57

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

Oh, I guess I should have mentioned that I did "test" this for good
measure, by spinning up a base ubuntu 20.04 container, running the
linux-setup.sh with this change, and did a dpdk build.

Tested-by: Patrick Robb <probb@iol.unh.edu>

On Tue, Oct 8, 2024 at 3:27 PM Patrick Robb <probb@iol.unh.edu> wrote:

> There is a proposed increase in the minimum meson version to .57
> This patch aligns the linux setup ci script with this change.
>
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> ---
>  .ci/linux-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
> index 975bf32144..c7b6a86d38 100755
> --- a/.ci/linux-setup.sh
> +++ b/.ci/linux-setup.sh
> @@ -4,7 +4,7 @@
>  [ "$(id -u)" != '0' ] || alias sudo=
>
>  # need to install as 'root' since some of the unit tests won't run
> without it
> -sudo python3 -m pip install --upgrade 'meson==0.53.2'
> +sudo python3 -m pip install --upgrade 'meson==0.57'
>
>  # setup hugepages. error ignored because having hugepage is not mandatory.
>  cat /proc/meminfo
> --
> 2.46.1
>
>

[-- Attachment #2: Type: text/html, Size: 1645 bytes --]

Re: [PATCH] Increasing ci meson version to .57

[Bruce Richardson]

On Tue, Oct 08, 2024 at 03:25:43PM -0400, Patrick Robb wrote:
> There is a proposed increase in the minimum meson version to .57
> This patch aligns the linux setup ci script with this change.
> 
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> ---
>  .ci/linux-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
> index 975bf32144..c7b6a86d38 100755
> --- a/.ci/linux-setup.sh
> +++ b/.ci/linux-setup.sh
> @@ -4,7 +4,7 @@
>  [ "$(id -u)" != '0' ] || alias sudo=
>  
>  # need to install as 'root' since some of the unit tests won't run without it
> -sudo python3 -m pip install --upgrade 'meson==0.53.2'
> +sudo python3 -m pip install --upgrade 'meson==0.57'
>  

This change should be already covered in [1].

Regards,
/Bruce

[1] https://patches.dpdk.org/project/dpdk/patch/20240920125737.1197969-2-bruce.richardson@intel.com/

Re: [PATCH] Increasing ci meson version to .57

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 56 bytes --]

Haha... I guess that serves as a lesson.

Thanks Bruce.

[-- Attachment #2: Type: text/html, Size: 101 bytes --]

Re: [PATCH] Increasing ci meson version to .57

[Aaron Conole]

Patrick Robb <probb@iol.unh.edu> writes:

> Haha... I guess that serves as a lesson.
>
> Thanks Bruce.

Probably worth it to try that patch out and add your tested-by tag :)

Re: [PATCH] Increasing ci meson version to .57

[Stephen Hemminger]

On Tue,  8 Oct 2024 15:25:43 -0400
Patrick Robb <probb@iol.unh.edu> wrote:

> There is a proposed increase in the minimum meson version to .57
> This patch aligns the linux setup ci script with this change.
> 
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>

I wonder if we shouldn't push it to something later.
Debian stable is using 1.0.1 and testing is up to 1.5.2

0.57.0 was released on Feb 14,2021
1.0.0 was released on Dec 23, 2022

So getting a release that was more recent makes sense.
The users stuck on enterprise distro's are going to have to resort
to pip anyway to get a new version.

Re: [PATCH] Increasing ci meson version to .57

[David Marchand]

On Wed, Oct 9, 2024 at 5:43 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue,  8 Oct 2024 15:25:43 -0400
> Patrick Robb <probb@iol.unh.edu> wrote:
>
> > There is a proposed increase in the minimum meson version to .57
> > This patch aligns the linux setup ci script with this change.
> >
> > Signed-off-by: Patrick Robb <probb@iol.unh.edu>
>
> I wonder if we shouldn't push it to something later.
> Debian stable is using 1.0.1 and testing is up to 1.5.2
>
> 0.57.0 was released on Feb 14,2021
> 1.0.0 was released on Dec 23, 2022
>
> So getting a release that was more recent makes sense.
> The users stuck on enterprise distro's are going to have to resort
> to pip anyway to get a new version.

Tyler reported an issue for Windows with meson > 0.57.
https://inbox.dpdk.org/dev/ZvuoUizQiDeE62zB@bricha3-mobl1.ger.corp.intel.com/


-- 
David Marchand

Re: [PATCH] Increasing ci meson version to .57

[Bruce Richardson]

On Wed, Oct 09, 2024 at 09:47:12AM +0200, David Marchand wrote:
> On Wed, Oct 9, 2024 at 5:43 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Tue,  8 Oct 2024 15:25:43 -0400
> > Patrick Robb <probb@iol.unh.edu> wrote:
> >
> > > There is a proposed increase in the minimum meson version to .57
> > > This patch aligns the linux setup ci script with this change.
> > >
> > > Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> >
> > I wonder if we shouldn't push it to something later.
> > Debian stable is using 1.0.1 and testing is up to 1.5.2
> >
> > 0.57.0 was released on Feb 14,2021
> > 1.0.0 was released on Dec 23, 2022
> >
> > So getting a release that was more recent makes sense.
> > The users stuck on enterprise distro's are going to have to resort
> > to pip anyway to get a new version.
> 
> Tyler reported an issue for Windows with meson > 0.57.
> https://inbox.dpdk.org/dev/ZvuoUizQiDeE62zB@bricha3-mobl1.ger.corp.intel.com/
> 
Yes, this was a factor in choosing 0.57.
The other is that this is just a minimum version, so if distros are
shipping later that is absolutely no problem. We are better to err on the
side of being cautious here IMHO.

/Bruce