DPDK CI discussions
 help / color / mirror / Atom feed
* [dpdk-ci] Failing pf_smoke test
@ 2021-09-21 13:12 David Marchand
  2021-09-21 13:20 ` Lincoln Lavoie
  0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2021-09-21 13:12 UTC (permalink / raw)
  To: sys_stv, Chen, Zhaoyan; +Cc: ci, Aaron Conole, Yigit, Ferruh, Thomas Monjalon

Hello,

For a couple of weeks (first report for me on 09/07), I receive
failure reports for the pf_smoke / test_pf_rss test case on any patch
I post.

Can this be fixed?
Else, please disable this test.


Thanks.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Failing pf_smoke test
  2021-09-21 13:12 [dpdk-ci] Failing pf_smoke test David Marchand
@ 2021-09-21 13:20 ` Lincoln Lavoie
  2021-09-22  6:17   ` Chen, Zhaoyan
  0 siblings, 1 reply; 8+ messages in thread
From: Lincoln Lavoie @ 2021-09-21 13:20 UTC (permalink / raw)
  To: David Marchand, Tu, Lijuan, Chen, Zhaoyan
  Cc: sys_stv, ci, Aaron Conole, Yigit, Ferruh, Thomas Monjalon

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi All,

This is a failing test in the Intel Lab.  Zhaoyan and Lijuan, can you check
on the status of that test case?

Cheers,
Lincoln

On Tue, Sep 21, 2021 at 9:12 AM David Marchand <david.marchand@redhat.com>
wrote:

> Hello,
>
> For a couple of weeks (first report for me on 09/07), I receive
> failure reports for the pf_smoke / test_pf_rss test case on any patch
> I post.
>
> Can this be fixed?
> Else, please disable this test.
>
>
> Thanks.
>
> --
> David Marchand
>
>

-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 1977 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Failing pf_smoke test
  2021-09-21 13:20 ` Lincoln Lavoie
@ 2021-09-22  6:17   ` Chen, Zhaoyan
  2021-09-22  7:23     ` Thomas Monjalon
  2021-09-30  7:58     ` David Marchand
  0 siblings, 2 replies; 8+ messages in thread
From: Chen, Zhaoyan @ 2021-09-22  6:17 UTC (permalink / raw)
  To: Lincoln Lavoie, David Marchand, Tu, Lijuan
  Cc: sys_stv, ci, Aaron Conole, Yigit, Ferruh, Thomas Monjalon

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

Thanks Lincoln and David to reminder.

Actually, this is a real issue on main branch.

The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS<http://mails.dpdk.org/archives/test-report/2021-September/220075.html>)

I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

/Zhaoyan

From: Lincoln Lavoie <lylavoie@iol.unh.edu>
Date: Tuesday, September 21, 2021 at 21:22
To: David Marchand <david.marchand@redhat.com>, "Tu, Lijuan" <lijuan.tu@intel.com>, "Chen, Zhaoyan" <zhaoyan.chen@intel.com>
Cc: sys_stv <sys_stv@intel.com>, "ci@dpdk.org" <ci@dpdk.org>, Aaron Conole <aconole@redhat.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-ci] Failing pf_smoke test

Hi All,

This is a failing test in the Intel Lab.  Zhaoyan and Lijuan, can you check on the status of that test case?

Cheers,
Lincoln

On Tue, Sep 21, 2021 at 9:12 AM David Marchand <david.marchand@redhat.com<mailto:david.marchand@redhat.com>> wrote:
Hello,

For a couple of weeks (first report for me on 09/07), I receive
failure reports for the pf_smoke / test_pf_rss test case on any patch
I post.

Can this be fixed?
Else, please disable this test.


Thanks.

--
David Marchand


--
Lincoln Lavoie
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>
https://www.iol.unh.edu
+1-603-674-2755 (m)
[Image removed by sender.]<https://www.iol.unh.edu/>

[-- Attachment #2: Type: text/html, Size: 8017 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Failing pf_smoke test
  2021-09-22  6:17   ` Chen, Zhaoyan
@ 2021-09-22  7:23     ` Thomas Monjalon
  2021-09-22  9:12       ` Chen, Zhaoyan
  2021-09-22  9:52       ` David Marchand
  2021-09-30  7:58     ` David Marchand
  1 sibling, 2 replies; 8+ messages in thread
From: Thomas Monjalon @ 2021-09-22  7:23 UTC (permalink / raw)
  To: Chen, Zhaoyan
  Cc: Lincoln Lavoie, David Marchand, Tu, Lijuan, sys_stv, ci,
	Aaron Conole, Yigit, Ferruh

22/09/2021 08:17, Chen, Zhaoyan:
> Thanks Lincoln and David to reminder.
> 
> Actually, this is a real issue on main branch.
> 
> The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).

Why a patch failing CI has been merged?
Is it because we get used to have CI failing and don't pay attention?

> Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
> Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS<http://mails.dpdk.org/archives/test-report/2021-September/220075.html>)
> 
> I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

Everybody, every contributors ask why CI is failing for their patch.
So yes, such test should have been disabled as early as you discover the problem please.
The right process is to fill a bugzilla ticket to be referenced in the fix.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Failing pf_smoke test
  2021-09-22  7:23     ` Thomas Monjalon
@ 2021-09-22  9:12       ` Chen, Zhaoyan
  2021-09-22  9:52       ` David Marchand
  1 sibling, 0 replies; 8+ messages in thread
From: Chen, Zhaoyan @ 2021-09-22  9:12 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: Lincoln Lavoie, David Marchand, Tu, Lijuan, sys_stv, ci,
	Aaron Conole, Yigit, Ferruh

Disabled. 

On 2021/9/22, 15:23, "Thomas Monjalon" <thomas@monjalon.net> wrote:

    22/09/2021 08:17, Chen, Zhaoyan:
    > Thanks Lincoln and David to reminder.
    > 
    > Actually, this is a real issue on main branch.
    > 
    > The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).

    Why a patch failing CI has been merged?
    Is it because we get used to have CI failing and don't pay attention?

    > Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
    > Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS<http://mails.dpdk.org/archives/test-report/2021-September/220075.html>)
    > 
    > I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

    Everybody, every contributors ask why CI is failing for their patch.
    So yes, such test should have been disabled as early as you discover the problem please.
    The right process is to fill a bugzilla ticket to be referenced in the fix.




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Failing pf_smoke test
  2021-09-22  7:23     ` Thomas Monjalon
  2021-09-22  9:12       ` Chen, Zhaoyan
@ 2021-09-22  9:52       ` David Marchand
  2021-09-22 10:02         ` Thomas Monjalon
  1 sibling, 1 reply; 8+ messages in thread
From: David Marchand @ 2021-09-22  9:52 UTC (permalink / raw)
  To: Thomas Monjalon, Qi Zhang, Yigit, Ferruh
  Cc: Chen, Zhaoyan, Lincoln Lavoie, Tu, Lijuan, sys_stv, ci, Aaron Conole

On Wed, Sep 22, 2021 at 9:23 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 22/09/2021 08:17, Chen, Zhaoyan:
> > Thanks Lincoln and David to reminder.
> >
> > Actually, this is a real issue on main branch.
> >
> > The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
>
> Why a patch failing CI has been merged?
> Is it because we get used to have CI failing and don't pay attention?

The CI did report this failure on the original series.
http://mails.dpdk.org/archives/test-report/2021-August/210297.html
This series should not have been merged but it was on 08/29:
https://inbox.dpdk.org/dev/0935a75ef4334a4c9af65ecb6adac33f@intel.com/

I am not sure when it got into next-net.

A revert was proposed before next-net pull in main on 09/07:
http://patches.dpdk.org/project/dpdk/patch/20210907064537.74596-1-wenjun1.wu@intel.com/

Note, at this point, I had not noticed the original patch had
triggered a regression.
This revert was then deemed not appropriate and in the end the
original series hit the main branch.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Failing pf_smoke test
  2021-09-22  9:52       ` David Marchand
@ 2021-09-22 10:02         ` Thomas Monjalon
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2021-09-22 10:02 UTC (permalink / raw)
  To: Qi Zhang, Yigit, Ferruh, David Marchand, Chen, Zhaoyan
  Cc: Lincoln Lavoie, Tu, Lijuan, sys_stv, ci, Aaron Conole

22/09/2021 11:52, David Marchand:
> On Wed, Sep 22, 2021 at 9:23 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 22/09/2021 08:17, Chen, Zhaoyan:
> > > Thanks Lincoln and David to reminder.
> > >
> > > Actually, this is a real issue on main branch.
> > >
> > > The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
> >
> > Why a patch failing CI has been merged?
> > Is it because we get used to have CI failing and don't pay attention?
> 
> The CI did report this failure on the original series.
> http://mails.dpdk.org/archives/test-report/2021-August/210297.html
> This series should not have been merged but it was on 08/29:
> https://inbox.dpdk.org/dev/0935a75ef4334a4c9af65ecb6adac33f@intel.com/
> 
> I am not sure when it got into next-net.
> 
> A revert was proposed before next-net pull in main on 09/07:
> http://patches.dpdk.org/project/dpdk/patch/20210907064537.74596-1-wenjun1.wu@intel.com/
> 
> Note, at this point, I had not noticed the original patch had
> triggered a regression.
> This revert was then deemed not appropriate and in the end the
> original series hit the main branch.

Thanks for the history.
We must improve to avoid such failure in future.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Failing pf_smoke test
  2021-09-22  6:17   ` Chen, Zhaoyan
  2021-09-22  7:23     ` Thomas Monjalon
@ 2021-09-30  7:58     ` David Marchand
  1 sibling, 0 replies; 8+ messages in thread
From: David Marchand @ 2021-09-30  7:58 UTC (permalink / raw)
  To: Chen, Zhaoyan, Qi Zhang
  Cc: Lincoln Lavoie, Tu, Lijuan, sys_stv, ci, Aaron Conole, Yigit,
	Ferruh, Thomas Monjalon

Hi,

On Wed, Sep 22, 2021 at 8:18 AM Chen, Zhaoyan <zhaoyan.chen@intel.com> wrote:
> The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
> Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
> Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS)
>
> I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

The fix should now be in the main branch.
cc46bab5968a ("net/ice: remove support for IP fragment default RSS")

Can you double check the test passes fine on the main branch?
Then, if this is the case, please re-enable this test for all submitted patches.

Thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-09-30  7:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 13:12 [dpdk-ci] Failing pf_smoke test David Marchand
2021-09-21 13:20 ` Lincoln Lavoie
2021-09-22  6:17   ` Chen, Zhaoyan
2021-09-22  7:23     ` Thomas Monjalon
2021-09-22  9:12       ` Chen, Zhaoyan
2021-09-22  9:52       ` David Marchand
2021-09-22 10:02         ` Thomas Monjalon
2021-09-30  7:58     ` David Marchand

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git