From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47E9CA0C41 for ; Fri, 16 Apr 2021 09:00:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4016E141B20; Fri, 16 Apr 2021 09:00:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id EBF85141B21 for ; Fri, 16 Apr 2021 09:00:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618556439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LABOcXsMN2Z7l01hu7/0SC7+CJmT6BENfLi1WsUelfw=; b=PgDiY+ToaWZ3Sfip9YWTWTwtlRjMKM2mlo4hVVwB2UvR+l49rVo0a/AJXQM5SA8uSuukhZ MOPFBvXol2raLvlDVzP6yawfBOui/3PNU7SD3MX/xs0sJeATnzC6FefRoc5r+YRsq6Peua kh6hFDBqwftE/z9orW5HnEj3d8OJ7/w= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-Ux8urEgNOZCiDzTJMp_wGA-1; Fri, 16 Apr 2021 03:00:37 -0400 X-MC-Unique: Ux8urEgNOZCiDzTJMp_wGA-1 Received: by mail-vk1-f200.google.com with SMTP id g185-20020a1f20c20000b02901e083517917so1372533vkg.18 for ; Fri, 16 Apr 2021 00:00:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LABOcXsMN2Z7l01hu7/0SC7+CJmT6BENfLi1WsUelfw=; b=Z1X0irbkDdPJ5AHCoNRhPP7QLEobNoRaKLDVQRNPE/MFY9t4SWhrZC68PBeQGW5JPj qIXDH2FKezQt9XsCu/TCw08IRCZc2MkJnu5v56UWIXJ/tXY9A87H6nvVu46BpylX3eGr P4+N+0yb+ngs9uaMw56nWlj3SDGt0Qe3DQwy87fdCW967VZCSJI2nO15HG5gXH7klzpx OCXiDKaEYzxpIxTLJzX3j4V0664Wg7QyEmfIKrPVythA2logg7irP8kANHHKemsE5XSf YjT1a9D3Gq8V4VuHchi4xdC0EC1Dr7OE4mrCTtU69b4QUf7FQpIe2FZM7tG1a95AQyE/ ToIA== X-Gm-Message-State: AOAM530dRAMoRaUvv6dwct+14BoDqwtj+dn/iIlGsKpW6d2BZmK92eIT 0vSLONjVaOK7sGHLStzEWAceAAZSDNfKbaLdA/ACyQ97B3RICGTVEvng1Eijnpy7hanxhq6o7FB Kr8GC2gtmS+qK5yE3GQ== X-Received: by 2002:a1f:a747:: with SMTP id q68mr5635822vke.25.1618556436195; Fri, 16 Apr 2021 00:00:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0irETMI5sWhJn6aHzDqSH9oATgrcuBiE2Lj262MI+Rm7rcXgPLmtu1ExBQDsakoPGalw9Hp2Y5npRL79UHfc= X-Received: by 2002:a1f:2a09:: with SMTP id q9mr5570067vkq.17.1618556425121; Fri, 16 Apr 2021 00:00:25 -0700 (PDT) MIME-Version: 1.0 References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1618283653-16510-1-git-send-email-xuemingl@nvidia.com> <1618283653-16510-2-git-send-email-xuemingl@nvidia.com> In-Reply-To: <1618283653-16510-2-git-send-email-xuemingl@nvidia.com> From: David Marchand Date: Fri, 16 Apr 2021 09:00:13 +0200 Message-ID: To: Aaron Conole , dpdklab Cc: Thomas Monjalon , Gaetan Rivet , dev , "Xueming(Steven) Li" , Asaf Penso , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Gaetan Rivet , Anatoly Burakov , Ray Kinsella , Neil Horman , Ferruh Yigit , Andrew Rybchenko , Dodji Seketeli , ci@dpdk.org Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: > diff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h > index 296f19324f..134b44a887 100644 > --- a/lib/librte_eal/include/rte_devargs.h > +++ b/lib/librte_eal/include/rte_devargs.h > @@ -60,16 +60,16 @@ struct rte_devargs { > /** Name of the device. */ > char name[RTE_DEV_NAME_MAX_LEN]; > RTE_STD_C11 > - union { > - /** Arguments string as given by user or "" for no argument. */ > - char *args; > + union { /**< driver-related part of device string. */ > + const char *args; /**< legacy name. */ > const char *drv_str; > }; > struct rte_bus *bus; /**< bus handle. */ > struct rte_class *cls; /**< class handle. */ > const char *bus_str; /**< bus-related part of device string. */ > const char *cls_str; /**< class-related part of device string. */ > - const char *data; /**< Device string storage. */ > + char *data; > + /**< Raw string including bus, class and driver arguments. */ > }; > > /** - Flagging this patch for info and its impact on UNH jobs. This change is fine, but older libabigail versions could not deal with such changes (anonymous union, changes of const fields). This results in an ABI check failure in the UNH x86 job on Ubuntu 18.04 (and for some people not using recent libabigail). I can see the ARM job passes fine, so I suppose it is using a more recent libabigail (running Ubuntu 20.04 maybe?). We either need to disable this x86 job or update its libabigail package (maybe aligning with what we have for public CI which is libabigail 1.8 manually compiled). - For the longer term, what do you think of using/extending the .ci/ scripts for use by UNH jobs? -- David Marchand