From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BBB343081; Wed, 16 Aug 2023 16:40:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0785C40693; Wed, 16 Aug 2023 16:40:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 085D24003C for ; Wed, 16 Aug 2023 16:40:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692196836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tpx5PwpnUuEBLK/Bsv7Z+1/JNHo2O7p2xkQoJ+XxET8=; b=Xp5TRQNSSRIiMW86XMwA4KLDgimiG0DjmqP/oUhIvyQgXunbqLEwcOM+vbgxJFxf12l5BG Q8Rtmz0p6KAfOjptD+okmhWhT3H6Ktq+W9I7F5pmc/RpRumofc8kOgI4eZFwiJpgUaL1Yr qVFCs1dOK5Bnss8KLv8VhnvoiclwNoA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-jTzxqb-FM56nlaEjnjViRg-1; Wed, 16 Aug 2023 10:40:35 -0400 X-MC-Unique: jTzxqb-FM56nlaEjnjViRg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4fe3c8465e0so6554793e87.1 for ; Wed, 16 Aug 2023 07:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692196834; x=1692801634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tpx5PwpnUuEBLK/Bsv7Z+1/JNHo2O7p2xkQoJ+XxET8=; b=caXhIcX4kZ0HmfE1yZrch/8YWPwlrFSG4Nk4NOxGIkF7395K44ZGZ9nLETbjpSTke4 sYXMJR4PjC5G2C7dz5cGdd6vaDHhr2+3eYwMX4fJ3mVUdOPijKSfyBlbN2xyt222H3lb OPUpj+K05k2OK+xab0yvocIj7vU1kZHOK0KqjA5UwmBE2NX7JkKCnHu7JFG8fGUwA+mU mfTT5+sOBUvtVmeXmqMLFUzuVyM0JBwCcTegVtEavDws7KvK9C4zNuxJ5i5cbYO+zSCd OBt++LeTqKKL+/e86uPSnC+31Q29UWlGMLc4mV9Xaz6ywE3f1xya2iv0OtAOQjYfj4q9 WnJQ== X-Gm-Message-State: AOJu0YxDU8GlEHgL97r3jMVr2GaFz7rZCGywqn1ZtM5zSbZ7TWsmAqtY QWwCsvsJQ7K4DszSI9VfSsEFlpPEdQ4Bc/yX6Pd1kCSefntGYxzFRPTLjxHPzgRTD7HQruwNnHq xLyWNwyHxaBrR9G0mPA== X-Received: by 2002:ac2:5b05:0:b0:4fd:c715:5667 with SMTP id v5-20020ac25b05000000b004fdc7155667mr1484665lfn.20.1692196833836; Wed, 16 Aug 2023 07:40:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8fPmuaR6Wd+6DeXTkAZ6XNW8fqY3d4DkiHOWlKy/HGfGnL3dN/ODw+xwax3V2dHfjUZNfTR9ekZwpbcD6D0k= X-Received: by 2002:ac2:5b05:0:b0:4fd:c715:5667 with SMTP id v5-20020ac25b05000000b004fdc7155667mr1484642lfn.20.1692196833499; Wed, 16 Aug 2023 07:40:33 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-5-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Wed, 16 Aug 2023 16:40:21 +0200 Message-ID: Subject: Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix To: Bruce Richardson , Patrick Robb Cc: dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Thomas Monjalon , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Patrick, Bruce, On Wed, Aug 16, 2023 at 2:57=E2=80=AFPM Bruce Richardson wrote: > > On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: > > Adam from our team just raised something important about this patch = and > > UNH CI which I missed during the RFC discussion. > > Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (= arm > > people are aware of this, they think it might be a memory leak from That's sad to read. > > mlx5 driver), so at their request we are disabling this unit test (o= n > > arm only) for them for the time being. If it was reported, I either missed it or forgot about it, sorry. Can you (re)share the context? There was a couple of mem leak fixes for mlx5 in v23.07. It may be worth running this test again and providing fresh traces. > > Does the test suite pass if the mlx5 driver is disabled in the build? Tha= t > could confirm or refute the suspicion of where the issue is, and also > provide a temporary workaround while this set is merged (possibly includi= ng > support for disabling specific tests, as I suggested in my other email). Or disabling the driver as Bruce proposes. > > /Bruce > > PS: Are there any other workarounds inside the test/DTS/CI systems that > involve patching sources? If so, it would be good to get a list that we c= an > work through removing by putting place proper fixes or workarounds, as > changing sources for testing like this blocks future patch acceptance. Patching sources from the test tool is a poor solution. In general, developers won't be aware of source patching and will waste time trying to understand why they can't reproduce what the CI reports (it happened to me with DTS on the interrupt stuff with vhost, at least). For this specific case of skipping a test, if nobody can fix the issue, I prefer if the CI can skip some "known broken in my lab" tests via some meson configuration. And, such configuration should be easy to catch in the test report. --=20 David Marchand