From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAEE541EA2 for ; Wed, 15 Mar 2023 18:10:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D606B42BB1; Wed, 15 Mar 2023 18:10:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4063E4161A for ; Wed, 15 Mar 2023 18:10:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678900212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pPfPG0xCrXpslqm3LgKsuEjXLujfClxGv8dA4rf95L8=; b=Fq6XySZnLdyWJVQLe82Fuy65JhDYi9f0c23rKkx+aTyXetkq1PZn2u6sErZfC2k7P1R0rW qaLTU5Hxo/v4gMnBaIImajcT5pVy5MlCGkV+kTxMYDbJSZQxSjqLiEss+4Rzi7ReJ2pVSJ sm64T4/wKw5MJvykWAFPBP+pliKmVIA= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-wSMfgAvFNly4kasnAXhqBQ-1; Wed, 15 Mar 2023 13:10:11 -0400 X-MC-Unique: wSMfgAvFNly4kasnAXhqBQ-1 Received: by mail-pg1-f199.google.com with SMTP id s21-20020a632155000000b004fc1f5c8a4dso4716242pgm.11 for ; Wed, 15 Mar 2023 10:10:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678900210; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pPfPG0xCrXpslqm3LgKsuEjXLujfClxGv8dA4rf95L8=; b=K0X2+2DVdyaKAWmcr1BrSFUWyratldbsx0HNE5+AFQamKcTpGUwSDytXxxPatUSeit hQgjflJhE+cGxa8gUmWuNgcZMCc11cpVpxQbqCe5cjIQkwNyGidIlm+We7g0+jzNjFvF S5ibcjLYE2EZe5NAGLoKVqQasnQfKP71RKRXP0uvJqVxbts6jU3JfbGUh5NkyhNX9eZi 1TUkujN4tyP6IXgHiQCfCJH1xXX5797kb3+JQ+G1URna54WM8/JSmsNOEFOyC4yBIa3P z9kONRzHK9M/XiHtoiu5trdPz/lKgWMCv+dJG0TjRMTCne/tjpAfvTJnpRLTio8DOWLa Keuw== X-Gm-Message-State: AO0yUKVw0FLmLpKom4bgAEsbT13ElVqP+ogu35f9qzcS3pSAaV2gVuO8 dz/WnOosdulzFEaIVxTLeJRy0f7ST1HtR3RMSrGQ3JmTnzapf/K+LKEC/Az4hNEFY/AlLuBFKm2 3u+kslRzD0XNNnZS/OQ== X-Received: by 2002:a17:902:6e02:b0:19a:7f9c:66e3 with SMTP id u2-20020a1709026e0200b0019a7f9c66e3mr174563plk.5.1678900210547; Wed, 15 Mar 2023 10:10:10 -0700 (PDT) X-Google-Smtp-Source: AK7set+nN76U3IeO/iBsRhy/4ZhgNI1pn4+rH7Q4+RR8abckH6DSOarvg+yBVQ9g6nI66yEo2P84rjoUk9AGr33fl6U= X-Received: by 2002:a17:902:6e02:b0:19a:7f9c:66e3 with SMTP id u2-20020a1709026e0200b0019a7f9c66e3mr174551plk.5.1678900210201; Wed, 15 Mar 2023 10:10:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 15 Mar 2023 18:09:58 +0100 Message-ID: Subject: Re: Meson buildtype for ci jobs? To: "Richardson, Bruce" Cc: Patrick Robb , "ci@dpdk.org" , Aaron Conole , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On Wed, Mar 15, 2023 at 6:02=E2=80=AFPM Richardson, Bruce wrote: > > > > > -----Original Message----- > > From: David Marchand > > Sent: Wednesday, March 15, 2023 4:08 PM > > To: Patrick Robb > > Cc: ci@dpdk.org; Aaron Conole ; Richardson, Bruce > > ; Thomas Monjalon > > Subject: Re: Meson buildtype for ci jobs? > > > > On Wed, Mar 15, 2023 at 4:52=E2=80=AFPM Patrick Robb wrote: > > > > > > Hello all, > > > > > > The lab recently received a request to re-enable Alpine compile jobs, > > which have been disabled for almost a year. In dry running the compile > > job, I noticed that it was failing. At the same time, David Marchand di= d > > an Alpine compile with Github Actions which was successful. It seems th= e > > source of the different behavior is the meson buildtype being used - th= e > > build script used by GHA sets meson buildtype to debugoptimized, wherea= s > > the script used by the community lab runs with buildtype debug (the mes= on > > default). I did my own Github Actions runs (with both buildtype options= ) > > to sanity check: > > https://github.com/PatrickRobbIOL/dpdk/actions/runs/4427160204/jobs/776= 436 > > 8640 > > > > Are you sure about the default value? > > > > Afaics, meson selects by default a "release" buildtype (and I think I > > always saw this value in the past). > > I have this with meson 1.0. > > > > $ meson setup qsdlgfh > > ... > > $ meson configure qsdlgfh | grep buildtype > > buildtype release > > [plain, debug, debugoptimized, Build type to use > > > > > > > > The reason I'm writing this email is that I'm wondering whether the > > buildtype decision made by those who wrote .ci/linux-build.sh for GHA w= as > > intentional and important. I know many of the people who have commits o= n > > that script follow this mailing list. Obviously if it's in some way mor= e > > appropriate for CI purposes to run meson setup in this way, I'm happy t= o > > make that change at the lab and in the process that would free up bring= ing > > Alpine compile testing online. But, if not, then I think it's most > > appropriate to consider compile on Alpine as broken and avoid bringing > > coverage for Alpine online until that issue is resolved. > > > > The reason why we went with debugoptimized was primarly for the ABI > > checks, as by default, the debug symbols were missing (which would > > match with a "release" default buildtype). > > See 777014e56d07 ("devtools: add ABI checks"). > > > > Would passing "-Ddebug=3Dtrue" be better than changing the default buildt= ype? > It's possible to have a release build (i.e. O3 optimized) with debug info= . I would expect it to work, though I never tried it as I understood what optimization, debug and buildtype relations were recently, only :-). --=20 David marchand