[dpdk-ci] Failing pf_smoke test

[dpdk-ci] Failing pf_smoke test

[David Marchand]

Hello,

For a couple of weeks (first report for me on 09/07), I receive
failure reports for the pf_smoke / test_pf_rss test case on any patch
I post.

Can this be fixed?
Else, please disable this test.


Thanks.

-- 
David Marchand

Re: [dpdk-ci] Failing pf_smoke test

[Lincoln Lavoie]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi All,

This is a failing test in the Intel Lab.  Zhaoyan and Lijuan, can you check
on the status of that test case?

Cheers,
Lincoln

On Tue, Sep 21, 2021 at 9:12 AM David Marchand <david.marchand@redhat.com>
wrote:

> Hello,
>
> For a couple of weeks (first report for me on 09/07), I receive
> failure reports for the pf_smoke / test_pf_rss test case on any patch
> I post.
>
> Can this be fixed?
> Else, please disable this test.
>
>
> Thanks.
>
> --
> David Marchand
>
>

-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 1977 bytes --]

Re: [dpdk-ci] Failing pf_smoke test

[Chen, Zhaoyan]

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

Thanks Lincoln and David to reminder.

Actually, this is a real issue on main branch.

The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS<http://mails.dpdk.org/archives/test-report/2021-September/220075.html>)

I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

/Zhaoyan

From: Lincoln Lavoie <lylavoie@iol.unh.edu>
Date: Tuesday, September 21, 2021 at 21:22
To: David Marchand <david.marchand@redhat.com>, "Tu, Lijuan" <lijuan.tu@intel.com>, "Chen, Zhaoyan" <zhaoyan.chen@intel.com>
Cc: sys_stv <sys_stv@intel.com>, "ci@dpdk.org" <ci@dpdk.org>, Aaron Conole <aconole@redhat.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-ci] Failing pf_smoke test

Hi All,

This is a failing test in the Intel Lab.  Zhaoyan and Lijuan, can you check on the status of that test case?

Cheers,
Lincoln

On Tue, Sep 21, 2021 at 9:12 AM David Marchand <david.marchand@redhat.com<mailto:david.marchand@redhat.com>> wrote:
Hello,

For a couple of weeks (first report for me on 09/07), I receive
failure reports for the pf_smoke / test_pf_rss test case on any patch
I post.

Can this be fixed?
Else, please disable this test.


Thanks.

--
David Marchand


--
Lincoln Lavoie
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>
https://www.iol.unh.edu
+1-603-674-2755 (m)
[Image removed by sender.]<https://www.iol.unh.edu/>

[-- Attachment #2: Type: text/html, Size: 8017 bytes --]

Re: [dpdk-ci] Failing pf_smoke test

[Thomas Monjalon]

22/09/2021 08:17, Chen, Zhaoyan:
> Thanks Lincoln and David to reminder.
> 
> Actually, this is a real issue on main branch.
> 
> The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).

Why a patch failing CI has been merged?
Is it because we get used to have CI failing and don't pay attention?

> Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
> Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS<http://mails.dpdk.org/archives/test-report/2021-September/220075.html>)
> 
> I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

Everybody, every contributors ask why CI is failing for their patch.
So yes, such test should have been disabled as early as you discover the problem please.
The right process is to fill a bugzilla ticket to be referenced in the fix.

Re: [dpdk-ci] Failing pf_smoke test

[Chen, Zhaoyan]

Disabled. 

On 2021/9/22, 15:23, "Thomas Monjalon" <thomas@monjalon.net> wrote:

    22/09/2021 08:17, Chen, Zhaoyan:
    > Thanks Lincoln and David to reminder.
    > 
    > Actually, this is a real issue on main branch.
    > 
    > The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).

    Why a patch failing CI has been merged?
    Is it because we get used to have CI failing and don't pay attention?

    > Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
    > Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS<http://mails.dpdk.org/archives/test-report/2021-September/220075.html>)
    > 
    > I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

    Everybody, every contributors ask why CI is failing for their patch.
    So yes, such test should have been disabled as early as you discover the problem please.
    The right process is to fill a bugzilla ticket to be referenced in the fix.

Re: [dpdk-ci] Failing pf_smoke test

[David Marchand]

On Wed, Sep 22, 2021 at 9:23 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 22/09/2021 08:17, Chen, Zhaoyan:
> > Thanks Lincoln and David to reminder.
> >
> > Actually, this is a real issue on main branch.
> >
> > The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
>
> Why a patch failing CI has been merged?
> Is it because we get used to have CI failing and don't pay attention?

The CI did report this failure on the original series.
http://mails.dpdk.org/archives/test-report/2021-August/210297.html
This series should not have been merged but it was on 08/29:
https://inbox.dpdk.org/dev/0935a75ef4334a4c9af65ecb6adac33f@intel.com/

I am not sure when it got into next-net.

A revert was proposed before next-net pull in main on 09/07:
http://patches.dpdk.org/project/dpdk/patch/20210907064537.74596-1-wenjun1.wu@intel.com/

Note, at this point, I had not noticed the original patch had
triggered a regression.
This revert was then deemed not appropriate and in the end the
original series hit the main branch.


-- 
David Marchand

Re: [dpdk-ci] Failing pf_smoke test

[Thomas Monjalon]

22/09/2021 11:52, David Marchand:
> On Wed, Sep 22, 2021 at 9:23 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 22/09/2021 08:17, Chen, Zhaoyan:
> > > Thanks Lincoln and David to reminder.
> > >
> > > Actually, this is a real issue on main branch.
> > >
> > > The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
> >
> > Why a patch failing CI has been merged?
> > Is it because we get used to have CI failing and don't pay attention?
> 
> The CI did report this failure on the original series.
> http://mails.dpdk.org/archives/test-report/2021-August/210297.html
> This series should not have been merged but it was on 08/29:
> https://inbox.dpdk.org/dev/0935a75ef4334a4c9af65ecb6adac33f@intel.com/
> 
> I am not sure when it got into next-net.
> 
> A revert was proposed before next-net pull in main on 09/07:
> http://patches.dpdk.org/project/dpdk/patch/20210907064537.74596-1-wenjun1.wu@intel.com/
> 
> Note, at this point, I had not noticed the original patch had
> triggered a regression.
> This revert was then deemed not appropriate and in the end the
> original series hit the main branch.

Thanks for the history.
We must improve to avoid such failure in future.

Re: [dpdk-ci] Failing pf_smoke test

[David Marchand]

Hi,

On Wed, Sep 22, 2021 at 8:18 AM Chen, Zhaoyan <zhaoyan.chen@intel.com> wrote:
> The pf_smoke failed due to dpdk bad commit id: b3d95f1817288ca228f09b9164d6d3ff6249b175(has been merged into main branch).
> Currently, its fixed patch(http://patches.dpdk.org/project/dpdk/list/?series=18963) are provided by Dev and tested passed by CI, but not merged into main branch due to share code limitation.
> Test report: [dpdk-test-report] (Testing) |SUCCESS| pw(98992-98993) sid(18963) job(PER_PATCH_BUILD7871) [v2, 2/2] net/iavf: remove support for IP fragment default RSS)
>
> I don’t know when the hotfix patch could be merged. Before that, shall CI be disabled for this real issue?

The fix should now be in the main branch.
cc46bab5968a ("net/ice: remove support for IP fragment default RSS")

Can you double check the test passes fine on the main branch?
Then, if this is the case, please re-enable this test for all submitted patches.

Thanks.


-- 
David Marchand