From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
"Rong, Leyi" <leyi.rong@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"talshn@nvidia.com" <talshn@nvidia.com>,
"Kadam, Pallavi" <pallavi.kadam@intel.com>,
"Menon, Ranjit" <ranjit.menon@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>, "ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW
Date: Thu, 4 Feb 2021 14:43:03 +0100 [thread overview]
Message-ID: <CAJFAV8z_w9pu3uZA1XONSK-OFDPRv1LOwWvfu7CehqZhKuF+7A@mail.gmail.com> (raw)
In-Reply-To: <d9457302-47c6-988b-6765-5eb4d64fc94c@intel.com>
On Thu, Feb 4, 2021 at 1:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 2/4/2021 10:41 AM, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >> Sent: Wednesday, February 3, 2021 7:08 AM
> >> To: Rong, Leyi <leyi.rong@intel.com>
> >> Cc: david.marchand@redhat.com; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit,
> >> Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net; Richardson, Bruce
> >> <bruce.richardson@intel.com>; talshn@nvidia.com; Kadam, Pallavi
> >> <pallavi.kadam@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Xing,
> >> Beilei <beilei.xing@intel.com>; aconole@redhat.com; dev@dpdk.org;
> >> ci@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW
> >>
> >> On Tue, 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote:
> >>> Adds extra cflags '-fno-asynchronous-unwind-tables'
> >>> to avoid the MinGW build error:
> >>> Error: invalid register for .seh_savexmm
> >>>
> >>> Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW")
> >>>
> >>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> >>
> >> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >>
> >> Re: -fno-asynchronous-unwind-tables, when cross-compiling from Linux, I
> >> observe bit-to-bit identical i40e_rxtx_vec_avx512.c.obj. My guess it that this
> >> option somehow affects GCC inlining heuristics. Similar issue existed in
> >> librte_acl (at least a year ago win GCC 6, I believe), where GCC generated
> >> incorrect code unless certain functions had been inlined (caught by test app).
> >> No an AVX expert, just my 2c.
> >
> > Applied to dpdk-next-net-intel.
> >
>
> Hi Thomas, David,
>
> Do you prefer to get this directly to the main repo, since it is fixing the
> windows build?
I have no issue with the main branch for mingw.
The windows builds at UNH seem unavailable, so we can wait for the
next-net merge.
--
David Marchand
next prev parent reply other threads:[~2021-02-04 13:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 9:06 [dpdk-ci] [PATCH] net/i40e: disable AVX512 with MinGW Leyi Rong
2021-02-02 10:24 ` Bruce Richardson
2021-02-02 14:13 ` Tal Shnaiderman
2021-02-02 14:31 ` Rong, Leyi
2021-02-02 14:32 ` [dpdk-ci] [PATCH v2] net/i40e: fix avx code error on MinGW Leyi Rong
2021-02-02 23:07 ` [dpdk-ci] [dpdk-dev] " Dmitry Kozlyuk
2021-02-04 10:41 ` Zhang, Qi Z
2021-02-04 12:36 ` Ferruh Yigit
2021-02-04 12:59 ` Thomas Monjalon
2021-02-04 13:43 ` David Marchand [this message]
2021-02-04 21:57 ` Lincoln Lavoie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z_w9pu3uZA1XONSK-OFDPRv1LOwWvfu7CehqZhKuF+7A@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=leyi.rong@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).