DPDK CI discussions
 help / color / mirror / Atom feed
* [dpdk-ci] l3fwd tests
@ 2021-11-05 17:07 David Marchand
  2021-11-10  9:53 ` David Marchand
  0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2021-11-05 17:07 UTC (permalink / raw)
  To: dts; +Cc: ci, Pavan Nikhilesh, Ananyev, Konstantin

Hello,

- Looking at l3fwd tests in dts, I noticed it still relies on
USER_FLAGS= black magic which was dropped with makefile support
removal.
See fda34680eb9a ("examples: remove legacy sections of makefiles").

This requires a fix if the intention is still to test the different
lookup methods.


- A change has been proposed on l3fwd, that will change the expected
network traffic.
https://patchwork.dpdk.org/project/dpdk/list/?series=20336
Especially:
https://patchwork.dpdk.org/project/dpdk/patch/20211105083851.2812-3-pbhagavatula@marvell.com/

Please confirm DTS will be fine with this change.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-ci] l3fwd tests
  2021-11-05 17:07 [dpdk-ci] l3fwd tests David Marchand
@ 2021-11-10  9:53 ` David Marchand
  2021-11-10 15:25   ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2021-11-10  9:53 UTC (permalink / raw)
  To: dts, Tu, Lijuan, Marvin Liu; +Cc: ci, Pavan Nikhilesh, Ananyev, Konstantin

On Fri, Nov 5, 2021 at 6:07 PM David Marchand <david.marchand@redhat.com> wrote:
> - Looking at l3fwd tests in dts, I noticed it still relies on
> USER_FLAGS= black magic which was dropped with makefile support
> removal.
> See fda34680eb9a ("examples: remove legacy sections of makefiles").
>
> This requires a fix if the intention is still to test the different
> lookup methods.
>
>
> - A change has been proposed on l3fwd, that will change the expected
> network traffic.
> https://patchwork.dpdk.org/project/dpdk/list/?series=20336
> Especially:
> https://patchwork.dpdk.org/project/dpdk/patch/20211105083851.2812-3-pbhagavatula@marvell.com/
>
> Please confirm DTS will be fine with this change.

ping.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: l3fwd tests
  2021-11-10  9:53 ` David Marchand
@ 2021-11-10 15:25   ` Tu, Lijuan
  2021-11-16 15:34     ` David Marchand
  0 siblings, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2021-11-10 15:25 UTC (permalink / raw)
  To: David Marchand, dts, Liu, Yong; +Cc: ci, Pavan Nikhilesh, Ananyev, Konstantin

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: 2021年11月10日 17:54
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>; Liu, Yong
> <yong.liu@intel.com>
> Cc: ci@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>
> Subject: Re: l3fwd tests
> 
> On Fri, Nov 5, 2021 at 6:07 PM David Marchand <david.marchand@redhat.com>
> wrote:
> > - Looking at l3fwd tests in dts, I noticed it still relies on
> > USER_FLAGS= black magic which was dropped with makefile support
> > removal.
> > See fda34680eb9a ("examples: remove legacy sections of makefiles").
> >
> > This requires a fix if the intention is still to test the different
> > lookup methods.
> >
> >
> > - A change has been proposed on l3fwd, that will change the expected
> > network traffic.
> > https://patchwork.dpdk.org/project/dpdk/list/?series=20336
> > Especially:
> > https://patchwork.dpdk.org/project/dpdk/patch/20211105083851.2812-3-pb
> > hagavatula@marvell.com/
> >
> > Please confirm DTS will be fine with this change.
> 
> ping.
> 
Thanks for the reminder.

dts is planed to  remove makefile support,  and this will be happened after dpdk21.11 released.

The l3fwd changes do have limited impact to DTS, it seems update configuration file is enough.

> --
> David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: l3fwd tests
  2021-11-10 15:25   ` Tu, Lijuan
@ 2021-11-16 15:34     ` David Marchand
  0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2021-11-16 15:34 UTC (permalink / raw)
  To: Tu, Lijuan
  Cc: dts, Liu, Yong, ci, Pavan Nikhilesh, Ananyev, Konstantin, Mcnamara, John

On Wed, Nov 10, 2021 at 4:26 PM Tu, Lijuan <lijuan.tu@intel.com> wrote:
> > > - A change has been proposed on l3fwd, that will change the expected
> > > network traffic.
> > > https://patchwork.dpdk.org/project/dpdk/list/?series=20336
> > > Especially:
> > > https://patchwork.dpdk.org/project/dpdk/patch/20211105083851.2812-3-pb
> > > hagavatula@marvell.com/
> > >
> > > Please confirm DTS will be fine with this change.
> >
> > ping.
> >
> The l3fwd changes do have limited impact to DTS, it seems update configuration file is enough.

Ok, fyi, patchset has been merged for 21.11-rc3.
Thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-16 15:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 17:07 [dpdk-ci] l3fwd tests David Marchand
2021-11-10  9:53 ` David Marchand
2021-11-10 15:25   ` Tu, Lijuan
2021-11-16 15:34     ` David Marchand

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git