From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FA4443082; Wed, 16 Aug 2023 16:56:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53B224324F; Wed, 16 Aug 2023 16:56:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A609040693 for ; Wed, 16 Aug 2023 16:56:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692197799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wxTtX/2FZkBc2bQi08lBp+dNaTq3VrmVuCM/MogMBRs=; b=ExpF0z1ZG3d6YogbZvVpxKqvTXfbFAU3biXmCL81HSM7//rvaIuFKOAQH5Fzrq4BhiW/8U tILAqA3i7z0cQfWD/5nyydyGye6fUUwN9XeT81EpZ2GfmGo4ENJepgN5bBIoF61pa490Wf A3JKBoLiePPJH+mzWD9tqCsAjA+IIW8= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-kWgyrIGGMQybRgvh2Q_rjA-1; Wed, 16 Aug 2023 10:56:37 -0400 X-MC-Unique: kWgyrIGGMQybRgvh2Q_rjA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4ff908143acso836851e87.0 for ; Wed, 16 Aug 2023 07:56:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692197795; x=1692802595; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wxTtX/2FZkBc2bQi08lBp+dNaTq3VrmVuCM/MogMBRs=; b=Rnon09LLG8lu10WHxYgZPczZIqWrcAhAQzFlDZDBAFehY7IjYQl7l1YTVYIA0dtSmX bMsnXdccVqS6AqjSyNl/Fha5ZIll8c/YjplDtCJ0n5hTXOxyhU4+cKID8TGpOGdacEsk mP16u2ztl2o9sGx//NzcAA11zWl+8v8Y61ukTB3emHdK+zGa8EVa84v0iTH2sKfsjak7 Sp3OaatBt8g2v5Bdu1ZQIIS1g17mrFR/2/t4lfssN3mXY6OV+t1NXhvL+1ftikL0JkN0 eb1JafLmWOAzx1rn5+toqGrbn2MzXvgsP+WuM6Qe1j+neabxqq4OhUIOpni74CPuiYMN jLZg== X-Gm-Message-State: AOJu0Yymfw3PFTQt0C8+RDw1hJR3DypKO2hpcfqdoP5FpNmLgINBDHYP /MFiT1PgdD5O4UEuw5bJBOowSAjarNdtsjqUM85umqMkdl3yHEV44TuVSYPx/AoLCVUIjXIyjAy u0i8u8JP5sPpvKe97CA== X-Received: by 2002:a19:5010:0:b0:4fe:590:53ca with SMTP id e16-20020a195010000000b004fe059053camr1558212lfb.4.1692197795256; Wed, 16 Aug 2023 07:56:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCLpjiaX3qzE/mBS+mefHX9AIRlsP7bnPmOcTKMMagt8aDpQqD62k76/uiFqlkSMRdREIMsBumrtB2i1FbDIU= X-Received: by 2002:a19:5010:0:b0:4fe:590:53ca with SMTP id e16-20020a195010000000b004fe059053camr1558202lfb.4.1692197794906; Wed, 16 Aug 2023 07:56:34 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-3-bruce.richardson@intel.com> In-Reply-To: <20230815151053.996469-3-bruce.richardson@intel.com> From: David Marchand Date: Wed, 16 Aug 2023 16:56:23 +0200 Message-ID: Subject: Re: [PATCH v5 02/10] app/test: tag tests with the test type To: Bruce Richardson Cc: dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On Tue, Aug 15, 2023 at 5:23=E2=80=AFPM Bruce Richardson wrote: > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > index 623f34682e..bf1466fe11 100644 > --- a/app/test/test_acl.c > +++ b/app/test/test_acl.c > @@ -1749,4 +1749,4 @@ test_acl(void) > > #endif /* !RTE_EXEC_ENV_WINDOWS */ > > -REGISTER_TEST_COMMAND(acl_autotest, test_acl); > +REGISTER_FAST_TEST(acl_autotest, True, True, test_acl); A bit surprising to read "True" and not "true" in some C code. I see meson supports both forms. Do you have a reason to go with "True"? Maybe you prefer to keep it like this so it is not confused with the C boolean keyword? --=20 David Marchand