From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19D1845AF4; Wed, 9 Oct 2024 16:33:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EAD3427DB; Wed, 9 Oct 2024 16:33:16 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id AEAC4427A4 for ; Wed, 9 Oct 2024 16:33:12 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e2b159c609so541260a91.2 for ; Wed, 09 Oct 2024 07:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1728484392; x=1729089192; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qCs5rph7stcgbbOyi91zeCYAbyQRMuc7Y7fIJxOLawY=; b=T0jeSfh0sbf1ahRSAYr865g8KlVyCUuYSyLt3ndn6ue9eZbYmvENz6337fjN/hRgQe 82fcWaeHW92P6vPbYa7sfnr6SB6q1hwT+DtzReW6zDAp96O0x55dlC1fuVghbYjLGIpZ nN3DAOCODn/gt1G01KSgDVfFD3SyZ+Tfv9/as= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728484392; x=1729089192; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qCs5rph7stcgbbOyi91zeCYAbyQRMuc7Y7fIJxOLawY=; b=E66pDLsSJUheDuagPpDs7CsasgXx+cNCzp4WIENwjRrX0VErMV3mrYinnWozqxRYSX LqvjK3Ph97T4YQQh9hpeDRqYJewmHq+4OLuD4vxEnr4SEMpScXgchSyj40Fwi8GqbFuE B9TFxWN9NkwFLvV+WnN+NJ6149ya0fWYOepnHZDZXF2NMtlhvXsARQ+LungS4nApP8YG RzVbbxBeZ7RdD0RqTINi7pTC6+DDbFOtAE6ndy31pyw5SRvckr8ZUPbiOlEf1V2sjTD+ fl0M1YrZBuywI/mQ/Ru806X0fSwRYqu1Sih/XW+raJhvce4W7ThAaKDkmNkYS3veQAni jCkw== X-Forwarded-Encrypted: i=1; AJvYcCUronOH7qtVdealmExpXGBr7IvyymZdUQy1PdfBqN+/4DRI/7Ot1BHmqiBENiEbMyWR1g==@dpdk.org X-Gm-Message-State: AOJu0YxHDWhEciRDM+a+AnqINMT3rEqXteoJDHL3+dj7sGJ3oBYoB4oC VDDDyLL1NL3gt9x79zIUsjVs12ATBYdcHqKmwEml8o5f3WVQ5Gfx4woRxAVYsC4vPWO4CnhYBQ/ BrVDRL0Y/qwgjl2pOQ/PcsIqT95x0H0Ug3ySGDA== X-Google-Smtp-Source: AGHT+IH6chOsO6/j+orno7CmlOLmhHYtOOAGPDAvtcefZwbiVNV2eM+g/yGDfJTOCbgitf+9W96rhmTKM/CdtdvcXK4= X-Received: by 2002:a17:90b:1288:b0:2e0:7012:335a with SMTP id 98e67ed59e1d1-2e2a21eb985mr3111440a91.6.1728484391930; Wed, 09 Oct 2024 07:33:11 -0700 (PDT) MIME-Version: 1.0 References: <20240920125737.1197969-1-bruce.richardson@intel.com> <9a6c43e9-b2a1-15fe-9b7c-4178419f1e35@loongson.cn> In-Reply-To: <9a6c43e9-b2a1-15fe-9b7c-4178419f1e35@loongson.cn> From: Patrick Robb Date: Wed, 9 Oct 2024 10:31:53 -0400 Message-ID: Subject: Re: [PATCH 0/5] Increase minimum meson version To: zhoumin Cc: David Marchand , dpdklab , dev@dpdk.org, mb@smartsharesystems.com, thomas@monjalon.net, ci@dpdk.org, Bruce Richardson Content-Type: multipart/alternative; boundary="0000000000002e686b06240c223c" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --0000000000002e686b06240c223c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Min Zhou, I think it makes sense for you to set your meson version to the minimum version supported for DPDK (so, .57 now I suppose) instead of .63. The principle that David described above regarding LTS is also true for main. So, for the main and next-* branch testing that Loongson lab does, we want our CI testing to verify that no change relying on post .57 meson features get merged into main. On Tue, Oct 8, 2024 at 9:07=E2=80=AFPM zhoumin wrote: > Hi David, > > On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote: > > Hello CI guys, > > > > On Fri, Sep 20, 2024 at 2:57=E2=80=AFPM Bruce Richardson > > wrote: > >> This patchset proposed increasing the minimum meson version to 0.57 > >> and makes changes to update our build files appropriately for that > >> change: replacing deprecated functions, removing unnecessary version > >> checks and taking advantage of some new capabilities. > >> > >> Why 0.57? No one particular reason; it's mainly a conservative version > >> bump that doesn't have many impacts, but still gives us the minimum > >> updates we need to replace the deprecated get_cross_properties fn > >> and have a few extra features guaranteed available. > >> > >> Bruce Richardson (5): > >> build: increase minimum meson version to 0.57 > >> build: remove version check on compiler links function > >> build: remove unnecessary version checks > >> build: use version file support from meson > >> build: replace deprecated meson function > >> > >> .ci/linux-setup.sh | 2 +- > >> config/arm/meson.build | 4 ++-- > >> config/meson.build | 8 ++++---- > >> config/riscv/meson.build | 4 ++-- > >> doc/api/meson.build | 2 +- > >> doc/guides/linux_gsg/sys_reqs.rst | 2 +- > >> doc/guides/prog_guide/build-sdk-meson.rst | 2 +- > >> drivers/common/qat/meson.build | 2 +- > >> drivers/crypto/ipsec_mb/meson.build | 2 +- > >> drivers/event/cnxk/meson.build | 2 +- > >> drivers/meson.build | 7 ++----- > >> drivers/net/cnxk/meson.build | 2 +- > >> lib/meson.build | 6 ------ > >> meson.build | 7 ++----- > >> 14 files changed, 20 insertions(+), 32 deletions(-) > > This series can't be merged until the (UNH and LoongArch) CI are ready > > for such a change. > > > > TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57 > > in the current release. > > > > @UNH @Min Zhou > > How long would it take for all CI to be ready for this change? > It's OK for Loongson lab. The meson version for DPDK CI in Loongson lab > is 0.63.0. > > Important note: if relevant to your CI, testing against LTS branches > > must still be done with the 0.53.2 version, so no change relying on > > post 0.53.2 meson feature gets backported. > > > > > > --0000000000002e686b06240c223c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Min Zhou,

I think it makes sense for= you to set your meson version to the minimum version supported for DPDK (s= o, .57 now I suppose) instead of .63. The principle that David described ab= ove regarding LTS is also true for main. So, for the main and next-* branch= testing that Loongson lab does, we want our CI testing to verify that no c= hange relying on post .57 meson features get merged into main.=C2=A0
<= /div>
O= n Tue, Oct 8, 2024 at 9:07=E2=80=AFPM zhoumin <zhoumin@loongson.cn> wrote:
Hi David,

On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote:
> Hello CI guys,
>
> On Fri, Sep 20, 2024 at 2:57=E2=80=AFPM Bruce Richardson
> <br= uce.richardson@intel.com> wrote:
>> This patchset proposed increasing the minimum meson version to 0.5= 7
>> and makes changes to update our build files appropriately for that=
>> change: replacing deprecated functions, removing unnecessary versi= on
>> checks and taking advantage of some new capabilities.
>>
>> Why 0.57? No one particular reason; it's mainly a conservative= version
>> bump that doesn't have many impacts, but still gives us the mi= nimum
>> updates we need to replace the deprecated get_cross_properties fn<= br> >> and have a few extra features guaranteed available.
>>
>> Bruce Richardson (5):
>>=C2=A0 =C2=A0 build: increase minimum meson version to 0.57
>>=C2=A0 =C2=A0 build: remove version check on compiler links functio= n
>>=C2=A0 =C2=A0 build: remove unnecessary version checks
>>=C2=A0 =C2=A0 build: use version file support from meson
>>=C2=A0 =C2=A0 build: replace deprecated meson function
>>
>>=C2=A0 =C2=A0.ci/linux-setup.sh=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0config/arm/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++--
>>=C2=A0 =C2=A0config/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 8 ++++----
>>=C2=A0 =C2=A0config/riscv/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++--
>>=C2=A0 =C2=A0doc/api/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0doc/guides/linux_gsg/sys_reqs.rst=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0doc/guides/prog_guide/build-sdk-meson.rst | 2 +-
>>=C2=A0 =C2=A0drivers/common/qat/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0drivers/crypto/ipsec_mb/meson.build=C2=A0 =C2=A0 =C2= =A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0drivers/event/cnxk/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0drivers/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 7 ++-----
>>=C2=A0 =C2=A0drivers/net/cnxk/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0lib/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 6 ------
>>=C2=A0 =C2=A0meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 7 ++= -----
>>=C2=A0 =C2=A014 files changed, 20 insertions(+), 32 deletions(-) > This series can't be merged until the (UNH and LoongArch) CI are r= eady
> for such a change.
>
> TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57<= br> > in the current release.
>
> @UNH @Min Zhou
> How long would it take for all CI to be ready for this change?
It's OK for Loongson lab. The meson version for DPDK CI in Loongson lab=
is 0.63.0.
> Important note: if relevant to your CI, testing against LTS branches > must still be done with the 0.53.2 version, so no change relying on > post 0.53.2 meson feature gets backported.
>
>

--0000000000002e686b06240c223c--