#####################################################################
June 5, 2024
Attendees
* Patrick Robb
* Nicholas Pratte
* Dean Marx
* Luca Vizzarro
* Juraj Linkeš
* Paul Szczepanek
* Tomas Durovec
* Jeremy Spewock

#####################################################################
Minutes

=====================================================================
General Announcements
* Testsuites which have been picked up:
   * Dean picked up the vlan_testsuite since the previous meeting: https://bugs.dpdk.org/show_bug.cgi?id=1453
   * Nick has started on mac_filter
   
=====================================================================
Patch discussions
* Patches which can be merged?:
   * Juraj is going to try and check in with Thomas about the below patches, following this meeting
   * Mypy patch: https://patchwork.dpdk.org/project/dpdk/list/?series=32026
   * Error and usage improvements: https://patchwork.dpdk.org/project/dpdk/list/?series=32038
   * Hugepages patch has not been run on top of the new mypy version, so this should be checked. Will submit a subsequent version if new mypy flags anything, otherwise we will just ping Juraj indicating the patch is ready: https://patchwork.dpdk.org/project/dpdk/list/?series=32035
   * https://patches.dpdk.org/project/dpdk/list/?series=31790
   * https://patches.dpdk.org/project/dpdk/list/?series=31808
   * https://patches.dpdk.org/project/dpdk/list/?series=31811
* Improve interactive shell output gathering: https://patchwork.dpdk.org/project/dpdk/list/?series=32014
   * Needs a review from Juraj, but is “done” and is reviewed by Luca
* Capabilities patch:
   * On E810 and XL710, the non-offload testcase is skipping
      * Will not skip on E810 if you up the MTU before checking the capability - need to also check on XL710
      * When checking capabilities, one idea would be to set MTU to 9000, get scatter capability, set MTU back to 1500, so that we do not affect any other capabilities (i.e. what if another capability was disabled by a 9000 MTU)
      * Show rx port info 0 0 is probably still valid, but we are missing the correct port configuration which will give us the correct reading (the mtu configuration)
* Pre-built DPDK feature:
   * Idea is to scp in a DPDK tarball with a pre-built DPDK
   * User should be able to specify either:
      * a path to a dpdk repo where DPDK has NOT been built (can be local or on SUT)
      * Or a path to a DPDK repo with a build dir inside
   * Could remove the git-ref option as it becomes redundant with this option. You can easily checkout to an older commit hash, refer to this repo when running DTS
   * The use case we care about for developers is making it easy for them to make local changes to their repo, and seamlessly run DTS from that.
      * This is even easier than the git-ref option, as they don’t even need to commit anything, they can simply provide the path to their dpdk development repo
* Testpmd parameters patch:
   * Juraj will provide a review
* There is a blanket requirement for google format docstrings for every function
   * It would be a benefit if we had a script (should exist under dts-format-patch) which will support checking for these, and remind developers if they are submitting patches which are missing some docstrings
   * Pylama is being used to audit patches within dts-format-patch.sh currently, but is out of date and does not resolve this issue
   * Should look into using “Ruff” for the next release
   * Patrick Robbmake a new ticket for this issue
* API documentation building:
   * Expected to be merged soon
   * Testpmd params patch introduces a new module without an .rst, so this introduces a dependency. If both patches get merged at the same time, an additional patch for testpmd params can be included.
       
=====================================================================
Bugzilla discussions
* No discussion today

=====================================================================
Any other business
* There are some 24.07 roadmap contains items which will not get done:
   *  Externally compiled DPDK is starting to get worked on now, but will not be merged in this release
   * Dynamic Queue will probably not be merged this release, as we have shifted over to writing other testsuite which were not originally in our roadmap (like vlan)
      * Jeremy has indicated he can pick this up soon
* More discussion about creation of a quiet wire for DTS
   * Will proceed with writing testsuites according to current “wire noise tolerant” approach (send some packets with a given payload, sniff for a list of packets during testsuite, check for expected packets from output list)
   * Can provide support for quiet wire later if needed.
* Next meeting Jun 19, 2024